Re: [PATCH maintainer-tools] dim: Remove git commit --amend from dim_apply

[Daniel Vetter <daniel@ffwll.ch>]

On Fri, Nov 13, 2015 at 05:11:58PM +0200, Ander Conselvan De Oliveira wrote:
> On Fri, 2015-11-13 at 15:07 +0000, Tvrtko Ursulin wrote:
> > On 13/11/15 14:40, Ander Conselvan De Oliveira wrote:
> > > On Fri, 2015-11-13 at 12:31 +0000, Tvrtko Ursulin wrote:
> > > > On 13/11/15 12:16, Chris Wilson wrote:
> > > > > On Fri, Nov 13, 2015 at 02:05:39PM +0200, Ander Conselvan de Oliveira
> > > > > wrote:
> > > > > > Calling git --amend invokes the editor, which will not run if it
> > > > > > relies
> > > > > > on the terminal for input. So don't do that from dim_apply.
> > > > > > 
> > > > > > Signed-off-by: Ander Conselvan de Oliveira <
> > > > > > ander.conselvan.de.oliveira@intel.com>
> > > > > 
> > > > > Presumable the ammend is there for a good reason and removing it keeps
> > > > > the state dirty? So maybe --amend --no-edit?
> > > > 
> > > > In either case can also consider "test -t 0" which is like isatty(0).
> > > 
> > > I think that will always evaluate to false since you are supposed to cat the
> > > mbox to dim apply.
> > 
> > Question is then how does it work for Daniel. :)
> 
> If I understood correctly he uses gvim, which doesn't run on a terminal.

Yup. And I use git commit --amend to paste in all the r-b/t-b tags and all
that stuff. Maybe we need a DIM_POST_APPLY_CMD in .dimrc?
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx