From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 2/2] drm/i915: Fix oops caused by fbdev initialization failure Date: Thu, 19 Nov 2015 17:02:04 +0100 Message-ID: <20151119160204.GL17050@phenom.ffwll.local> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 84EF56E9C5 for ; Thu, 19 Nov 2015 08:02:08 -0800 (PST) Received: by wmec201 with SMTP id c201so124241038wme.1 for ; Thu, 19 Nov 2015 08:02:07 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lukas Wunner Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMTgsIDIwMTUgYXQgMDE6NDM6MjBQTSArMDEwMCwgTHVrYXMgV3VubmVyIHdy b3RlOgo+IGludGVsZmJfY3JlYXRlKCkgaXMgY2FsbGVkIG9uY2Ugb24gZHJpdmVyIGluaXRpYWxp emF0aW9uLiBJZiBpdCBmYWlscywKPiBpZmJkZXYtPmhlbHBlci5mYmRldiwgaWZiZGV2LT5mYiBv ciBpZmJkZXYtPmZiLT5vYmogbWF5IGJlIE5VTEwuCj4gCj4gRnVydGhlciB1cCBpbiB0aGUgY2Fs bCBzdGFjaywgaW50ZWxfZmJkZXZfaW5pdGlhbF9jb25maWcoKSBjYWxscwo+IGludGVsX2ZiZGV2 X2ZpbmkoKSB0byB0ZWFyIGRvd24gdGhlIGlmYmRldiBvbiBmYWlsdXJlLiBUaGlzIGNhbGxzCj4g aW50ZWxfZmJkZXZfZGVzdHJveSgpIHdoaWNoIGRlcmVmZXJlbmNlcyBpZmJkZXYtPmZiLiBGaXgg dGhlIGVuc3VpbmcKPiBvb3BzLgo+IAo+IEFsc28gY2hlY2sgaW4gdGhlc2UgZnVuY3Rpb25zIGlm IGlmYmRldiBpcyBub3QgTlVMTCB0byBhdm9pZCBvb3BzOgo+IAo+IGk5MTVfZ2VtX2ZyYW1lYnVm ZmVyX2luZm8oKSBpcyBjYWxsZWQgb24gYWNjZXNzIHRvIGRlYnVnZnMgZmlsZQo+ICJpOTE1X2dl bV9mcmFtZWJ1ZmZlciIgYW5kIGRlcmVmZXJlbmNlcyBpZmJkZXYsIGlmYmRldi0+aGVscGVyLmZi Cj4gYW5kIGlmYmRldi0+aGVscGVyLmZiLT5vYmouCj4gCj4gaW50ZWxfY29ubmVjdG9yX2FkZF90 b19mYmRldigpIC8gaW50ZWxfY29ubmVjdG9yX3JlbW92ZV9mcm9tX2ZiZGV2KCkKPiBhcmUgY2Fs bGVkIHdoZW4gcmVnaXN0ZXJpbmcgLyB1bnJlZ2lzdGVyaW5nIGFuIG1zdCBjb25uZWN0b3IgYW5k Cj4gZGVyZWZlcmVuY2UgaWZiZGV2Lgo+IAo+IHYzOiBEcm9wIGFkZGl0aW9uYWwgbnVsbCBwb2lu dGVyIGNoZWNrcyBpbiBpbnRlbF9mYmRldl9zZXRfc3VzcGVuZCgpLAo+ICAgICBpbnRlbF9mYmRl dl9vdXRwdXRfcG9sbF9jaGFuZ2VkKCkgYW5kIGludGVsX2ZiZGV2X3Jlc3RvcmVfbW9kZSgpCj4g ICAgIHNpbmNlIHRoZXkgYWxyZWFkeSBjaGVjayBpZiBpZmJkZXYgaXMgbm90IE5VTEwsIHdoaWNo IGlzIHN1ZmZpY2llbnQKPiAgICAgbm93IHRoYXQgaW50ZWxfZmJkZXZfZmluaSgpIGlzIGNhbGxl ZCBvbiBpbml0aWFsaXphdGlvbiBmYWlsdXJlLgo+ICAgICAoUmVxdWVzdGVkIGJ5IERhbmllbCBW ZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+KQo+IAo+IFNpZ25lZC1vZmYtYnk6IEx1a2Fz IFd1bm5lciA8bHVrYXNAd3VubmVyLmRlPgoKUXVldWVkIGZvciAtbmV4dCwgdGhhbmtzIGZvciB0 aGUgcGF0Y2guIEFzaWRlLCB3aXRoIHRoaXMgcGF0Y2ggYW5kIHRoZQpzdGF0aWMgaW5saW5lIGR1 bW1pZXMgZnJvbSBBcmNoaXQgSSB0aGluayB3ZSBjYW4gZHJvcCBtb3N0IG9mIHRoZSAjaWZkZWYK YmxvY2tzIChub3QgdGhlIG9uZSBpbiBkZWJ1Z2ZzIHRob3VnaCkuIENhcmUgZm9yIGEgZm9sbG93 LXVwIHBhdGNoIHRvCnJlbW92ZSB0aGVtIGFyb3VuZCBhZGQvcmVtb3ZlX29uZV9jb25uZWN0b3I/ Ci1EYW5pZWwKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgfCAy NCArKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHBfbXN0LmMgfCAxMCArKysrKysrKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Zi ZGV2LmMgIHwgIDYgKysrKy0tCj4gIDMgZmlsZXMgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwg MTUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZGVidWdmcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBpbmRl eCAwMzhkNWM2Li40MTFhOWM2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZGVidWdmcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMK PiBAQCAtMTg3NywxNyArMTg3NywxOSBAQCBzdGF0aWMgaW50IGk5MTVfZ2VtX2ZyYW1lYnVmZmVy X2luZm8oc3RydWN0IHNlcV9maWxlICptLCB2b2lkICpkYXRhKQo+ICAJc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAgCj4gIAlpZmJkZXYgPSBk ZXZfcHJpdi0+ZmJkZXY7Cj4gLQlmYiA9IHRvX2ludGVsX2ZyYW1lYnVmZmVyKGlmYmRldi0+aGVs cGVyLmZiKTsKPiAtCj4gLQlzZXFfcHJpbnRmKG0sICJmYmNvbiBzaXplOiAlZCB4ICVkLCBkZXB0 aCAlZCwgJWQgYnBwLCBtb2RpZmllciAweCVsbHgsIHJlZmNvdW50ICVkLCBvYmogIiwKPiAtCQkg ICBmYi0+YmFzZS53aWR0aCwKPiAtCQkgICBmYi0+YmFzZS5oZWlnaHQsCj4gLQkJICAgZmItPmJh c2UuZGVwdGgsCj4gLQkJICAgZmItPmJhc2UuYml0c19wZXJfcGl4ZWwsCj4gLQkJICAgZmItPmJh c2UubW9kaWZpZXJbMF0sCj4gLQkJICAgYXRvbWljX3JlYWQoJmZiLT5iYXNlLnJlZmNvdW50LnJl ZmNvdW50KSk7Cj4gLQlkZXNjcmliZV9vYmoobSwgZmItPm9iaik7Cj4gLQlzZXFfcHV0YyhtLCAn XG4nKTsKPiArCWlmIChpZmJkZXYpIHsKPiArCQlmYiA9IHRvX2ludGVsX2ZyYW1lYnVmZmVyKGlm YmRldi0+aGVscGVyLmZiKTsKPiArCj4gKwkJc2VxX3ByaW50ZihtLCAiZmJjb24gc2l6ZTogJWQg eCAlZCwgZGVwdGggJWQsICVkIGJwcCwgbW9kaWZpZXIgMHglbGx4LCByZWZjb3VudCAlZCwgb2Jq ICIsCj4gKwkJCSAgIGZiLT5iYXNlLndpZHRoLAo+ICsJCQkgICBmYi0+YmFzZS5oZWlnaHQsCj4g KwkJCSAgIGZiLT5iYXNlLmRlcHRoLAo+ICsJCQkgICBmYi0+YmFzZS5iaXRzX3Blcl9waXhlbCwK PiArCQkJICAgZmItPmJhc2UubW9kaWZpZXJbMF0sCj4gKwkJCSAgIGF0b21pY19yZWFkKCZmYi0+ YmFzZS5yZWZjb3VudC5yZWZjb3VudCkpOwo+ICsJCWRlc2NyaWJlX29iaihtLCBmYi0+b2JqKTsK PiArCQlzZXFfcHV0YyhtLCAnXG4nKTsKPiArCX0KPiAgI2VuZGlmCj4gIAo+ICAJbXV0ZXhfbG9j aygmZGV2LT5tb2RlX2NvbmZpZy5mYl9sb2NrKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHBfbXN0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9t c3QuYwo+IGluZGV4IDlkOGE1YjQuLjhjNGU3ZGYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHBfbXN0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcF9tc3QuYwo+IEBAIC00MDgsNyArNDA4LDEwIEBAIHN0YXRpYyB2b2lkIGludGVsX2Nvbm5l Y3Rvcl9hZGRfdG9fZmJkZXYoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICB7 Cj4gICNpZmRlZiBDT05GSUdfRFJNX0ZCREVWX0VNVUxBVElPTgo+ICAJc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjb25uZWN0b3ItPmJhc2UuZGV2KTsKPiAtCWRy bV9mYl9oZWxwZXJfYWRkX29uZV9jb25uZWN0b3IoJmRldl9wcml2LT5mYmRldi0+aGVscGVyLCAm Y29ubmVjdG9yLT5iYXNlKTsKPiArCj4gKwlpZiAoZGV2X3ByaXYtPmZiZGV2KQo+ICsJCWRybV9m Yl9oZWxwZXJfYWRkX29uZV9jb25uZWN0b3IoJmRldl9wcml2LT5mYmRldi0+aGVscGVyLAo+ICsJ CQkJCQkmY29ubmVjdG9yLT5iYXNlKTsKPiAgI2VuZGlmCj4gIH0KPiAgCj4gQEAgLTQxNiw3ICs0 MTksMTAgQEAgc3RhdGljIHZvaWQgaW50ZWxfY29ubmVjdG9yX3JlbW92ZV9mcm9tX2ZiZGV2KHN0 cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiAgewo+ICAjaWZkZWYgQ09ORklHX0RS TV9GQkRFVl9FTVVMQVRJT04KPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IHRvX2k5MTUoY29ubmVjdG9yLT5iYXNlLmRldik7Cj4gLQlkcm1fZmJfaGVscGVyX3JlbW92ZV9v bmVfY29ubmVjdG9yKCZkZXZfcHJpdi0+ZmJkZXYtPmhlbHBlciwgJmNvbm5lY3Rvci0+YmFzZSk7 Cj4gKwo+ICsJaWYgKGRldl9wcml2LT5mYmRldikKPiArCQlkcm1fZmJfaGVscGVyX3JlbW92ZV9v bmVfY29ubmVjdG9yKCZkZXZfcHJpdi0+ZmJkZXYtPmhlbHBlciwKPiArCQkJCQkJICAgJmNvbm5l Y3Rvci0+YmFzZSk7Cj4gICNlbmRpZgo+ICB9Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJk ZXYuYwo+IGluZGV4IGNkMzQ1YzUuLjdjY2RlNTggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZmJkZXYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2ZiZGV2LmMKPiBAQCAtNTMwLDggKzUzMCwxMCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9mYmRldl9k ZXN0cm95KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAo+ICAJZHJtX2ZiX2hlbHBlcl9maW5p KCZpZmJkZXYtPmhlbHBlcik7Cj4gIAo+IC0JZHJtX2ZyYW1lYnVmZmVyX3VucmVnaXN0ZXJfcHJp dmF0ZSgmaWZiZGV2LT5mYi0+YmFzZSk7Cj4gLQlkcm1fZnJhbWVidWZmZXJfcmVtb3ZlKCZpZmJk ZXYtPmZiLT5iYXNlKTsKPiArCWlmIChpZmJkZXYtPmZiKSB7Cj4gKwkJZHJtX2ZyYW1lYnVmZmVy X3VucmVnaXN0ZXJfcHJpdmF0ZSgmaWZiZGV2LT5mYi0+YmFzZSk7Cj4gKwkJZHJtX2ZyYW1lYnVm ZmVyX3JlbW92ZSgmaWZiZGV2LT5mYi0+YmFzZSk7Cj4gKwl9Cj4gIH0KPiAgCj4gIC8qCj4gLS0g Cj4gMi4xLjAKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBD b3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=