From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Wunner Subject: Re: [PATCH v3 1/2] drm/i915: Tear down fbdev if initialization fails Date: Thu, 19 Nov 2015 17:08:13 +0100 Message-ID: <20151119160813.GA25417@wunner.de> References: <49ce5f0daead24b7598ec78591731046c333c18d.1447938059.git.lukas@wunner.de> <20151119155844.GK17050@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout1.hostsharing.net (mailout1.hostsharing.net [83.223.95.204]) by gabe.freedesktop.org (Postfix) with ESMTPS id 870026E9CC for ; Thu, 19 Nov 2015 08:08:18 -0800 (PST) Content-Disposition: inline In-Reply-To: <20151119155844.GK17050@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Tejun Heo , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGksCgpPbiBUaHUsIE5vdiAxOSwgMjAxNSBhdCAwNDo1ODo0NFBNICswMTAwLCBEYW5pZWwgVmV0 dGVyIHdyb3RlOgo+IE9uIFdlZCwgTm92IDE4LCAyMDE1IGF0IDA0OjI5OjUxUE0gKzAxMDAsIEx1 a2FzIFd1bm5lciB3cm90ZToKPiA+IEN1cnJlbnRseSBpZiBpbnRlbGZiX2NyZWF0ZSgpIGVycm9y cyBvdXQsIGl0IHVucmVmcyB0aGUgYm8gZXZlbiB0aG91Z2gKPiA+IHRoZSBmYiBub3cgb3ducyB0 aGF0IHJlZmVyZW5jZS4gKFNwb3R0ZWQgYnkgVmlsbGUgU3lyasOkbMOkLikgV2Ugc2hvdWxkCj4g PiB1bnJlZiB0aGUgZmIgaW5zdGVhZCBvZiB0aGUgYm8uCj4gPiAKPiA+IEhvd2V2ZXIgdGhlIGZi IHdhcyBub3QgbmVjZXNzYXJpbHkgYWxsb2NhdGVkIGJ5IGludGVsZmJfY3JlYXRlKCksCj4gPiBp dCBjb3VsZCBiZSBpbmhlcml0ZWQgZnJvbSBCSU9TICh0aGUgZmIgc3RydWN0IHdhcyB0aGVuIGFs bG9jYXRlZCBieQo+ID4gZGV2X3ByaXYtPmRpc3BsYXkuZ2V0X2luaXRpYWxfcGxhbmVfY29uZmln KCkpIGFuZCBiZSBpbiBhY3RpdmUgdXNlIGJ5Cj4gPiBhIGNydGMuIEluIHRoaXMgY2FzZSB3ZSBz aG91bGQgY2FsbCBkcm1fZnJhbWVidWZmZXJfcmVtb3ZlKCkgaW5zdGVhZAo+ID4gb2YgX3VucmVm ZXJlbmNlKCkgdG8gYWxzbyBkaXNhYmxlIHRoZSBjcnRjLgo+ID4gCj4gPiBEYW5pZWwgVmV0dGVy IHN1Z2dlc3RlZCB0aGF0ICJmYmRldiB0ZWFyZG93biBjb2RlIHdpbGwgdGFrZSBjYXJlIG9mIGl0 Lgo+ID4gVGhlIGNvcnJlY3QgYXBwcm9hY2ggaXMgcHJvYmFibHkgdG8gbm90IHVucmVmIGFueXRo aW5nIGF0IGFsbCIuCj4gPiAKPiA+IEJ1dCBpZiBmYmRldiBpbml0aWFsaXphdGlvbiBmYWlscywg dGhlIGZiZGV2IGlzbid0IHRvcm4gZG93biBhbmQKPiA+IG9jY3VwaWVzIG1lbW9yeSBldmVuIHRo b3VnaCBpdCdzIHVudXNhYmxlLiBUaGVyZWZvcmUgY2xvYmJlciBpdCBpbgo+ID4gaW50ZWxfZmJk ZXZfaW5pdGlhbF9jb25maWcoKS4gKEN1cnJlbnRseSB3ZSBpZ25vcmUgYSBuZWdhdGl2ZSByZXR1 cm4KPiA+IHZhbHVlIHRoZXJlLikgVGhlIGlkZWEgaXMgdGhhdCBpZiBmYmRldiBpbml0aWFsaXph dGlvbiBmYWlscywgdGhlIGRyaXZlcgo+ID4gYmVoYXZlcyBhcyBpZiBDT05GSUdfRFJNX0ZCREVW X0VNVUxBVElPTiB3YXNuJ3Qgc2V0LiBTaG91bGQgWDExIG1hbmFnZQo+ID4gdG8gc3RhcnQgdXAg d2l0aG91dCBlcnJvcnMsIGl0IHdpbGwgYXQgbGVhc3QgYmUgYWJsZSB0byB1c2UgdGhlIG1lbW9y eQo+ID4gdGhhdCB3b3VsZCBvdGhlcndpc2UgYmUgaG9nZ2VkIGJ5IHRoZSB1bnVzYWJsZSBmYmRl di4KPiA+IAo+ID4gQWxzbywgbG9nIGVycm9ycyBpbiBpbnRlbGZiX2NyZWF0ZSgpLgo+ID4gCj4g PiBEb24ndCBjYWxsIGFzeW5jX3N5bmNocm9uaXplX2Z1bGwoKSBpbiBpbnRlbF9mYmRldl9maW5p KCkgd2hlbiBjYWxsZWQKPiA+IGZyb20gaW50ZWxfZmJkZXZfaW5pdGlhbF9jb25maWcoKSB0byBh dm9pZCBkZWFkbG9jay4KPiA+IAo+ID4gdjI6IEluc3RlYWQgb2YgY2FsbGluZyBkcm1fZnJhbWVi dWZmZXJfdW5yZWZlcmVuY2UoKSAoaWYgZmIgd2FzIG5vdAo+ID4gICAgIGluaGVyaXRlZCBmcm9t IEJJT1MpLCBjYWxsIGludGVsX2ZiZGV2X2ZpbmkoKS4KPiA+IAo+ID4gdjM6IFJlYmFzZSBvbiBl MDBiZjY5NjQ0YmEgKGRybS9pOTE1OiBNb3ZlIHRoZSBmYmRldiBhc3luY19zY2hlZHVsZSgpCj4g PiAgICAgaW50byBpbnRlbF9mYmRldi5jKSwgY2FsbCBhc3luY19zeW5jaHJvbml6ZV9mdWxsKCkg Y29uZGl0aW9uYWxseQo+ID4gICAgIGluc3RlYWQgb2YgbW92aW5nIGl0IGludG8gaTkxNV9kcml2 ZXJfdW5sb2FkKCkuCj4gPiAKPiA+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZm d2xsLmNoPgo+ID4gU2lnbmVkLW9mZi1ieTogTHVrYXMgV3VubmVyIDxsdWthc0B3dW5uZXIuZGU+ Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jIHwgMTAgKysr KysrKy0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25z KC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRl di5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYuYwo+ID4gaW5kZXggOTg3NzJk My4uY2QzNDVjNSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Zi ZGV2LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMKPiA+IEBA IC0yMjcsNiArMjI3LDcgQEAgc3RhdGljIGludCBpbnRlbGZiX2NyZWF0ZShzdHJ1Y3QgZHJtX2Zi X2hlbHBlciAqaGVscGVyLAo+ID4gIAo+ID4gIAlpbmZvID0gZHJtX2ZiX2hlbHBlcl9hbGxvY19m YmkoaGVscGVyKTsKPiA+ICAJaWYgKElTX0VSUihpbmZvKSkgewo+ID4gKwkJRFJNX0VSUk9SKCJG YWlsZWQgdG8gYWxsb2NhdGUgZmJfaW5mb1xuIik7Cj4gPiAgCQlyZXQgPSBQVFJfRVJSKGluZm8p Owo+ID4gIAkJZ290byBvdXRfdW5waW47Cj4gPiAgCX0KPiA+IEBAIC0yNTMsNiArMjU0LDcgQEAg c3RhdGljIGludCBpbnRlbGZiX2NyZWF0ZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLAo+ ID4gIAkJaW9yZW1hcF93YyhkZXZfcHJpdi0+Z3R0Lm1hcHBhYmxlX2Jhc2UgKyBpOTE1X2dlbV9v YmpfZ2d0dF9vZmZzZXQob2JqKSwKPiA+ICAJCQkgICBzaXplKTsKPiA+ICAJaWYgKCFpbmZvLT5z Y3JlZW5fYmFzZSkgewo+ID4gKwkJRFJNX0VSUk9SKCJGYWlsZWQgdG8gcmVtYXAgZnJhbWVidWZm ZXIgaW50byB2aXJ0dWFsIG1lbW9yeVxuIik7Cj4gPiAgCQlyZXQgPSAtRU5PU1BDOwo+ID4gIAkJ Z290byBvdXRfZGVzdHJveV9mYmk7Cj4gPiAgCX0KPiA+IEBAIC0yODUsNyArMjg3LDYgQEAgb3V0 X2Rlc3Ryb3lfZmJpOgo+ID4gIAlkcm1fZmJfaGVscGVyX3JlbGVhc2VfZmJpKGhlbHBlcik7Cj4g PiAgb3V0X3VucGluOgo+ID4gIAlpOTE1X2dlbV9vYmplY3RfZ2d0dF91bnBpbihvYmopOwo+ID4g LQlkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZSgmb2JqLT5iYXNlKTsKPiA+ICAJbXV0ZXhfdW5s b2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gPiAgCXJldHVybiByZXQ7Cj4gPiAgfQo+ID4gQEAg LTcxMSw3ICs3MTIsOSBAQCBzdGF0aWMgdm9pZCBpbnRlbF9mYmRldl9pbml0aWFsX2NvbmZpZyh2 b2lkICpkYXRhLCBhc3luY19jb29raWVfdCBjb29raWUpCj4gPiAgCXN0cnVjdCBpbnRlbF9mYmRl diAqaWZiZGV2ID0gZGV2X3ByaXYtPmZiZGV2Owo+ID4gIAo+ID4gIAkvKiBEdWUgdG8gcGVjdWxp YXIgaW5pdCBvcmRlciB3cnQgdG8gaHBkIGhhbmRsaW5nIHRoaXMgaXMgc2VwYXJhdGUuICovCj4g PiAtCWRybV9mYl9oZWxwZXJfaW5pdGlhbF9jb25maWcoJmlmYmRldi0+aGVscGVyLCBpZmJkZXYt PnByZWZlcnJlZF9icHApOwo+ID4gKwlpZiAoZHJtX2ZiX2hlbHBlcl9pbml0aWFsX2NvbmZpZygm aWZiZGV2LT5oZWxwZXIsCj4gPiArCQkJCQkgaWZiZGV2LT5wcmVmZXJyZWRfYnBwKSkKPiA+ICsJ CWludGVsX2ZiZGV2X2ZpbmkoZGV2X3ByaXYtPmRldik7Cj4gPiAgfQo+ID4gIAo+ID4gIHZvaWQg aW50ZWxfZmJkZXZfaW5pdGlhbF9jb25maWdfYXN5bmMoc3RydWN0IGRybV9kZXZpY2UgKmRldikK PiA+IEBAIC03MjcsNyArNzMwLDggQEAgdm9pZCBpbnRlbF9mYmRldl9maW5pKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYpCj4gPiAgCj4gPiAgCWZsdXNoX3dvcmsoJmRldl9wcml2LT5mYmRldl9zdXNw ZW5kX3dvcmspOwo+ID4gIAo+ID4gLQlhc3luY19zeW5jaHJvbml6ZV9mdWxsKCk7Cj4gPiArCWlm ICghY3VycmVudF9pc19hc3luYygpKQo+ID4gKwkJYXN5bmNfc3luY2hyb25pemVfZnVsbCgpOwo+ IAo+IEkgdGhpbmsgdGhpcyBpcyBhIGJpdCB0b28gZnJhZ2lsZSwgYW5kIHRoZSBjb3JlIGRlcGVu Y3kgd2lsbCBtYWtlIG1lcmdpbmcKPiB0cmlja3kuIENhbid0IHdlIGp1c3QgcHVzaCB0aGUgYXN5 bmNfc3luY2hyb25pemVfZnVsbCBpbnRvIG1vZHVsZSB1bmxvYWQKPiBmb3Igbm93PwoKVGhhdCB3 YXMgbXkgb3JpZ2luYWwgc3VnZ2VzdGlvbiBidXQgVmlsbGUgZGlkbid0IGxpa2UgaXQuLi4gOi0p CgpNZXNzYWdlLUlEOiA8MjAxNTExMDkxMTAwNTAuR1c0NDM3QGludGVsLmNvbT4KTGluazogaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9pbnRlbC1nZngvMjAxNS1Ob3ZlbWJl ci8wNzk3MjguaHRtbAoKQXMgZm9yIG1lcmdpbmcgYmVpbmcgdHJpY2t5LCBpZiBUZWp1biBvbmx5 IGFja3MgdGhlIG90aGVyIHBhdGNoIG1heWJlIGl0CmNhbiBiZSBtZXJnZWQgdGhyb3VnaCBkcm0t aW50ZWwtbmV4dC1xdWV1ZWQgKGJhcnJpbmcgYW55IG9iamVjdGlvbnMKYWdhaW5zdCB0aGUgcGF0 Y2ggaXRzZWxmIG9mIGNvdXJzZSkuCgpCZXN0IHJlZ2FyZHMsCgpMdWthcwoKPiAtRGFuaWVsCj4g Cj4gPiAgCWludGVsX2ZiZGV2X2Rlc3Ryb3koZGV2LCBkZXZfcHJpdi0+ZmJkZXYpOwo+ID4gIAlr ZnJlZShkZXZfcHJpdi0+ZmJkZXYpOwo+ID4gIAlkZXZfcHJpdi0+ZmJkZXYgPSBOVUxMOwo+ID4g LS0gCj4gPiAyLjEuMAo+ID4gCj4gCj4gLS0gCj4gRGFuaWVsIFZldHRlcgo+IFNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+IGh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==