Re: [PATCH 1/2] drm/i915/pm: Unconstify power_domain_str

Daniel Stone
2015-11-20T15:56:16Z

On 20 November 2015 at 08:21, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Thu, 19 Nov 2015, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
>> On Thu, Nov 19, 2015 at 06:26:23PM +0000, Daniel Stone wrote:
>>> Surely gcc's DCE pass will trivially eliminate this?
>>
>> Dunno. But I rather dislike having code in headers anyway.
>
> Agreed, particularly for long ones like this. Please just drop the
> static.

Purple it is; re-sent. Augmented commit message explains why it can't
live in i915_debugfs.c.

Cheers,
Daniel