From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915/guc: Move wait for GuC out of spinlock/unlock Date: Tue, 24 Nov 2015 14:04:10 +0100 Message-ID: <20151124130410.GW17050@phenom.ffwll.local> References: <20151120084542.GU17050@phenom.ffwll.local> <1448319778-29282-1-git-send-email-yu.dai@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id EA4CF6E1BB for ; Tue, 24 Nov 2015 05:04:14 -0800 (PST) Received: by wmec201 with SMTP id c201so207825422wme.0 for ; Tue, 24 Nov 2015 05:04:13 -0800 (PST) Content-Disposition: inline In-Reply-To: <1448319778-29282-1-git-send-email-yu.dai@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: yu.dai@intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBOb3YgMjMsIDIwMTUgYXQgMDM6MDI6NThQTSAtMDgwMCwgeXUuZGFpQGludGVsLmNv bSB3cm90ZToKPiBGcm9tOiBBbGV4IERhaSA8eXUuZGFpQGludGVsLmNvbT4KPiAKPiBXaGVuIEd1 QyBXb3JrIFF1ZXVlIGlzIGZ1bGwsIGRyaXZlciB3aWxsIHdhaXQgR3VDIGZvciBhdmFsaWFibGUK PiBzcGFjZSBieSBkZWxheWluZyAxbXMuIFRoZSB3YWl0IG5lZWRzIHRvIGJlIG91dCBvZiBzcGlu bG9ja2lycSAvCj4gdW5sb2NrLiBPdGhlcndpc2UsIGxvY2t1cCBoYXBwZW5zIGJlY2F1c2Ugamlm ZmllcyB3b24ndCBiZSB1cGRhdGVkCj4gZHVyIHRvIGlycSBpcyBkaXNhYmxlZC4KPiAKPiBJc3N1 ZSBpcyBmb3VuZCBpbiBpZ3QvZ2VtX2Nsb3NlX3JhY2UuCj4gCj4gU2lnbmVkLW9mZi1ieTogQWxl eCBEYWkgPHl1LmRhaUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ3VjX3N1Ym1pc3Npb24uYyB8IDI3ICsrKysrKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+IGluZGV4IDBhNmIwMDcu LjE0MTgzOTcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3Vi bWlzc2lvbi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ndWNfc3VibWlzc2lv bi5jCj4gQEAgLTIwMSwxMCArMjAxLDEzIEBAIHN0YXRpYyBpbnQgZ3VjX3JpbmdfZG9vcmJlbGwo c3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqZ2MpCj4gIAl1bmlvbiBndWNfZG9vcmJlbGxfcXcgKmRi Owo+ICAJdm9pZCAqYmFzZTsKPiAgCWludCBhdHRlbXB0ID0gMiwgcmV0ID0gLUVBR0FJTjsKPiAr CXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4gIAo+ICAJYmFzZSA9IGttYXBfYXRvbWljKGk5MTVfZ2Vt X29iamVjdF9nZXRfcGFnZShnYy0+Y2xpZW50X29iaiwgMCkpOwoKV2UgZG9uJ3QgbmVlZCBrbWFw X2F0b21pYyBhbnltb3JlIGhlcmUgbm93LCBzaW5jZSBpdCdzIG91dHNpZGUgb2YgdGhlCnNwaW5s b2NrLgoKPiAgCWRlc2MgPSBiYXNlICsgZ2MtPnByb2NfZGVzY19vZmZzZXQ7Cj4gIAo+ICsJc3Bp bl9sb2NrX2lycXNhdmUoJmdjLT53cV9sb2NrLCBmbGFncyk7CgpQbGVhc2UgZG9uJ3QgdXNlIHRo ZSBzdXBlci1nZW5lcmljIF9pcnFzYXZlLiBJdCdzIGV4cGVuc2l2ZSBhbmQgcmVzdWx0cyBpbgpm cmFnaWxlIGNvZGUgd2hlbiBzb21lb25lIGFjY2lkZW50YWxseSByZXVzZXMgc29tZXRoaW5nIGlu IGFuIGludGVycnVwdApoYW5kbGVyIHRoYXQgd2FzIG5ldmVyIG1lYW50IHRvIHJ1biBpbiB0aGF0 IGNvbnRleHQuCgpJbnN0ZWFkIHBsZWFzZSB1c2UgdGhlIG1vc3Qgc3BlY2lmaWMgZnVudGlvbjoK LSBzcGluX2xvY2sgaWYgeW91IGtub3cgeW91IGFyZSBpbiBpcnEgY29udGV4dC4KLSBzaXBuX2xv Y2tfaXJxIGlmIHlvdSBrbm93IHlvdSBhcmUgbm90LgotIHNwaW5fbG9ja19pcnFzYXZlIHNob3Vs ZCBiZSBhIGJpZyB3YXJuaW5nIHNpZ24gdGhhdCB5b3VyIGNvZGUgaGFzCiAgbGF5ZXJpbmcgaXNz dWVzLgoKUGxlYXNlIGF1ZGl0IHRoZSBlbnRpcmUgZ3VjIGNvZGUgZm9yIHRoZSBhYm92ZSB0d28g aXNzdWVzLgoKPiArCj4gIAkvKiBVcGRhdGUgdGhlIHRhaWwgc28gaXQgaXMgdmlzaWJsZSB0byBH dUMgKi8KPiAgCWRlc2MtPnRhaWwgPSBnYy0+d3FfdGFpbDsKPiAgCj4gQEAgLTI0OCw3ICsyNTEs MTAgQEAgc3RhdGljIGludCBndWNfcmluZ19kb29yYmVsbChzdHJ1Y3QgaTkxNV9ndWNfY2xpZW50 ICpnYykKPiAgCQkJZGJfZXhjLmNvb2tpZSA9IDE7Cj4gIAl9Cj4gIAo+ICsJc3Bpbl91bmxvY2tf aXJxcmVzdG9yZSgmZ2MtPndxX2xvY2ssIGZsYWdzKTsKPiArCj4gIAlrdW5tYXBfYXRvbWljKGJh c2UpOwo+ICsKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gQEAgLTQ4NywxNiArNDkzLDE2IEBA IHN0YXRpYyBpbnQgZ3VjX2dldF93b3JrcXVldWVfc3BhY2Uoc3RydWN0IGk5MTVfZ3VjX2NsaWVu dCAqZ2MsIHUzMiAqb2Zmc2V0KQo+ICAJc3RydWN0IGd1Y19wcm9jZXNzX2Rlc2MgKmRlc2M7Cj4g IAl2b2lkICpiYXNlOwo+ICAJdTMyIHNpemUgPSBzaXplb2Yoc3RydWN0IGd1Y193cV9pdGVtKTsK PiAtCWludCByZXQgPSAwLCB0aW1lb3V0X2NvdW50ZXIgPSAyMDA7Cj4gKwlpbnQgcmV0ID0gLUVU SU1FRE9VVCwgdGltZW91dF9jb3VudGVyID0gMjAwOwo+ICsJdW5zaWduZWQgbG9uZyBmbGFnczsK PiAgCj4gIAliYXNlID0ga21hcF9hdG9taWMoaTkxNV9nZW1fb2JqZWN0X2dldF9wYWdlKGdjLT5j bGllbnRfb2JqLCAwKSk7Cj4gIAlkZXNjID0gYmFzZSArIGdjLT5wcm9jX2Rlc2Nfb2Zmc2V0Owo+ ICAKPiAgCXdoaWxlICh0aW1lb3V0X2NvdW50ZXItLSA+IDApIHsKPiAtCQlyZXQgPSB3YWl0X2Zv cl9hdG9taWMoQ0lSQ19TUEFDRShnYy0+d3FfdGFpbCwgZGVzYy0+aGVhZCwKPiAtCQkJCWdjLT53 cV9zaXplKSA+PSBzaXplLCAxKTsKPiArCQlzcGluX2xvY2tfaXJxc2F2ZSgmZ2MtPndxX2xvY2ss IGZsYWdzKTsKPiAgCj4gLQkJaWYgKCFyZXQpIHsKPiArCQlpZiAoQ0lSQ19TUEFDRShnYy0+d3Ff dGFpbCwgZGVzYy0+aGVhZCwgZ2MtPndxX3NpemUpID49IHNpemUpIHsKPiAgCQkJKm9mZnNldCA9 IGdjLT53cV90YWlsOwo+ICAKPiAgCQkJLyogYWR2YW5jZSB0aGUgdGFpbCBmb3IgbmV4dCB3b3Jr cXVldWUgaXRlbSAqLwo+IEBAIC01MDUsNyArNTExLDEzIEBAIHN0YXRpYyBpbnQgZ3VjX2dldF93 b3JrcXVldWVfc3BhY2Uoc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqZ2MsIHUzMiAqb2Zmc2V0KQo+ ICAKPiAgCQkJLyogdGhpcyB3aWxsIGJyZWFrIHRoZSBsb29wICovCj4gIAkJCXRpbWVvdXRfY291 bnRlciA9IDA7Cj4gKwkJCXJldCA9IDA7Cj4gIAkJfQo+ICsKPiArCQlzcGluX3VubG9ja19pcnFy ZXN0b3JlKCZnYy0+d3FfbG9jaywgZmxhZ3MpOwo+ICsKPiArCQlpZiAodGltZW91dF9jb3VudGVy KQo+ICsJCQl1c2xlZXBfcmFuZ2UoMTAwMCwgMjAwMCk7CgpEbyB3ZSByZWFsbHkgbm90IGhhdmUg YSBpbnRlcnJ1cHQvc2lnbmFsIGZyb20gdGhlIGd1YyB3aGVuIGl0IGhhcyBjbGVhcmVkCnVwIHNv bWUgc3BhY2U/Cgo+ICAJfTsKPiAgCj4gIAlrdW5tYXBfYXRvbWljKGJhc2UpOwo+IEBAIC01OTcs MTkgKzYwOSwxNyBAQCBpbnQgaTkxNV9ndWNfc3VibWl0KHN0cnVjdCBpOTE1X2d1Y19jbGllbnQg KmNsaWVudCwKPiAgewo+ICAJc3RydWN0IGludGVsX2d1YyAqZ3VjID0gY2xpZW50LT5ndWM7Cj4g IAllbnVtIGludGVsX3JpbmdfaWQgcmluZ19pZCA9IHJxLT5yaW5nLT5pZDsKPiAtCXVuc2lnbmVk IGxvbmcgZmxhZ3M7Cj4gIAlpbnQgcV9yZXQsIGJfcmV0Owo+ICAKPiAgCS8qIE5lZWQgdGhpcyBi ZWNhdXNlIG9mIHRoZSBkZWZlcnJlZCBwaW4gY3R4IGFuZCByaW5nICovCj4gIAkvKiBTaGFsbCB3 ZSBtb3ZlIHRoaXMgcmlnaHQgYWZ0ZXIgcmluZyBpcyBwaW5uZWQ/ICovCj4gIAlscl9jb250ZXh0 X3VwZGF0ZShycSk7Cj4gIAo+IC0Jc3Bpbl9sb2NrX2lycXNhdmUoJmNsaWVudC0+d3FfbG9jaywg ZmxhZ3MpOwo+IC0KPiAgCXFfcmV0ID0gZ3VjX2FkZF93b3JrcXVldWVfaXRlbShjbGllbnQsIHJx KTsKPiAgCWlmIChxX3JldCA9PSAwKQo+ICAJCWJfcmV0ID0gZ3VjX3JpbmdfZG9vcmJlbGwoY2xp ZW50KTsKPiAgCj4gKwlzcGluX2xvY2soJmd1Yy0+aG9zdDJndWNfbG9jayk7CgpTbyBhdCBmaXJz dCBJIHRob3VnaHQgdGhlcmUncyBhIHJhY2Ugbm93LCBidXQgdGhlbiBJIGxvb2tlZCBhdCB3aGF0 Cmhvc3QyZ3VjIGFuZCB3cV9sb2NrIHByb3RlY3QuIEl0IHNlZW1zIGxpa2UgdGhlIG9ubHkgdGhp bmcgdGhleSBkbyBpcwpwcm90ZWN0IGFnYWluc3QgZGVidWdmcywgYWxsIHRoZSByZWFsIHByb3Rl Y3Rpb24gYWdhaW5zdCBpbmNvbnNpc3RlbnQKc3RhdGUgaXMgZG9uZSB0aHJvdWdoIGRldi0+c3Ry dWN0X211dGV4LgoKQ2FuJ3Qgd2UganVzdCByaXAgb3V0IGFsbCB0aGlzIHNwaW5sb2NrIGJ1c2lu ZXNzIGZyb20gdGhlIGd1YyBjb2RlPwpJdCB3b3VsZCBiZSBlYXNpZXIgdGhhbiBmaXhpbmcgdXAg dGhlIHJhY2VzIGluIGhlcmUuCi1EYW5pZWwKCj4gIAljbGllbnQtPnN1Ym1pc3Npb25zW3Jpbmdf aWRdICs9IDE7Cj4gIAlpZiAocV9yZXQpIHsKPiAgCQljbGllbnQtPnFfZmFpbCArPSAxOwo+IEBA IC02MjAsOSArNjMwLDYgQEAgaW50IGk5MTVfZ3VjX3N1Ym1pdChzdHJ1Y3QgaTkxNV9ndWNfY2xp ZW50ICpjbGllbnQsCj4gIAl9IGVsc2Ugewo+ICAJCWNsaWVudC0+cmV0Y29kZSA9IDA7Cj4gIAl9 Cj4gLQlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZjbGllbnQtPndxX2xvY2ssIGZsYWdzKTsKPiAt Cj4gLQlzcGluX2xvY2soJmd1Yy0+aG9zdDJndWNfbG9jayk7Cj4gIAlndWMtPnN1Ym1pc3Npb25z W3JpbmdfaWRdICs9IDE7Cj4gIAlndWMtPmxhc3Rfc2Vxbm9bcmluZ19pZF0gPSBycS0+c2Vxbm87 Cj4gIAlzcGluX3VubG9jaygmZ3VjLT5ob3N0Mmd1Y19sb2NrKTsKPiAtLSAKPiAyLjUuMAo+IAoK LS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0 dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==