From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 05/12] drm/i915: Remove the identical implementations of request space reservation Date: Tue, 24 Nov 2015 15:42:20 +0100 Message-ID: <20151124144220.GL17050@phenom.ffwll.local> References: <1448023432-10726-1-git-send-email-chris@chris-wilson.co.uk> <1448023432-10726-5-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 47E486E94F for ; Tue, 24 Nov 2015 06:42:24 -0800 (PST) Received: by wmuu63 with SMTP id u63so99395498wmu.0 for ; Tue, 24 Nov 2015 06:42:23 -0800 (PST) Content-Disposition: inline In-Reply-To: <1448023432-10726-5-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBOb3YgMjAsIDIwMTUgYXQgMTI6NDM6NDVQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE5vdyB0aGF0IHdlIHNoYXJlIGludGVsX3JpbmdfYmVnaW4oKSwgcmVzZXJ2aW5nIHNw YWNlIGZvciB0aGUgdGFpbCBvZgo+IHRoZSByZXF1ZXN0IGlzIGlkZW50aWNhbCBiZXR3ZWVuIGxl Z2FjeS9leGVjbGlzdHMgYW5kIHNvIHRoZSB0YXV0b2xvZ3kKPiBjYW4gYmUgcmVtb3ZlZC4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4K ClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgICAgICAgIHwgIDcgKysrLS0t LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyAgICAgICAgfCAxNSAtLS0tLS0t LS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmggICAgICAgIHwgIDEg LQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMgfCAxNSAtLS0tLS0t LS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oIHwgIDMg LS0tCj4gIDUgZmlsZXMgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzOCBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBpbmRleCBjNjAxMDVlMzYyNjMuLjAzMGZjOWQx NDM4NSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC0yNzQzLDEwICsyNzQzLDkg QEAgaW50IGk5MTVfZ2VtX3JlcXVlc3RfYWxsb2Moc3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmlu ZywKPiAgCSAqIHRvIGJlIHJlZG9uZSBpZiB0aGUgcmVxdWVzdCBpcyBub3QgYWN0dWFsbHkgc3Vi bWl0dGVkIHN0cmFpZ2h0Cj4gIAkgKiBhd2F5LCBlLmcuIGJlY2F1c2UgYSBHUFUgc2NoZWR1bGVy IGhhcyBkZWZlcnJlZCBpdC4KPiAgCSAqLwo+IC0JaWYgKGk5MTUuZW5hYmxlX2V4ZWNsaXN0cykK PiAtCQlyZXQgPSBpbnRlbF9sb2dpY2FsX3JpbmdfcmVzZXJ2ZV9zcGFjZShyZXEpOwo+IC0JZWxz ZQo+IC0JCXJldCA9IGludGVsX3JpbmdfcmVzZXJ2ZV9zcGFjZShyZXEpOwo+ICsJaW50ZWxfcmlu Z19yZXNlcnZlZF9zcGFjZV9yZXNlcnZlKHJlcS0+cmluZ2J1ZiwKPiArCQkJCQkgIE1JTl9TUEFD RV9GT1JfQUREX1JFUVVFU1QpOwo+ICsJcmV0ID0gaW50ZWxfcmluZ19iZWdpbihyZXEsIDApOwo+ ICAJaWYgKHJldCkgewo+ICAJCS8qCj4gIAkJICogQXQgdGhpcyBwb2ludCwgdGhlIHJlcXVlc3Qg aXMgZnVsbHkgYWxsb2NhdGVkIGV2ZW4gaWYgbm90Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMK PiBpbmRleCAwMmY3OThlNGM3MjYuLjI0NTg4MDRjNTIxZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2xyYy5jCj4gQEAgLTY2NiwyMSArNjY2LDYgQEAgaW50ZWxfbG9naWNhbF9yaW5nX2FkdmFu Y2VfYW5kX3N1Ym1pdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3QpCj4gIAll eGVjbGlzdHNfY29udGV4dF9xdWV1ZShyZXF1ZXN0KTsKPiAgfQo+ICAKPiAtaW50IGludGVsX2xv Z2ljYWxfcmluZ19yZXNlcnZlX3NwYWNlKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVx dWVzdCkKPiAtewo+IC0JLyoKPiAtCSAqIFRoZSBmaXJzdCBjYWxsIG1lcmVseSBub3RlcyB0aGUg cmVzZXJ2ZSByZXF1ZXN0IGFuZCBpcyBjb21tb24gZm9yCj4gLQkgKiBhbGwgYmFjayBlbmRzLiBU aGUgc3Vic2VxdWVudCBsb2NhbGlzZWQgX2JlZ2luKCkgY2FsbCBhY3R1YWxseQo+IC0JICogZW5z dXJlcyB0aGF0IHRoZSByZXNlcnZhdGlvbiBpcyBhdmFpbGFibGUuIFdpdGhvdXQgdGhlIGJlZ2lu LCBpZgo+IC0JICogdGhlIHJlcXVlc3QgY3JlYXRvciBpbW1lZGlhdGVseSBzdWJtaXR0ZWQgdGhl IHJlcXVlc3Qgd2l0aG91dAo+IC0JICogYWRkaW5nIGFueSBjb21tYW5kcyB0byBpdCB0aGVuIHRo ZXJlIG1pZ2h0IG5vdCBhY3R1YWxseSBiZQo+IC0JICogc3VmZmljaWVudCByb29tIGZvciB0aGUg c3VibWlzc2lvbiBjb21tYW5kcy4KPiAtCSAqLwo+IC0JaW50ZWxfcmluZ19yZXNlcnZlZF9zcGFj ZV9yZXNlcnZlKHJlcXVlc3QtPnJpbmdidWYsIE1JTl9TUEFDRV9GT1JfQUREX1JFUVVFU1QpOwo+ IC0KPiAtCXJldHVybiBpbnRlbF9yaW5nX2JlZ2luKHJlcXVlc3QsIDApOwo+IC19Cj4gLQo+ICAv KioKPiAgICogZXhlY2xpc3RzX3N1Ym1pc3Npb24oKSAtIHN1Ym1pdCBhIGJhdGNoYnVmZmVyIGZv ciBleGVjdXRpb24sIEV4ZWNsaXN0cyBzdHlsZQo+ICAgKiBAZGV2OiBEUk0gZGV2aWNlLgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuaCBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2xyYy5oCj4gaW5kZXggNTQwMmVjYTc4YTA3Li45OTgxZTk4OWZjYWYg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmgKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuaAo+IEBAIC0zOCw3ICszOCw2IEBACj4gIAo+ ICAvKiBMb2dpY2FsIFJpbmdzICovCj4gIGludCBpbnRlbF9sb2dpY2FsX3JpbmdfYWxsb2NfcmVx dWVzdF9leHRyYXMoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0KTsKPiAtaW50 IGludGVsX2xvZ2ljYWxfcmluZ19yZXNlcnZlX3NwYWNlKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVx dWVzdCAqcmVxdWVzdCk7Cj4gIHZvaWQgaW50ZWxfbG9naWNhbF9yaW5nX3N0b3Aoc3RydWN0IGlu dGVsX2VuZ2luZV9jcyAqcmluZyk7Cj4gIHZvaWQgaW50ZWxfbG9naWNhbF9yaW5nX2NsZWFudXAo c3RydWN0IGludGVsX2VuZ2luZV9jcyAqcmluZyk7Cj4gIGludCBpbnRlbF9sb2dpY2FsX3Jpbmdz X2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3JpbmdidWZmZXIuYwo+IGluZGV4IGZiZWU3OTBkZGFmMC4uOTgyMWMyYTgwNzRhIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuYwo+IEBAIC0yMTY4LDIxICsyMTY4 LDYgQEAgaW50IGludGVsX3JpbmdfYWxsb2NfcmVxdWVzdF9leHRyYXMoc3RydWN0IGRybV9pOTE1 X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0KQo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gLWludCBpbnRl bF9yaW5nX3Jlc2VydmVfc3BhY2Uoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0 KQo+IC17Cj4gLQkvKgo+IC0JICogVGhlIGZpcnN0IGNhbGwgbWVyZWx5IG5vdGVzIHRoZSByZXNl cnZlIHJlcXVlc3QgYW5kIGlzIGNvbW1vbiBmb3IKPiAtCSAqIGFsbCBiYWNrIGVuZHMuIFRoZSBz dWJzZXF1ZW50IGxvY2FsaXNlZCBfYmVnaW4oKSBjYWxsIGFjdHVhbGx5Cj4gLQkgKiBlbnN1cmVz IHRoYXQgdGhlIHJlc2VydmF0aW9uIGlzIGF2YWlsYWJsZS4gV2l0aG91dCB0aGUgYmVnaW4sIGlm Cj4gLQkgKiB0aGUgcmVxdWVzdCBjcmVhdG9yIGltbWVkaWF0ZWx5IHN1Ym1pdHRlZCB0aGUgcmVx dWVzdCB3aXRob3V0Cj4gLQkgKiBhZGRpbmcgYW55IGNvbW1hbmRzIHRvIGl0IHRoZW4gdGhlcmUg bWlnaHQgbm90IGFjdHVhbGx5IGJlCj4gLQkgKiBzdWZmaWNpZW50IHJvb20gZm9yIHRoZSBzdWJt aXNzaW9uIGNvbW1hbmRzLgo+IC0JICovCj4gLQlpbnRlbF9yaW5nX3Jlc2VydmVkX3NwYWNlX3Jl c2VydmUocmVxdWVzdC0+cmluZ2J1ZiwgTUlOX1NQQUNFX0ZPUl9BRERfUkVRVUVTVCk7Cj4gLQo+ IC0JcmV0dXJuIGludGVsX3JpbmdfYmVnaW4ocmVxdWVzdCwgMCk7Cj4gLX0KPiAtCj4gIHZvaWQg aW50ZWxfcmluZ19yZXNlcnZlZF9zcGFjZV9yZXNlcnZlKHN0cnVjdCBpbnRlbF9yaW5nYnVmZmVy ICpyaW5nYnVmLCBpbnQgc2l6ZSkKPiAgewo+ICAJV0FSTl9PTihyaW5nYnVmLT5yZXNlcnZlZF9z aXplKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZl ci5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gaW5kZXggMjEy YjQwMjgxOGY5Li4zNjhkOWIwNDU0ZWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cmluZ2J1ZmZlci5oCj4gQEAgLTQ4Nyw3ICs0ODcsNCBAQCB2b2lkIGludGVsX3JpbmdfcmVzZXJ2 ZWRfc3BhY2VfdXNlKHN0cnVjdCBpbnRlbF9yaW5nYnVmZmVyICpyaW5nYnVmKTsKPiAgLyogRmlu aXNoIHdpdGggdGhlIHJlc2VydmVkIHNwYWNlIC0gZm9yIHVzZSBieSBpOTE1X2FkZF9yZXF1ZXN0 KCkgb25seS4gKi8KPiAgdm9pZCBpbnRlbF9yaW5nX3Jlc2VydmVkX3NwYWNlX2VuZChzdHJ1Y3Qg aW50ZWxfcmluZ2J1ZmZlciAqcmluZ2J1Zik7Cj4gIAo+IC0vKiBMZWdhY3kgcmluZ2J1ZmZlciBz cGVjaWZpYyBwb3J0aW9uIG9mIHJlc2VydmF0aW9uIGNvZGU6ICovCj4gLWludCBpbnRlbF9yaW5n X3Jlc2VydmVfc3BhY2Uoc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0KTsKPiAt Cj4gICNlbmRpZiAvKiBfSU5URUxfUklOR0JVRkZFUl9IXyAqLwo+IC0tIAo+IDIuNi4yCj4gCj4g X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1n ZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApE YW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8v YmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=