From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/3] drm/i915: Suppress spurious CPU FIFO underruns on ILK-IVB Date: Tue, 24 Nov 2015 16:52:13 +0200 Message-ID: <20151124145213.GI4437@intel.com> References: <1448050160-14124-1-git-send-email-ville.syrjala@linux.intel.com> <20151124141624.GG17050@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 380F46E954 for ; Tue, 24 Nov 2015 06:52:17 -0800 (PST) Content-Disposition: inline In-Reply-To: <20151124141624.GG17050@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBOb3YgMjQsIDIwMTUgYXQgMDM6MTY6MjRQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBGcmksIE5vdiAyMCwgMjAxNSBhdCAxMDowOToxOFBNICswMjAwLCB2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAKPiA+IFdlIHN0aWxsIGdldCBzcHVy aW91cyBwaXBlIHVuZGVycnVucyBvbiBJTEsvU05CL0lWQiB1bmRlciB0d28KPiA+IGNpcmN1bXN0 YW5jZXMgd2hlbiBkZWFsaW5nIHdpdGggUENIIHBvcnRzOgo+ID4gKiBXaGVuIHRoZSBwaXBlIGhh cyBiZWVuIGRpc2FibGVkLCBidXQgRkRJIFJYL1RYIGlzIHN0aWxsIGVuYWJsZWQKPiA+ICogRHVy aW5nIEZESSBsaW5rIHRyYWluaW5nCj4gPiAKPiA+IEJvdGggY2FzZXMgc2VlbSB0byBoYXBwZW4g YXQgbGVhc3Qgd2hlbiB3ZSBkbyBWR0ErSERNSSBjbG9uaW5nCj4gPiBmcm9tIHRoZSBzYW1lIHBp cGUuIEkgZG9uJ3QgdGhpbmsgSSd2ZSBzZWVuIHRoZW0gd2hlbiBub3QgY2xvbmluZywKPiA+IGJ1 dCBjYW4ndCBiZSAxMDAlIHN1cmUuCj4gPiAKPiA+IERpc2FibGUgdW5kZXJydW4gcmVwb3J0aW5n IGFyb3VuZCB0aG9zZSBwbGFjZXMgdG8gZWxpbWluYXRlIHRoZQo+ID4gZG1lc2cgZXJyb3JzLgo+ ID4gCj4gPiBUZXN0Y2FzZTogaWd0L2ttc19zZXRtb2RlL2Jhc2ljLWNsb25lLXNpbmdsZS1jcnRj Cj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXgu aW50ZWwuY29tPgo+IAo+IGhzdyBzZWVtcyB0byBoYXZlIGEgc2ltaWxhciBwcm9ibGVtIHdoZW4g Ym90aCB2Z2EgYW5kIGhkbWkgYXJlIHVzZWQsIGV2ZW4KPiB3aGVuIG5vdCBjbG9uZWQuIEJhZCB0 aGluZyBpcyB0aGF0IHNvbWVob3cgdGhlIHVuZGVycnVuIHJlcG9ydGluZyBnZXRzCj4gaW50byBh IG5vbi1yZWNvdmVyYWJsZSBzdGF0ZSBhbmQgc3R1Y2sgdGhlcmUsIHNvIHRoYXQgbm8gdW5kZXJy dW4gYW5kIGFsc28KPiBub3RoaW5nIGVsc2UgKHNwZWNpZmljYWxseSBjcmMgaXJxcywgdGhhdCdz IHdoeSBiYXQgbm90aWNlcykgd29yayBhbnkKPiBtb3JlLgo+IAo+IE1pZ2h0IGJlIHdvcnRoIGEg c2hvdCB0byB0cnkgdGhlIHNhbWUgdHJpY2sgdGhlcmUuIE9mIGNvdXJzZSB3ZSBzdGlsbCBuZWVk Cj4gdG8gZmlndXJlIG91dCB3aHkgaXQgY2FuJ3QgcmVjb3ZlciBmcm9tIHRoaXMsIHRvby4KCkkg ZG9uJ3QgaGF2ZSBhIEhTVy9CRFcgd2l0aCBWR0Egb24gbWUuIEkgc3VwcG9zZSBJIG1pZ2h0IG5l ZWQgdG8gZ28KZmluZCBvbmUgYW5kIHNlZSB3aGF0J3Mgd2hhdC4KClNlcmllcyBwdXNoZWQgdG8g ZGlucS4gVGhhbmtzIGZvciB0aGUgYWNrcyBhbmQgcmV2aWV3cy4KCj4gCj4gQW55d2F5IGp1c3Qg YW4gYXNpZGUsIGFjayBvbiB0aGUgZW50aXJlIHNlcmllcy4KPiAtRGFuaWVsCj4gCj4gPiAtLS0K PiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAyMCArKysrKysrKysr KysrKysrKysrLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9uKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IGluZGV4 IDY4ZmI0NDlkZWQ3Ny4uOGE4MTA0Yjc5NDdkIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPiA+IEBAIC00MTM3LDYgKzQxMzcsMTIgQEAgc3RhdGljIHZvaWQgaXJv bmxha2VfcGNoX2VuYWJsZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gPiAgCUk5MTVfV1JJVEUo RkRJX1JYX1RVU0laRTEocGlwZSksCj4gPiAgCQkgICBJOTE1X1JFQUQoUElQRV9EQVRBX00xKHBp cGUpKSAmIFRVX1NJWkVfTUFTSyk7Cj4gPiAgCj4gPiArCS8qCj4gPiArCSAqIFNvbWV0aW1lcyBz cHVyaW91cyBDUFUgcGlwZSB1bmRlcnJ1bnMgaGFwcGVuIGR1cmluZyBGREkKPiA+ICsJICogdHJh aW5pbmcsIGF0IGxlYXN0IHdpdGggVkdBK0hETUkgY2xvbmluZy4gU3VwcHJlc3MgdGhlbS4KPiA+ ICsJICovCj4gPiArCWludGVsX3NldF9jcHVfZmlmb191bmRlcnJ1bl9yZXBvcnRpbmcoZGV2X3By aXYsIHBpcGUsIGZhbHNlKTsKPiA+ICsKPiA+ICAJLyogRm9yIFBDSCBvdXRwdXQsIHRyYWluaW5n IEZESSBsaW5rICovCj4gPiAgCWRldl9wcml2LT5kaXNwbGF5LmZkaV9saW5rX3RyYWluKGNydGMp Owo+ID4gIAo+ID4gQEAgLTQxNzAsNiArNDE3Niw4IEBAIHN0YXRpYyB2b2lkIGlyb25sYWtlX3Bj aF9lbmFibGUoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ID4gIAo+ID4gIAlpbnRlbF9mZGlfbm9y bWFsX3RyYWluKGNydGMpOwo+ID4gIAo+ID4gKwlpbnRlbF9zZXRfY3B1X2ZpZm9fdW5kZXJydW5f cmVwb3J0aW5nKGRldl9wcml2LCBwaXBlLCB0cnVlKTsKPiA+ICsKPiA+ICAJLyogRm9yIFBDSCBE UCwgZW5hYmxlIFRSQU5TX0RQX0NUTCAqLwo+ID4gIAlpZiAoSEFTX1BDSF9DUFQoZGV2KSAmJiBp bnRlbF9jcnRjLT5jb25maWctPmhhc19kcF9lbmNvZGVyKSB7Cj4gPiAgCQljb25zdCBzdHJ1Y3Qg ZHJtX2Rpc3BsYXlfbW9kZSAqYWRqdXN0ZWRfbW9kZSA9Cj4gPiBAQCAtNTA2MiwxMiArNTA3MCwy MiBAQCBzdGF0aWMgdm9pZCBpcm9ubGFrZV9jcnRjX2Rpc2FibGUoc3RydWN0IGRybV9jcnRjICpj cnRjKQo+ID4gIAlkcm1fY3J0Y192Ymxhbmtfb2ZmKGNydGMpOwo+ID4gIAlhc3NlcnRfdmJsYW5r X2Rpc2FibGVkKGNydGMpOwo+ID4gIAo+ID4gKwkvKgo+ID4gKwkgKiBTb21ldGltZXMgc3B1cmlv dXMgQ1BVIHBpcGUgdW5kZXJydW5zIGhhcHBlbiB3aGVuIHRoZQo+ID4gKwkgKiBwaXBlIGlzIGFs cmVhZHkgZGlzYWJsZWQsIGJ1dCBGREkgUlgvVFggaXMgc3RpbGwgZW5hYmxlZC4KPiA+ICsJICog SGFwcGVucyBhdCBsZWFzdCB3aXRoIFZHQStIRE1JIGNsb25pbmcuIFN1cHByZXNzIHRoZW0uCj4g PiArCSAqLwo+ID4gKwlpZiAoaW50ZWxfY3J0Yy0+Y29uZmlnLT5oYXNfcGNoX2VuY29kZXIpCj4g PiArCQlpbnRlbF9zZXRfY3B1X2ZpZm9fdW5kZXJydW5fcmVwb3J0aW5nKGRldl9wcml2LCBwaXBl LCBmYWxzZSk7Cj4gPiArCj4gPiAgCWludGVsX2Rpc2FibGVfcGlwZShpbnRlbF9jcnRjKTsKPiA+ ICAKPiA+ICAJaXJvbmxha2VfcGZpdF9kaXNhYmxlKGludGVsX2NydGMsIGZhbHNlKTsKPiA+ICAK PiA+IC0JaWYgKGludGVsX2NydGMtPmNvbmZpZy0+aGFzX3BjaF9lbmNvZGVyKQo+ID4gKwlpZiAo aW50ZWxfY3J0Yy0+Y29uZmlnLT5oYXNfcGNoX2VuY29kZXIpIHsKPiA+ICAJCWlyb25sYWtlX2Zk aV9kaXNhYmxlKGNydGMpOwo+ID4gKwkJaW50ZWxfc2V0X2NwdV9maWZvX3VuZGVycnVuX3JlcG9y dGluZyhkZXZfcHJpdiwgcGlwZSwgdHJ1ZSk7Cj4gPiArCX0KPiA+ICAKPiA+ICAJZm9yX2VhY2hf ZW5jb2Rlcl9vbl9jcnRjKGRldiwgY3J0YywgZW5jb2RlcikKPiA+ICAJCWlmIChlbmNvZGVyLT5w b3N0X2Rpc2FibGUpCj4gPiAtLSAKPiA+IDIuNC4xMAo+ID4gCj4gPiBfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IAo+IC0tIAo+IERhbmll bCBWZXR0ZXIKPiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiBodHRwOi8v YmxvZy5mZndsbC5jaAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK