From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't register CRT connector when it's fused off
Date: Tue, 24 Nov 2015 16:59:16 +0200 [thread overview]
Message-ID: <20151124145916.GJ4437@intel.com> (raw)
In-Reply-To: <20151123150729.GA4437@intel.com>
On Mon, Nov 23, 2015 at 05:07:29PM +0200, Ville Syrjälä wrote:
> On Sat, Nov 21, 2015 at 10:44:12AM +0000, Chris Wilson wrote:
> > On Fri, Nov 20, 2015 at 10:35:41PM +0200, ville.syrjala@linux.intel.com wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > On some machines the CRT connector may be fused off. The weird thing
> > > about this setup is that the ADPA register works otherwise normally,
> > > except the enable bit is hardwired to 0. No one knows of any fuse
> > > register that would tell us if this is the case, so the only thing we
> > > can do (apart from a blacklist) is to try and set the enable bit and see
> > > if it sticks. If not, we don't register the connector at all. Obviously
> > > if the bit is already set when loading the driver we can just assume it
> > > works.
> > >
> > > I've smoke tested this approach on several machines (GMCH and PCH),
> > > some with actual CRT connectors, some with shadow connectors, and
> > > obviously the machine (IVB) with the fused off connector. So far
> > > I've not seen any ill effects from this probe.
> > >
> > > The main benefit is that we can actually run igt on machines with
> > > fused off connectors, without totally upsetting the state checker.
> > >
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > If we can't enable the VGA port, there's not much we can do with it.
> >
> > Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > I'm just a bit hesistant, in case there are machine out there that
> > simply do not report the hw state back (doubtful) or there are people
> > who make use of the false VGA as a fake output (like me, or perhaps
> > kvm-over-ip). I'll survive, I just use a fake HDMI output if there is no
> > VGA.
>
> Based on my experience most machines that lack the physical connector
> still have a fully working ADPA register. I have two such machines
> myself. There's just this one machine at our office where it's
> totally fused off, and running igt on it is no fun unless we get rid
> of the connector.
Patch merged, thanks for the ack.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-11-24 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 20:35 [PATCH] drm/i915: Don't register CRT connector when it's fused off ville.syrjala
2015-11-21 10:44 ` Chris Wilson
2015-11-23 15:07 ` Ville Syrjälä
2015-11-24 14:59 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124145916.GJ4437@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox