From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/3] drm/i915: Introduce bdw_{update, enable, disable}_pipe_irq() Date: Wed, 25 Nov 2015 15:16:50 +0200 Message-ID: <20151125131650.GO4437@intel.com> References: <1448294777-13722-1-git-send-email-ville.syrjala@linux.intel.com> <1448294777-13722-4-git-send-email-ville.syrjala@linux.intel.com> <20151124175209.GA17050@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 934E56EBB3 for ; Wed, 25 Nov 2015 05:17:18 -0800 (PST) Content-Disposition: inline In-Reply-To: <20151124175209.GA17050@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBOb3YgMjQsIDIwMTUgYXQgMDY6NTI6MDlQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBNb24sIE5vdiAyMywgMjAxNSBhdCAwNjowNjoxN1BNICswMjAwLCB2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAKPiA+IFB1bGwgdGhlIEJEVysgREUg cGlwZSBpbnRlcnJ1cHQgbWFzayBmcm9iYmluZyBpbnRvIGEgY2VudHJhbCBwbGFjZSwKPiA+IGxp a2Ugd2UgaGF2ZSBmb3Igb3RoZXIgcGxhdGZvcm1zLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBW aWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gLS0tCj4g PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgICAgICAgIHwgMTQgKysrKysr KysrKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgICAgICAgICAgICB8IDQx ICsrKysrKysrKysrKysrKysrKysrKysrKystLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2ZpZm9fdW5kZXJydW4uYyB8ICA4ICsrLS0tLQo+ID4gIDMgZmlsZXMgY2hhbmdlZCwg NTEgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuaAo+ID4gaW5kZXggYjlmODZhNzNjNTQzLi5jMzMzMGZmNTAxNmQgMTAwNjQ0Cj4gPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gPiBAQCAtMjc2Miw2ICsyNzYyLDIwIEBAIGlsa19kaXNh YmxlX2Rpc3BsYXlfaXJxKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdWludDMy X3QgYml0cykKPiA+ICB7Cj4gPiAgCWlsa191cGRhdGVfZGlzcGxheV9pcnEoZGV2X3ByaXYsIGJp dHMsIDApOwo+ID4gIH0KPiA+ICt2b2lkIGJkd191cGRhdGVfcGlwZV9pcnEoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gKwkJCSBlbnVtIHBpcGUgcGlwZSwKPiA+ICsJCQkg dWludDMyX3QgaW50ZXJydXB0X21hc2ssCj4gPiArCQkJIHVpbnQzMl90IGVuYWJsZWRfaXJxX21h c2spOwo+ID4gK3N0YXRpYyBpbmxpbmUgdm9pZCBiZHdfZW5hYmxlX3BpcGVfaXJxKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICsJCQkJICAgICAgIGVudW0gcGlwZSBwaXBl LCB1aW50MzJfdCBiaXRzKQo+ID4gK3sKPiA+ICsJYmR3X3VwZGF0ZV9waXBlX2lycShkZXZfcHJp diwgcGlwZSwgYml0cywgYml0cyk7Cj4gPiArfQo+ID4gK3N0YXRpYyBpbmxpbmUgdm9pZCBiZHdf ZGlzYWJsZV9waXBlX2lycShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAr CQkJCQllbnVtIHBpcGUgcGlwZSwgdWludDMyX3QgYml0cykKPiA+ICt7Cj4gPiArCWJkd191cGRh dGVfcGlwZV9pcnEoZGV2X3ByaXYsIHBpcGUsIGJpdHMsIDApOwo+ID4gK30KPiA+ICB2b2lkIGli eF9kaXNwbGF5X2ludGVycnVwdF91cGRhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LAo+ID4gIAkJCQkgIHVpbnQzMl90IGludGVycnVwdF9tYXNrLAo+ID4gIAkJCQkgIHVpbnQz Ml90IGVuYWJsZWRfaXJxX21hc2spOwo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gPiBpbmRl eCA1YWVhNTU3ZjM3NzYuLjkyMzg5YTliYjMwMSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfaXJxLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf aXJxLmMKPiA+IEBAIC00MzgsNiArNDM4LDM4IEBAIHN0YXRpYyB2b2lkIGJkd191cGRhdGVfcG9y dF9pcnEoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIH0KPiA+ICAKPiA+ ICAvKioKPiA+ICsgICogYmR3X3VwZGF0ZV9waXBlX2lycSAtIHVwZGF0ZSBERSBwaXBlIGludGVy cnVwdAo+ID4gKyAgKiBAZGV2X3ByaXY6IGRyaXZlciBwcml2YXRlCj4gPiArICAqIEBwaXBlOiBw aXBlIHdob3NlIGludGVycnVwdCB0byB1cGRhdGUKPiA+ICsgICogQGludGVycnVwdF9tYXNrOiBt YXNrIG9mIGludGVycnVwdCBiaXRzIHRvIHVwZGF0ZQo+ID4gKyAgKiBAZW5hYmxlZF9pcnFfbWFz azogbWFzayBvZiBpbnRlcnJ1cHQgYml0cyB0byBlbmFibGUKPiA+ICsgICovCj4gCj4ga2VybmVs ZG9jIGlzIGFsaWduZWQgbGlrZQo+IAo+IC8qKgo+ICAqIAo+ICAqLwoKSG1tLiBDb3B5IHBhc3Rl ZCBmcm9tIGJkd191cGRhdGVfcG9ydF9pcnEoKSBzbyBJIGd1ZXNzIEkgZ2V0IHRvIGZpeCB0aGF0 Cm9uZSBhcyB3ZWxsLiBJJ2xsIHNlbmQgYSBzZXBhcmF0ZSBwYXRjaCBmb3IgaXQuCgo+IAo+IFdp dGggdGhhdCBPQ0QgaW4gdGhlIE9DRCBhZGRyZXNzZWQ6Cj4gCj4gUmV2aWV3ZWQtYnk6IERhbmll bCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gCj4gPiArdm9pZCBiZHdfdXBkYXRl X3BpcGVfaXJxKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICsJCQkgZW51 bSBwaXBlIHBpcGUsCj4gPiArCQkJIHVpbnQzMl90IGludGVycnVwdF9tYXNrLAo+ID4gKwkJCSB1 aW50MzJfdCBlbmFibGVkX2lycV9tYXNrKQo+ID4gK3sKPiA+ICsJdWludDMyX3QgbmV3X3ZhbDsK PiA+ICsKPiA+ICsJYXNzZXJ0X3NwaW5fbG9ja2VkKCZkZXZfcHJpdi0+aXJxX2xvY2spOwo+ID4g Kwo+ID4gKwlXQVJOX09OKGVuYWJsZWRfaXJxX21hc2sgJiB+aW50ZXJydXB0X21hc2spOwo+ID4g Kwo+ID4gKwlpZiAoV0FSTl9PTighaW50ZWxfaXJxc19lbmFibGVkKGRldl9wcml2KSkpCj4gPiAr CQlyZXR1cm47Cj4gPiArCj4gPiArCW5ld192YWwgPSBkZXZfcHJpdi0+ZGVfaXJxX21hc2tbcGlw ZV07Cj4gPiArCW5ld192YWwgJj0gfmludGVycnVwdF9tYXNrOwo+ID4gKwluZXdfdmFsIHw9ICh+ ZW5hYmxlZF9pcnFfbWFzayAmIGludGVycnVwdF9tYXNrKTsKPiA+ICsKPiA+ICsJaWYgKG5ld192 YWwgIT0gZGV2X3ByaXYtPmRlX2lycV9tYXNrW3BpcGVdKSB7Cj4gPiArCQlkZXZfcHJpdi0+ZGVf aXJxX21hc2tbcGlwZV0gPSBuZXdfdmFsOwo+ID4gKwkJSTkxNV9XUklURShHRU44X0RFX1BJUEVf SU1SKHBpcGUpLCBkZXZfcHJpdi0+ZGVfaXJxX21hc2tbcGlwZV0pOwo+ID4gKwkJUE9TVElOR19S RUFEKEdFTjhfREVfUElQRV9JTVIocGlwZSkpOwo+ID4gKwl9Cj4gPiArfQo+ID4gKwo+ID4gKy8q Kgo+ID4gICAqIGlieF9kaXNwbGF5X2ludGVycnVwdF91cGRhdGUgLSB1cGRhdGUgU0RFSU1SCj4g PiAgICogQGRldl9wcml2OiBkcml2ZXIgcHJpdmF0ZQo+ID4gICAqIEBpbnRlcnJ1cHRfbWFzazog bWFzayBvZiBpbnRlcnJ1cHQgYml0cyB0byB1cGRhdGUKPiA+IEBAIC0yNjU4LDEwICsyNjkwLDkg QEAgc3RhdGljIGludCBnZW44X2VuYWJsZV92Ymxhbmsoc3RydWN0IGRybV9kZXZpY2UgKmRldiwg dW5zaWduZWQgaW50IHBpcGUpCj4gPiAgCXVuc2lnbmVkIGxvbmcgaXJxZmxhZ3M7Cj4gPiAgCj4g PiAgCXNwaW5fbG9ja19pcnFzYXZlKCZkZXZfcHJpdi0+aXJxX2xvY2ssIGlycWZsYWdzKTsKPiA+ IC0JZGV2X3ByaXYtPmRlX2lycV9tYXNrW3BpcGVdICY9IH5HRU44X1BJUEVfVkJMQU5LOwo+ID4g LQlJOTE1X1dSSVRFKEdFTjhfREVfUElQRV9JTVIocGlwZSksIGRldl9wcml2LT5kZV9pcnFfbWFz a1twaXBlXSk7Cj4gPiAtCVBPU1RJTkdfUkVBRChHRU44X0RFX1BJUEVfSU1SKHBpcGUpKTsKPiA+ ICsJYmR3X2VuYWJsZV9waXBlX2lycShkZXZfcHJpdiwgcGlwZSwgR0VOOF9QSVBFX1ZCTEFOSyk7 Cj4gPiAgCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldl9wcml2LT5pcnFfbG9jaywgaXJxZmxh Z3MpOwo+ID4gKwo+ID4gIAlyZXR1cm4gMDsKPiA+ICB9Cj4gPiAgCj4gPiBAQCAtMjcwOSw5ICsy NzQwLDcgQEAgc3RhdGljIHZvaWQgZ2VuOF9kaXNhYmxlX3ZibGFuayhzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LCB1bnNpZ25lZCBpbnQgcGlwZSkKPiA+ICAJdW5zaWduZWQgbG9uZyBpcnFmbGFnczsK PiA+ICAKPiA+ICAJc3Bpbl9sb2NrX2lycXNhdmUoJmRldl9wcml2LT5pcnFfbG9jaywgaXJxZmxh Z3MpOwo+ID4gLQlkZXZfcHJpdi0+ZGVfaXJxX21hc2tbcGlwZV0gfD0gR0VOOF9QSVBFX1ZCTEFO SzsKPiA+IC0JSTkxNV9XUklURShHRU44X0RFX1BJUEVfSU1SKHBpcGUpLCBkZXZfcHJpdi0+ZGVf aXJxX21hc2tbcGlwZV0pOwo+ID4gLQlQT1NUSU5HX1JFQUQoR0VOOF9ERV9QSVBFX0lNUihwaXBl KSk7Cj4gPiArCWJkd19kaXNhYmxlX3BpcGVfaXJxKGRldl9wcml2LCBwaXBlLCBHRU44X1BJUEVf VkJMQU5LKTsKPiA+ICAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZGV2X3ByaXYtPmlycV9sb2Nr LCBpcnFmbGFncyk7Cj4gPiAgfQo+ID4gIAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2ZpZm9fdW5kZXJydW4uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2ZpZm9fdW5kZXJydW4uYwo+ID4gaW5kZXggNDhiZDA3OWJkYjA2Li5iZGE1MjY2NjBlMjAgMTAw NjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9maWZvX3VuZGVycnVuLmMK PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZpZm9fdW5kZXJydW4uYwo+ID4g QEAgLTE3OCwxNCArMTc4LDEwIEBAIHN0YXRpYyB2b2lkIGJyb2Fkd2VsbF9zZXRfZmlmb191bmRl cnJ1bl9yZXBvcnRpbmcoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ICB7Cj4gPiAgCXN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gPiAgCj4g PiAtCWFzc2VydF9zcGluX2xvY2tlZCgmZGV2X3ByaXYtPmlycV9sb2NrKTsKPiA+IC0KPiA+ICAJ aWYgKGVuYWJsZSkKPiA+IC0JCWRldl9wcml2LT5kZV9pcnFfbWFza1twaXBlXSAmPSB+R0VOOF9Q SVBFX0ZJRk9fVU5ERVJSVU47Cj4gPiArCQliZHdfZW5hYmxlX3BpcGVfaXJxKGRldl9wcml2LCBw aXBlLCBHRU44X1BJUEVfRklGT19VTkRFUlJVTik7Cj4gPiAgCWVsc2UKPiA+IC0JCWRldl9wcml2 LT5kZV9pcnFfbWFza1twaXBlXSB8PSBHRU44X1BJUEVfRklGT19VTkRFUlJVTjsKPiA+IC0JSTkx NV9XUklURShHRU44X0RFX1BJUEVfSU1SKHBpcGUpLCBkZXZfcHJpdi0+ZGVfaXJxX21hc2tbcGlw ZV0pOwo+ID4gLQlQT1NUSU5HX1JFQUQoR0VOOF9ERV9QSVBFX0lNUihwaXBlKSk7Cj4gPiArCQli ZHdfZGlzYWJsZV9waXBlX2lycShkZXZfcHJpdiwgcGlwZSwgR0VOOF9QSVBFX0ZJRk9fVU5ERVJS VU4pOwo+ID4gIH0KPiA+ICAKPiA+ICBzdGF0aWMgdm9pZCBpYnhfc2V0X2ZpZm9fdW5kZXJydW5f cmVwb3J0aW5nKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gPiAtLSAKPiA+IDIuNC4xMAo+ID4g Cj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4g SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+ID4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo+IAo+IC0tIAo+IERhbmllbCBWZXR0ZXIKPiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwg Q29ycG9yYXRpb24KPiBodHRwOi8vYmxvZy5mZndsbC5jaAoKLS0gClZpbGxlIFN5cmrDpGzDpApJ bnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK