From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Fix possible null dereference in framebuffer_info debugfs function Date: Thu, 26 Nov 2015 15:38:33 +0100 Message-ID: <20151126143833.GQ17050@phenom.ffwll.local> References: <20151119113749.GG1043@nuc-i3427.alporthouse.com> <1448535750-3490-1-git-send-email-namrta.salonie@intel.com> <20151126124319.GI23362@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id 127B16E0C9 for ; Thu, 26 Nov 2015 06:38:37 -0800 (PST) Received: by wmww144 with SMTP id w144so23965054wmw.1 for ; Thu, 26 Nov 2015 06:38:35 -0800 (PST) Content-Disposition: inline In-Reply-To: <20151126124319.GI23362@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Namrta Salonie , intel-gfx@lists.freedesktop.org, Deepak S List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBOb3YgMjYsIDIwMTUgYXQgMTI6NDM6MTlQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIFRodSwgTm92IDI2LCAyMDE1IGF0IDA0OjMyOjMwUE0gKzA1MzAsIE5hbXJ0YSBT YWxvbmllIHdyb3RlOgo+ID4gRm91bmQgYnkgc3RhdGljIGNvZGUgYW5hbHlzaXMgdG9vbC4KPiA+ IAo+ID4gdjI6IEluc2VydGVkIGJsb2NrIGluc3RlYWQgb2YgZ290byAmIHJlbmFtZWQgdmFyaWFi bGVzIChDaHJpcykKPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogTmFtcnRhIFNhbG9uaWUgPG5hbXJ0 YS5zYWxvbmllQGludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IERlZXBhayBTIDxkZWVwYWsu c0BpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVn ZnMuYyB8ICAgMzIgKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0KPiA+ICAxIGZpbGUg Y2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gPiBpbmRleCBhM2IyMmJkLi43YzA2OGVhIDEwMDY0 NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiA+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gPiBAQCAtMTg2NSwzMSArMTg2 NSwyOSBAQCBzdGF0aWMgaW50IGk5MTVfZ2VtX2ZyYW1lYnVmZmVyX2luZm8oc3RydWN0IHNlcV9m aWxlICptLCB2b2lkICpkYXRhKQo+ID4gIHsKPiA+ICAJc3RydWN0IGRybV9pbmZvX25vZGUgKm5v ZGUgPSBtLT5wcml2YXRlOwo+ID4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gbm9kZS0+bWlu b3ItPmRldjsKPiA+IC0Jc3RydWN0IGludGVsX2ZiZGV2ICppZmJkZXYgPSBOVUxMOwo+ID4gLQlz dHJ1Y3QgaW50ZWxfZnJhbWVidWZmZXIgKmZiOwo+ID4gKwlzdHJ1Y3QgaW50ZWxfZnJhbWVidWZm ZXIgKmZiZGV2X2ZiID0gTlVMTDsKPiA+ICAJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZHJtX2Zi Owo+ID4gIAo+ID4gICNpZmRlZiBDT05GSUdfRFJNX0ZCREVWX0VNVUxBVElPTgo+ID4gLQlzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+ID4gIAo+ ID4gLQlpZmJkZXYgPSBkZXZfcHJpdi0+ZmJkZXY7Cj4gPiAtCWZiID0gdG9faW50ZWxfZnJhbWVi dWZmZXIoaWZiZGV2LT5oZWxwZXIuZmIpOwo+ID4gLQo+ID4gLQlzZXFfcHJpbnRmKG0sICJmYmNv biBzaXplOiAlZCB4ICVkLCBkZXB0aCAlZCwgJWQgYnBwLCBtb2RpZmllciAweCVsbHgsIHJlZmNv dW50ICVkLCBvYmogIiwKPiA+IC0JCSAgIGZiLT5iYXNlLndpZHRoLAo+ID4gLQkJICAgZmItPmJh c2UuaGVpZ2h0LAo+ID4gLQkJICAgZmItPmJhc2UuZGVwdGgsCj4gPiAtCQkgICBmYi0+YmFzZS5i aXRzX3Blcl9waXhlbCwKPiA+IC0JCSAgIGZiLT5iYXNlLm1vZGlmaWVyWzBdLAo+ID4gLQkJICAg YXRvbWljX3JlYWQoJmZiLT5iYXNlLnJlZmNvdW50LnJlZmNvdW50KSk7Cj4gPiAtCWRlc2NyaWJl X29iaihtLCBmYi0+b2JqKTsKPiA+IC0Jc2VxX3B1dGMobSwgJ1xuJyk7Cj4gPiArCWlmICh0b19p OTE1KGRldiktPmZiZGV2KSB7Cj4gPiArCQlmYmRldl9mYiA9IHRvX2ludGVsX2ZyYW1lYnVmZmVy KHRvX2k5MTUoZGV2KS0+ZmJkZXYtPmhlbHBlci5mYik7Cj4gPiArCQlzZXFfcHJpbnRmKG0sICJm YmNvbiBzaXplOiAlZCB4ICVkLCBkZXB0aCAlZCwgJWQgYnBwLCBtb2RpZmllciAweCVsbHgsIHJl ZmNvdW50ICVkLCBvYmogIiwKPiA+ICsJCQkJZmJkZXZfZmItPmJhc2Uud2lkdGgsCj4gPiArCQkJ CWZiZGV2X2ZiLT5iYXNlLmhlaWdodCwKPiA+ICsJCQkJZmJkZXZfZmItPmJhc2UuZGVwdGgsCj4g PiArCQkJCWZiZGV2X2ZiLT5iYXNlLmJpdHNfcGVyX3BpeGVsLAo+ID4gKwkJCQlmYmRldl9mYi0+ YmFzZS5tb2RpZmllclswXSwKPiA+ICsJCQkJYXRvbWljX3JlYWQoJmZiZGV2X2ZiLT5iYXNlLnJl ZmNvdW50LnJlZmNvdW50KSk7Cj4gCj4gVGhlc2Ugc2hvdWxkIGJlIGFsaWduZWQgdG8gdGhlIG9w ZW5pbmcgJygnCgpQYXRjaCBhbHNvIGRvZXNuJ3QgYXBwbHkgY2xlYW5seSBhbnkgbW9yZSBvbiB0 b3Agb2YgZHJtLWludGVsLW5pZ2h0bHkuIENhbgp5b3UgcGxlYXNlIHJlYmFzZSBhbmQgZml4IHVw IHRoZSBhbGlnbm1lbnQgcHJvYmxlbSBDaHJpcyBwb2ludGVkIG91dAphYm92ZT8KClRoYW5rcywg RGFuaWVsCgo+IAo+IFJldmlld2VkLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNv bi5jby51az4KPiAtQ2hyaXMKPiAKPiAtLSAKPiBDaHJpcyBXaWxzb24sIEludGVsIE9wZW4gU291 cmNlIFRlY2hub2xvZ3kgQ2VudHJlCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJ bnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=