From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Fix possible null dereference in
 framebuffer_info debugfs function
Date: Mon, 30 Nov 2015 09:14:02 +0100
Message-ID: <20151130081402.GH17050@phenom.ffwll.local>
References: <20151126124319.GI23362@nuc-i3427.alporthouse.com>
 <1448611991-18615-1-git-send-email-namrta.salonie@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 2FB5A6E2FA
 for <intel-gfx@lists.freedesktop.org>; Mon, 30 Nov 2015 00:14:06 -0800 (PST)
Received: by wmec201 with SMTP id c201so126688612wme.1
 for <intel-gfx@lists.freedesktop.org>; Mon, 30 Nov 2015 00:14:04 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1448611991-18615-1-git-send-email-namrta.salonie@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Namrta Salonie <namrta.salonie@intel.com>
Cc: Deepak S <deepak.s@intel.com>, intel-gfx@lists.freedesktop.org, akash.goel@intel.com
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBOb3YgMjcsIDIwMTUgYXQgMDE6NDM6MTFQTSArMDUzMCwgTmFtcnRhIFNhbG9uaWUg
d3JvdGU6Cj4gRm91bmQgYnkgc3RhdGljIGNvZGUgYW5hbHlzaXMgdG9vbC4KPiAKPiB2MjogSW5z
ZXJ0ZWQgYmxvY2sgaW5zdGVhZCBvZiBnb3RvICYgcmVuYW1lZCB2YXJpYWJsZXMgKENocmlzKQo+
IHYzOiBBbGlnbmVkIGNvZGUgYXMgcGVyIHRoZSBvcGVuaW5nIGJyYWNlIChDaHJpcykKPiAgICAg
UmViYXNlZCBvbiB0b3Agb2YgbmlnaHRseSAoRGFuaWVsKQo+IAo+IFNpZ25lZC1vZmYtYnk6IE5h
bXJ0YSBTYWxvbmllIDxuYW1ydGEuc2Fsb25pZUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTog
RGVlcGFrIFMgPGRlZXBhay5zQGludGVsLmNvbT4KClF1ZXVlZCBmb3IgLW5leHQsIHRoYW5rcyBm
b3IgdGhlIHBhdGNoLgotRGFuaWVsCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1
X2RlYnVnZnMuYyB8ICAgMzYgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0KPiAg
MSBmaWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQo+IAo+IGRp
ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyBiL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gaW5kZXggYTcyOGZmMS4uYmZkNTdmYiAxMDA2
NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+ICsrKyBiL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gQEAgLTE4NjksMzMgKzE4NjksMjkg
QEAgc3RhdGljIGludCBpOTE1X2dlbV9mcmFtZWJ1ZmZlcl9pbmZvKHN0cnVjdCBzZXFfZmlsZSAq
bSwgdm9pZCAqZGF0YSkKPiAgewo+ICAJc3RydWN0IGRybV9pbmZvX25vZGUgKm5vZGUgPSBtLT5w
cml2YXRlOwo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IG5vZGUtPm1pbm9yLT5kZXY7Cj4g
LQlzdHJ1Y3QgaW50ZWxfZmJkZXYgKmlmYmRldiA9IE5VTEw7Cj4gLQlzdHJ1Y3QgaW50ZWxfZnJh
bWVidWZmZXIgKmZiOwo+ICsJc3RydWN0IGludGVsX2ZyYW1lYnVmZmVyICpmYmRldl9mYiA9IE5V
TEw7Cj4gIAlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpkcm1fZmI7Cj4gIAo+ICAjaWZkZWYgQ09O
RklHX0RSTV9GQkRFVl9FTVVMQVRJT04KPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf
cHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gLQo+IC0JaWZiZGV2ID0gZGV2X3ByaXYtPmZiZGV2
Owo+IC0JaWYgKGlmYmRldikgewo+IC0JCWZiID0gdG9faW50ZWxfZnJhbWVidWZmZXIoaWZiZGV2
LT5oZWxwZXIuZmIpOwo+IC0KPiAtCQlzZXFfcHJpbnRmKG0sICJmYmNvbiBzaXplOiAlZCB4ICVk
LCBkZXB0aCAlZCwgJWQgYnBwLCBtb2RpZmllciAweCVsbHgsIHJlZmNvdW50ICVkLCBvYmogIiwK
PiAtCQkJICAgZmItPmJhc2Uud2lkdGgsCj4gLQkJCSAgIGZiLT5iYXNlLmhlaWdodCwKPiAtCQkJ
ICAgZmItPmJhc2UuZGVwdGgsCj4gLQkJCSAgIGZiLT5iYXNlLmJpdHNfcGVyX3BpeGVsLAo+IC0J
CQkgICBmYi0+YmFzZS5tb2RpZmllclswXSwKPiAtCQkJICAgYXRvbWljX3JlYWQoJmZiLT5iYXNl
LnJlZmNvdW50LnJlZmNvdW50KSk7Cj4gLQkJZGVzY3JpYmVfb2JqKG0sIGZiLT5vYmopOwo+IC0J
CXNlcV9wdXRjKG0sICdcbicpOwo+IC0JfQo+ICsgICAgICAgaWYgKHRvX2k5MTUoZGV2KS0+ZmJk
ZXYpIHsKPiArICAgICAgICAgICAgICAgZmJkZXZfZmIgPSB0b19pbnRlbF9mcmFtZWJ1ZmZlcih0
b19pOTE1KGRldiktPmZiZGV2LT5oZWxwZXIuZmIpOwo+ICsKPiArICAgICAgICAgICAgICAgc2Vx
X3ByaW50ZihtLCAiZmJjb24gc2l6ZTogJWQgeCAlZCwgZGVwdGggJWQsICVkIGJwcCwgbW9kaWZp
ZXIgMHglbGx4LCByZWZjb3VudCAlZCwgb2JqICIsCj4gKyAgICAgICAgICAgICAgICAgICAgICAg
ICBmYmRldl9mYi0+YmFzZS53aWR0aCwKPiArICAgICAgICAgICAgICAgICAgICAgICAgIGZiZGV2
X2ZiLT5iYXNlLmhlaWdodCwKPiArICAgICAgICAgICAgICAgICAgICAgICAgIGZiZGV2X2ZiLT5i
YXNlLmRlcHRoLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgZmJkZXZfZmItPmJhc2UuYml0
c19wZXJfcGl4ZWwsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICBmYmRldl9mYi0+YmFzZS5t
b2RpZmllclswXSwKPiArICAgICAgICAgICAgICAgICAgICAgICAgIGF0b21pY19yZWFkKCZmYmRl
dl9mYi0+YmFzZS5yZWZjb3VudC5yZWZjb3VudCkpOwo+ICsgICAgICAgICAgICAgICBkZXNjcmli
ZV9vYmoobSwgZmJkZXZfZmItPm9iaik7Cj4gKyAgICAgICAgICAgICAgIHNlcV9wdXRjKG0sICdc
bicpOwo+ICsgICAgICAgfQo+ICAjZW5kaWYKPiAgCj4gIAltdXRleF9sb2NrKCZkZXYtPm1vZGVf
Y29uZmlnLmZiX2xvY2spOwo+ICAJZHJtX2Zvcl9lYWNoX2ZiKGRybV9mYiwgZGV2KSB7Cj4gLQkJ
ZmIgPSB0b19pbnRlbF9mcmFtZWJ1ZmZlcihkcm1fZmIpOwo+IC0JCWlmIChpZmJkZXYgJiYgJmZi
LT5iYXNlID09IGlmYmRldi0+aGVscGVyLmZiKQo+ICsJCXN0cnVjdCBpbnRlbF9mcmFtZWJ1ZmZl
ciAqZmIgPSB0b19pbnRlbF9mcmFtZWJ1ZmZlcihkcm1fZmIpOwo+ICsJCWlmIChmYiA9PSBmYmRl
dl9mYikKPiAgCQkJY29udGludWU7Cj4gIAo+ICAJCXNlcV9wcmludGYobSwgInVzZXIgc2l6ZTog
JWQgeCAlZCwgZGVwdGggJWQsICVkIGJwcCwgbW9kaWZpZXIgMHglbGx4LCByZWZjb3VudCAlZCwg
b2JqICIsCj4gLS0gCj4gMS43LjkuNQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBs
aXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt
YW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVl
ciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ
bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v
cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK