From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/7] drm/i915: refactoring audio component functions Date: Mon, 30 Nov 2015 15:14:03 +0100 Message-ID: <20151130141403.GS17050@phenom.ffwll.local> References: <1448890671-2983-1-git-send-email-tiwai@suse.de> <1448890671-2983-4-git-send-email-tiwai@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA1066E5D0 for ; Mon, 30 Nov 2015 06:14:07 -0800 (PST) Received: by wmvv187 with SMTP id v187so158737717wmv.1 for ; Mon, 30 Nov 2015 06:14:06 -0800 (PST) Content-Disposition: inline In-Reply-To: <1448890671-2983-4-git-send-email-tiwai@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Takashi Iwai Cc: alsa-devel@alsa-project.org, Mengdong Lin , Vinod Koul , intel-gfx@lists.freedesktop.org, Daniel Vetter , David Henningsson List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBOb3YgMzAsIDIwMTUgYXQgMDI6Mzc6NDdQTSArMDEwMCwgVGFrYXNoaSBJd2FpIHdy b3RlOgo+IFdlIGhhdmUgYSBjb21tb24gbG9vcCBvZiBlbmNvZGVyIHRvIGxvb2sgZm9yIHRoZSBn aXZlbiBhdWRpbyBwb3J0IGluCj4gdHdvIGF1ZGlvIGNvbXBvbmVudCBmdW5jdGlvbnMuICBTcGxp dCBvdXQgYSBsb2NhbCBoZWxwZXIgZnVuY3Rpb24gdG8KPiBkbyBpdCBmb3IgdGhlIGNvZGUgc2lt cGxpZmljYXRpb24uCj4gCj4gU2lnbmVkLW9mZi1ieTogVGFrYXNoaSBJd2FpIDx0aXdhaUBzdXNl LmRlPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdWRpby5jIHwgNjEgKysr KysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMy IGluc2VydGlvbnMoKyksIDI5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9hdWRpby5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf YXVkaW8uYwo+IGluZGV4IDZiMzE4YThkNWRjOS4uMDI0ZTg4YWU2MzA1IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F1ZGlvLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9hdWRpby5jCj4gQEAgLTYzMCwxNyArNjMwLDMzIEBAIHN0YXRpYyBpbnQg aTkxNV9hdWRpb19jb21wb25lbnRfZ2V0X2NkY2xrX2ZyZXEoc3RydWN0IGRldmljZSAqZGV2KQo+ ICAJcmV0dXJuIHJldDsKPiAgfQo+ICAKPiArc3RhdGljIHN0cnVjdCBpbnRlbF9lbmNvZGVyICph dWRpb19wb3J0X3RvX2VuY29kZXIoc3RydWN0IGRybV9kZXZpY2UgKmRybV9kZXYsCj4gKwkJCQkJ CSAgIGludCBwb3J0KQo+ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqaW50ZWxfZW5jb2Rl cjsKPiArCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0Owo+ICsKPiAr CWZvcl9lYWNoX2ludGVsX2VuY29kZXIoZHJtX2RldiwgaW50ZWxfZW5jb2Rlcikgewo+ICsJCWlm IChpbnRlbF9lbmNvZGVyLT50eXBlICE9IElOVEVMX09VVFBVVF9IRE1JICYmCj4gKwkJICAgIGlu dGVsX2VuY29kZXItPnR5cGUgIT0gSU5URUxfT1VUUFVUX0RJU1BMQVlQT1JUKQo+ICsJCQljb250 aW51ZTsKPiArCQlpbnRlbF9kaWdfcG9ydCA9IGVuY190b19kaWdfcG9ydCgmaW50ZWxfZW5jb2Rl ci0+YmFzZSk7Cj4gKwkJaWYgKHBvcnQgPT0gaW50ZWxfZGlnX3BvcnQtPnBvcnQpCgpJZiB0aGlz IGlzIHN0YXRpYywgbWF5YmUganVzdCBtYWludGFpbiBhIHNuZF9waW5fdG9fcG9ydCBtYXBwaW5n IGluCmRldl9wcml2PyBUaGF0J3MgdGhlIGFwcHJvYWNoIHdlJ3JlIHVzdWFsbHkgdGFraW5nLCBh bmQgaXQgaGFzIHRoZSBiZW5lZml0Cm9mIG1ha2luZyBpdCBjbGVhcihlcikgdGhhdCB0aGUgYmlu ZGluZyBpcyBzdGF0aWMgLi4uIE9yIGlzIGl0IG5vdD8KCk1ha2VzIHNlbnNlIG90aGVyd2lzZS4K LURhbmllbAoKPiArCQkJcmV0dXJuIGludGVsX2VuY29kZXI7Cj4gKwl9Cj4gKwlyZXR1cm4gTlVM TDsKPiArfQo+ICsKPiAgc3RhdGljIGludCBpOTE1X2F1ZGlvX2NvbXBvbmVudF9zeW5jX2F1ZGlv X3JhdGUoc3RydWN0IGRldmljZSAqZGV2LAo+ICAJCQkJCQlpbnQgcG9ydCwgaW50IHJhdGUpCj4g IHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldl90b19pOTE1KGRl dik7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZHJtX2RldiA9IGRldl9wcml2LT5kZXY7Cj4gIAlz dHJ1Y3QgaW50ZWxfZW5jb2RlciAqaW50ZWxfZW5jb2RlcjsKPiAtCXN0cnVjdCBpbnRlbF9kaWdp dGFsX3BvcnQgKmludGVsX2RpZ19wb3J0Owo+ICAJc3RydWN0IGludGVsX2NydGMgKmNydGM7Cj4g IAlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZTsKPiAgCXN0cnVjdCBpOTE1X2F1ZGlvX2Nv bXBvbmVudCAqYWNvbXAgPSBkZXZfcHJpdi0+YXVkaW9fY29tcG9uZW50Owo+IC0JZW51bSBwaXBl IHBpcGUgPSAtMTsKPiArCWVudW0gcGlwZSBwaXBlOwo+ICAJdTMyIHRtcDsKPiAgCWludCBuOwo+ ICAKPiBAQCAtNjUyLDIyICs2NjgsMTQgQEAgc3RhdGljIGludCBpOTE1X2F1ZGlvX2NvbXBvbmVu dF9zeW5jX2F1ZGlvX3JhdGUoc3RydWN0IGRldmljZSAqZGV2LAo+ICAKPiAgCW11dGV4X2xvY2so JmRldl9wcml2LT5hdl9tdXRleCk7Cj4gIAkvKiAxLiBnZXQgdGhlIHBpcGUgKi8KPiAtCWZvcl9l YWNoX2ludGVsX2VuY29kZXIoZHJtX2RldiwgaW50ZWxfZW5jb2Rlcikgewo+IC0JCWlmIChpbnRl bF9lbmNvZGVyLT50eXBlICE9IElOVEVMX09VVFBVVF9IRE1JKQo+IC0JCQljb250aW51ZTsKPiAt CQlpbnRlbF9kaWdfcG9ydCA9IGVuY190b19kaWdfcG9ydCgmaW50ZWxfZW5jb2Rlci0+YmFzZSk7 Cj4gLQkJaWYgKHBvcnQgPT0gaW50ZWxfZGlnX3BvcnQtPnBvcnQpIHsKPiAtCQkJY3J0YyA9IHRv X2ludGVsX2NydGMoaW50ZWxfZW5jb2Rlci0+YmFzZS5jcnRjKTsKPiAtCQkJcGlwZSA9IGNydGMt PnBpcGU7Cj4gLQkJCWJyZWFrOwo+IC0JCX0KPiAtCX0KPiAtCj4gLQlpZiAocGlwZSA9PSBJTlZB TElEX1BJUEUpIHsKPiArCWludGVsX2VuY29kZXIgPSBhdWRpb19wb3J0X3RvX2VuY29kZXIoZHJt X2RldiwgcG9ydCk7Cj4gKwlpZiAoIWludGVsX2VuY29kZXIgfHwgaW50ZWxfZW5jb2Rlci0+dHlw ZSAhPSBJTlRFTF9PVVRQVVRfSERNSSkgewo+ICAJCURSTV9ERUJVR19LTVMoIm5vIHBpcGUgZm9y IHRoZSBwb3J0ICVjXG4iLCBwb3J0X25hbWUocG9ydCkpOwo+ICAJCW11dGV4X3VubG9jaygmZGV2 X3ByaXYtPmF2X211dGV4KTsKPiAgCQlyZXR1cm4gLUVOT0RFVjsKPiAgCX0KPiArCWNydGMgPSB0 b19pbnRlbF9jcnRjKGludGVsX2VuY29kZXItPmJhc2UuY3J0Yyk7Cj4gKwlwaXBlID0gY3J0Yy0+ cGlwZTsKPiAgCURSTV9ERUJVR19LTVMoInBpcGUgJWMgY29ubmVjdHMgcG9ydCAlY1xuIiwKPiAg CQkJCSAgcGlwZV9uYW1lKHBpcGUpLCBwb3J0X25hbWUocG9ydCkpOwo+ICAJbW9kZSA9ICZjcnRj LT5jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZTsKPiBAQCAtNzE3LDIzICs3MjUsMTggQEAgc3Rh dGljIGludCBpOTE1X2F1ZGlvX2NvbXBvbmVudF9nZXRfZWxkKHN0cnVjdCBkZXZpY2UgKmRldiwg aW50IHBvcnQsCj4gIAlpbnQgcmV0ID0gLUVJTlZBTDsKPiAgCj4gIAltdXRleF9sb2NrKCZkZXZf cHJpdi0+YXZfbXV0ZXgpOwo+IC0JZm9yX2VhY2hfaW50ZWxfZW5jb2Rlcihkcm1fZGV2LCBpbnRl bF9lbmNvZGVyKSB7Cj4gLQkJaWYgKGludGVsX2VuY29kZXItPnR5cGUgIT0gSU5URUxfT1VUUFVU X0RJU1BMQVlQT1JUICYmCj4gLQkJICAgIGludGVsX2VuY29kZXItPnR5cGUgIT0gSU5URUxfT1VU UFVUX0hETUkpCj4gLQkJCWNvbnRpbnVlOwo+ICsJaW50ZWxfZW5jb2RlciA9IGF1ZGlvX3BvcnRf dG9fZW5jb2Rlcihkcm1fZGV2LCBwb3J0KTsKPiArCWlmIChpbnRlbF9lbmNvZGVyKSB7Cj4gKwkJ cmV0ID0gMDsKPiAgCQlpbnRlbF9kaWdfcG9ydCA9IGVuY190b19kaWdfcG9ydCgmaW50ZWxfZW5j b2Rlci0+YmFzZSk7Cj4gLQkJaWYgKHBvcnQgPT0gaW50ZWxfZGlnX3BvcnQtPnBvcnQpIHsKPiAt CQkJcmV0ID0gMDsKPiAtCQkJKmVuYWJsZWQgPSBpbnRlbF9kaWdfcG9ydC0+YXVkaW9fZW5hYmxl ZDsKPiAtCQkJaWYgKCEqZW5hYmxlZCkKPiAtCQkJCWJyZWFrOwo+ICsJCSplbmFibGVkID0gaW50 ZWxfZGlnX3BvcnQtPmF1ZGlvX2VuYWJsZWQ7Cj4gKwkJaWYgKCplbmFibGVkKSB7Cj4gIAkJCWNv bm5lY3RvciA9IGRybV9zZWxlY3RfZWxkKCZpbnRlbF9lbmNvZGVyLT5iYXNlKTsKPiAtCQkJaWYg KCFjb25uZWN0b3IpCj4gLQkJCQlicmVhazsKPiAtCQkJZWxkID0gY29ubmVjdG9yLT5lbGQ7Cj4g LQkJCXJldCA9IG1pbihtYXhfYnl0ZXMsIGRybV9lbGRfc2l6ZShlbGQpKTsKPiAtCQkJbWVtY3B5 KGJ1ZiwgZWxkLCByZXQpOwo+IC0JCQlicmVhazsKPiArCQkJaWYgKGNvbm5lY3Rvcikgewo+ICsJ CQkJZWxkID0gY29ubmVjdG9yLT5lbGQ7Cj4gKwkJCQlyZXQgPSBtaW4obWF4X2J5dGVzLCBkcm1f ZWxkX3NpemUoZWxkKSk7Cj4gKwkJCQltZW1jcHkoYnVmLCBlbGQsIHJldCk7Cj4gKwkJCX0KPiAg CQl9Cj4gIAl9Cj4gIAo+IC0tIAo+IDIuNi4zCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVu Z2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=