From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: Enable GSE interrupt on Broadwell and later?
Date: Tue, 1 Dec 2015 23:46:25 +0200 [thread overview]
Message-ID: <20151201214625.GQ4437@intel.com> (raw)
In-Reply-To: <201512012053.tB1KroT3014721@glazunov.sibelius.xs4all.nl>
On Tue, Dec 01, 2015 at 09:53:50PM +0100, Mark Kettenis wrote:
> I just committed the following cange to the OpenBSD inteldrm(4)
> driver, which currently is mostly a port of the Linux 3.14 codebase.
> This enables the GSE interrupt on Broadwell. Without this interrupt,
> the ASLE backlight brightness mechanism doesn't work. I've verified
> that this fixed the ACPI _BCM/_BCQ-based brightness mechanism on a
> MacBookPro12,1 and a 3rd gen Lenovo X1 Carbon. And as far as I can
> tell the current Linux code still doesn't enable the GSE interrupt.
> So people over there might want to consider a diff like the one below.
Yep, looks like you're correct, we still don't enable it. Let's cook up
a patch...
>
> Cheers.
>
> Mark
>
>
> Index: i915_irq.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/drm/i915/i915_irq.c,v
> retrieving revision 1.29
> diff -u -p -r1.29 i915_irq.c
> --- i915_irq.c 23 Sep 2015 23:12:12 -0000 1.29
> +++ i915_irq.c 1 Dec 2015 20:43:05 -0000
> @@ -3019,6 +3019,10 @@ static void gen8_de_irq_postinstall(stru
> I915_WRITE(GEN8_DE_PORT_IMR, ~GEN8_AUX_CHANNEL_A);
> I915_WRITE(GEN8_DE_PORT_IER, GEN8_AUX_CHANNEL_A);
> POSTING_READ(GEN8_DE_PORT_IER);
> +
> + I915_WRITE(GEN8_DE_MISC_IMR, ~GEN8_DE_MISC_GSE);
> + I915_WRITE(GEN8_DE_MISC_IER, GEN8_DE_MISC_GSE);
> + POSTING_READ(GEN8_DE_MISC_IER);
> }
>
> static int gen8_irq_postinstall(struct drm_device *dev)
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-12-01 21:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 20:53 Enable GSE interrupt on Broadwell and later? Mark Kettenis
2015-12-01 21:46 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201214625.GQ4437@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox