From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 04/10] drm/i915: Add "missing" break to haswell_get_ddi_pll()
Date: Wed, 2 Dec 2015 11:29:10 +0200 [thread overview]
Message-ID: <20151202092910.GU4437@intel.com> (raw)
In-Reply-To: <1449005527-15617-1-git-send-email-ville.syrjala@linux.intel.com>
On Tue, Dec 01, 2015 at 11:32:07PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> While not technically needed on the last case in the switch statement,
> the 'break' makes it look better IMO.
>
> v2: Fixed a typo in the commit message (Paulo)
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 9f8ab09eb411..edc034dc38b2 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -9808,6 +9808,7 @@ static void haswell_get_ddi_pll(struct drm_i915_private *dev_priv,
> break;
> case PORT_CLK_SEL_SPLL:
> pipe_config->shared_dpll = DPLL_ID_SPLL;
> + break;
> }
> }
Merged up to this patch. Thanks for the reviews.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-12-02 9:31 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 13:08 [PATCH 00/10] HSW/BDW PCH modeset fixes and stuff ville.syrjala
2015-12-01 13:08 ` [PATCH 01/10] drm/i915: Don't register the CRT connector when it's fused off ville.syrjala
2015-12-01 19:05 ` Paulo Zanoni
2015-12-01 19:18 ` Ville Syrjälä
2015-12-01 21:28 ` [PATCH v2 01/10] drm/i915: Don't register the CRT connector when it's fused off on LPT-H ville.syrjala
2015-12-01 13:08 ` [PATCH 02/10] drm/i915: Don't register CRT connectro when DDI E can't be used ville.syrjala
2015-12-01 19:13 ` Paulo Zanoni
2015-12-01 21:29 ` [PATCH v2 02/10] drm/i915: Don't register CRT connector " ville.syrjala
2015-12-01 13:08 ` [PATCH 03/10] drm/i915: Check VBT for CRT port presence on HSW/BDW ville.syrjala
2015-12-01 13:41 ` Chris Wilson
2015-12-01 13:57 ` Ville Syrjälä
2015-12-01 14:06 ` Chris Wilson
2015-12-01 14:19 ` Ville Syrjälä
2015-12-01 16:07 ` [PATCH v2 " ville.syrjala
2015-12-01 18:15 ` Ville Syrjälä
2015-12-01 19:28 ` Paulo Zanoni
2015-12-01 19:40 ` Ville Syrjälä
2015-12-01 21:31 ` [PATCH v3 " ville.syrjala
2015-12-01 13:08 ` [PATCH 04/10] drm/i915: Add "missing" break to haswell_get_ddi_pll() ville.syrjala
2015-12-01 19:34 ` Paulo Zanoni
2015-12-01 19:45 ` Ville Syrjälä
2015-12-01 21:32 ` [PATCH v2 " ville.syrjala
2015-12-02 9:29 ` Ville Syrjälä [this message]
2015-12-01 13:08 ` [PATCH 05/10] drm/i915: Disable CLKOUT_DP bending on LPT/WPT as needed ville.syrjala
2015-12-02 13:35 ` Paulo Zanoni
2015-12-03 10:03 ` Ville Syrjälä
2015-12-03 11:16 ` Paulo Zanoni
2015-12-04 20:19 ` [PATCH v2 " ville.syrjala
2015-12-07 16:54 ` Paulo Zanoni
2015-12-01 13:08 ` [PATCH 06/10] drm/i915: Round to closest when computing the VGA dotclock for LPT-H ville.syrjala
2015-12-02 13:45 ` Paulo Zanoni
2015-12-04 20:20 ` [PATCH v2 " ville.syrjala
2015-12-01 13:08 ` [PATCH 07/10] drm/i915: Disable FDI after the CRT port on LPT-H ville.syrjala
2015-12-02 14:01 ` Paulo Zanoni
2015-12-03 10:14 ` Ville Syrjälä
2015-12-04 20:20 ` [PATCH v2 " ville.syrjala
2015-12-07 17:51 ` Paulo Zanoni
2015-12-07 18:57 ` Ville Syrjälä
2015-12-08 14:04 ` Ville Syrjälä
2015-12-08 14:05 ` [PATCH] " ville.syrjala
2015-12-01 13:08 ` [PATCH 08/10] drm/i915: Refactor LPT-H VGA dotclock disabling ville.syrjala
2015-12-02 16:56 ` Paulo Zanoni
2015-12-03 10:15 ` Ville Syrjälä
2015-12-04 20:21 ` [PATCH v2 " ville.syrjala
2015-12-01 13:08 ` [PATCH 09/10] drm/i915: Disable LPT-H VGA dotclock during crtc disable ville.syrjala
2015-12-02 17:02 ` Paulo Zanoni
2015-12-03 10:29 ` Ville Syrjälä
2015-12-04 20:22 ` [PATCH v2 " ville.syrjala
2015-12-01 13:08 ` [PATCH 10/10] drm/i915: Leave FDI running after failed link training on LPT-H ville.syrjala
2015-12-02 17:16 ` Paulo Zanoni
2015-12-03 10:30 ` Ville Syrjälä
2015-12-04 10:09 ` Daniel Vetter
2015-12-04 11:59 ` Ville Syrjälä
2015-12-04 20:22 ` [PATCH v2 " ville.syrjala
2015-12-08 14:32 ` [PATCH 00/10] HSW/BDW PCH modeset fixes and stuff Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151202092910.GU4437@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox