From: Johannes Weiner <hannes@cmpxchg.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: linux-mm@kvack.org, intel-gfx@lists.freedesktop.org,
sourab.gupta@intel.com, Akash Goel <akash.goel@intel.com>
Subject: Re: [PATCH v2 2/2] drm/i915: Disable shrinker for non-swapped backed objects
Date: Fri, 4 Dec 2015 11:11:01 -0500 [thread overview]
Message-ID: <20151204161101.GB24927@cmpxchg.org> (raw)
In-Reply-To: <1449244734-25733-2-git-send-email-chris@chris-wilson.co.uk>
On Fri, Dec 04, 2015 at 03:58:54PM +0000, Chris Wilson wrote:
> If the system has no available swap pages, we cannot make forward
> progress in the shrinker by releasing active pages, only by releasing
> purgeable pages which are immediately reaped. Take total_swap_pages into
> account when counting up available objects to be shrunk and subsequently
> shrinking them. By doing so, we avoid unbinding objects that cannot be
> shrunk and so wasting CPU cycles flushing those objects from the GPU to
> the system and then immediately back again (as they will more than
> likely be reused shortly after).
>
> Based on a patch by Akash Goel.
>
> v2: frontswap registers extra swap pages available for the system, so it
> is already include in the count of available swap pages.
>
> v3: Use get_nr_swap_pages() to query the currently available amount of
> swap space. This should also stop us from shrinking the GPU buffers if
> we ever run out of swap space. Though at that point, we would expect the
> oom-notifier to be running and failing miserably...
>
> Reported-by: Akash Goel <akash.goel@intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: linux-mm@kvack.org
> Cc: Akash Goel <akash.goel@intel.com>
> Cc: sourab.gupta@intel.com
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-12-04 16:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 15:58 [PATCH v2 1/2] mm: Export nr_swap_pages Chris Wilson
2015-12-04 15:58 ` [PATCH v2 2/2] drm/i915: Disable shrinker for non-swapped backed objects Chris Wilson
2015-12-04 16:11 ` Johannes Weiner [this message]
2015-12-10 9:34 ` Daniel Vetter
2015-12-04 16:09 ` [PATCH v2 1/2] mm: Export nr_swap_pages Johannes Weiner
2015-12-10 9:32 ` [Intel-gfx] " Daniel Vetter
2015-12-23 22:04 ` Johannes Weiner
2015-12-23 22:26 ` [Intel-gfx] " Andrew Morton
2016-01-05 10:05 ` Daniel Vetter
2015-12-07 13:48 ` Michal Hocko
2015-12-07 16:48 ` Johannes Weiner
2015-12-07 17:04 ` Michal Hocko
2015-12-07 18:02 ` Johannes Weiner
2015-12-07 18:10 ` [Intel-gfx] " Dave Gordon
2015-12-07 19:13 ` Johannes Weiner
2015-12-08 11:19 ` Dave Gordon
2015-12-08 11:22 ` Michal Hocko
2015-12-17 18:15 ` [PATCH v3] mm: Export {__}get_nr_swap_pages() Dave Gordon
2015-12-17 19:45 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151204161101.GB24927@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akash.goel@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-mm@kvack.org \
--cc=sourab.gupta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox