Re: [PATCH 2/9] drm/tegra: Assign conn_state->connector when allocating connector state.

Daniel Vetter
2015-11-24T10:37:51Z

On Tue, Nov 24, 2015 at 10:34:29AM +0100, Maarten Lankhorst wrote:
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
> drivers/gpu/drm/tegra/dsi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c
> index f0a138ef68ce..6b8ae3d08eeb 100644
> --- a/drivers/gpu/drm/tegra/dsi.c
> +++ b/drivers/gpu/drm/tegra/dsi.c
> @@ -751,8 +751,10 @@ static void tegra_dsi_connector_reset(struct drm_connector *connector)
> connector->state = NULL;
>
> state = kzalloc(sizeof(*state), GFP_KERNEL);
> - if (state)
> + if (state) {
> + state->base.connector = connector;
> connector->state = &state->base;
> + }

Hm, we might want __ versions of all the _reset hooks if this becomes more
common. I do wonder a bit why it isn't since a lot of drivers overwrite
state structures by now, and then the provided reset functions aren't
sufficient really.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org