Re: [Intel-gfx] [PATCH 4/9] drm/core: Add drm_for_each_encoder_mask.

Jani Nikula
2015-11-24T18:00:47Z

On Tue, 24 Nov 2015, Maarten Lankhorst <maarten.lankhorst@linux.intel.com> wrote:
> +#define drm_for_each_encoder_mask(encoder, dev, encoder_mask) \
> + list_for_each_entry((encoder), &(dev)->mode_config.encoder_list, head) \
> + if ((encoder_mask) & (1 << drm_encoder_index(encoder)))

How about

if (!((encoder_mask) & (1 << drm_encoder_index(encoder)))); else

to avoid dangling else problems?

This inspired me to write [1].

BR,
Jani.

[1] http://patchwork.freedesktop.org/patch/msgid/1448386585-4144-1-git-send-email-jani.nikula@intel.com

--
Jani Nikula, Intel Open Source Technology Center