From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 16/28] drm: Document drm_atomic_*_get_property Date: Mon, 7 Dec 2015 13:01:35 +0100 Message-ID: <20151207120135.GT13177@ulmo> References: <1449218769-16577-1-git-send-email-daniel.vetter@ffwll.ch> <1449218769-16577-17-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1952363290==" Return-path: In-Reply-To: <1449218769-16577-17-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Intel Graphics Development , DRI Development List-Id: intel-gfx@lists.freedesktop.org --===============1952363290== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DvifzEOEABd5jzbd" Content-Disposition: inline --DvifzEOEABd5jzbd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 04, 2015 at 09:45:57AM +0100, Daniel Vetter wrote: > Yes these are internal functions and not exported and we generally > don't document them. But for symmetry with the _set_property functions > (which are exported for the atomic helpers) I'd like to document them. > Upcoming vtable kerneldoc will reference both the set and get_property > functions. >=20 > Signed-off-by: Daniel Vetter > --- > Documentation/DocBook/gpu.tmpl | 1 + > drivers/gpu/drm/drm_atomic.c | 33 ++++++++++++++++++++++++++++++--- > 2 files changed, 31 insertions(+), 3 deletions(-) >=20 > diff --git a/Documentation/DocBook/gpu.tmpl b/Documentation/DocBook/gpu.t= mpl > index 23ad100c2bf5..02c7d44f517c 100644 > --- a/Documentation/DocBook/gpu.tmpl > +++ b/Documentation/DocBook/gpu.tmpl > @@ -946,6 +946,7 @@ int max_width, max_height; > > Atomic Mode Setting Function Reference > !Edrivers/gpu/drm/drm_atomic.c > +!Idrivers/gpu/drm/drm_atomic.c > > > Frame Buffer Creation > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > index ef5f7663a718..7426d40017a0 100644 > --- a/drivers/gpu/drm/drm_atomic.c > +++ b/drivers/gpu/drm/drm_atomic.c > @@ -429,11 +429,20 @@ int drm_atomic_crtc_set_property(struct drm_crtc *c= rtc, > } > EXPORT_SYMBOL(drm_atomic_crtc_set_property); > =20 > -/* > +/** > + * drm_atomic_crtc_get_property - get property value from CRTC state > + * @crtc: the drm CRTC to set a property on > + * @state: the state object to get the property value from > + * @property: the property to set > + * @val: pointer to where the value should be written to Nit: I find this difficult to write and read, and I prefer the wording "return location for the property value". But either way: Reviewed-by: Thierry Reding --DvifzEOEABd5jzbd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWZXUfAAoJEN0jrNd/PrOhZtcP/i3LK28QIfcG7MU5ZxvHm504 R2azUaP9ZiO6i2rBk5dLPSpUL6Z99WWGAehfntfFQcOySPB8RfIpX8HsJawCrAJv rb/oKzZj1E2zRl3cBsckvCwWNpILD5l34Pw2Mbip7CXBKWVuFGiV0fhbEqz6b9Id l0i5ZiQTRHAzcHK3iwU454Qp/Ghq3ahjpe4hojAi2wZLkrJuXbcZdbk1MQZbD62H iDOnpbQqXOz1jkw4D54CSeFf01VMn8qwIGKNDmuHtQ8dHdu9BqQX/sKB+30IGL7w kGGMOKDo0XImt2PjTTYwwY6y/Nmd7K92lQeHjIhwYbMzIxcSf7hNwBib0Esl8Aqa qTPH+I5Lfh8xVzR0Vxqgn9p4eudT/O8OH41z5+9iWGb88MAPYXD4z/+LNRS6tyDu 0KpM9MTtZAj6lc/WCPr0B5d+ow6fVlX+Cj9nbFpWUlES1b2+i1Ib8qHDEsQiUsbr /ueW1dkvaoQ+hjLG6F1LxfSRlmKfFKNET21oKJBkgYAm0fG3HCQsk3ueM7JkPpR1 3VJT0VI9/BuzFYtC4LgwXrs/nWA5NKaxcLKcyHYfLxY1xupa4uOvJSbmVOUPrChW nKopOFQLhagfFcfi4CG4oyda1qtDu+xkOlEQAGKBnX/Du269epZF3JIxs3pvRBh0 i/oM4YyLuXT2k8VT6m/g =FF0w -----END PGP SIGNATURE----- --DvifzEOEABd5jzbd-- --===============1952363290== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============1952363290==--