From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 17/28] drm: Document drm_connector_funcs Date: Mon, 7 Dec 2015 13:05:16 +0100 Message-ID: <20151207120516.GU13177@ulmo> References: <1449218769-16577-1-git-send-email-daniel.vetter@ffwll.ch> <1449218769-16577-18-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0056420929==" Return-path: In-Reply-To: <1449218769-16577-18-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: intel-gfx@lists.freedesktop.org --===============0056420929== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="z+AhoeLdLI498vdY" Content-Disposition: inline --z+AhoeLdLI498vdY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 04, 2015 at 09:45:58AM +0100, Daniel Vetter wrote: > The special case here is that both ->detect and ->force are actually > functions only called by the probe helpers and hence really shouldn't > be here. But since they've used by pretty much every driver I figured > it's better to just document this for now instead of holding this doc > patch hostage until that's all fixed. For that reason also group force > right next to detect. >=20 > v2: Use FIXME comments to annotate where we should move a hook to > helpers. >=20 > Signed-off-by: Daniel Vetter > --- > include/drm/drm_crtc.h | 84 ++++++++++++++++++++++++++++++++++++++++++++= ------ > 1 file changed, 74 insertions(+), 10 deletions(-) Reviewed-by: Thierry Reding --z+AhoeLdLI498vdY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWZXX8AAoJEN0jrNd/PrOhllIQAJfAYwwLJkIxCYVn3pOiAhoZ 34ZhGdHrxLFAXKQalYcLK2zx+00K+wkT+hIz+xjpMBDtTFVKfbqn8Y0iBLOUrDPx EqkHDNu+1BW2ieWFKv5ZP8iTYj0gFsFOQGZZB21DVu9+jfdSc3uPa7nciYKOCXie G/dlyCmazj9jaD7CeZj8lxaEUsL3W0D7qqapW1pkCblu3ssv7EE3kxX0Eii7KpNC CHsVkLegUUHzUvdSnCcnXWr1J9J35zMhU6FxC/73nJNIEa4xPDMnIgEyrEivvQPD GuP7UgbnHepTVFXClSdKXJwq8UY2ANz3US+xgiZK0pDYgWJANSbSgEh2y8qJDWtw 6B+GJgBHzRVz2tG5L7cWeKu9wJeJFKQQh38I+b5RzTKgLaoYwkIGuTOsRW1YJNo1 /HNdAQT6a68lWCflElERfHy4bfZU3h1g/efS43hdDJwOzPJUtUrRhWsx81lC3CmR tPTAI0453P+5/PGRCsfovvu09Pmw34RV5TSixZOK8n42Dn5Ngun6RD2TzK3dD5bL 8xb/2ox+wOXEcYNnrcHiqinPEAKZA4XXcxY1cAbWCbieQBJHxPZ7A6zp1cQWQC22 osrQxYIVHS/omaxbYLRqjhnaCGMSQFj9t6QMRNIJTXDXRfrOoMhQ+e/7/3ZboqBS SJG+n+MAkf2HCIxEMlvQ =ZmDR -----END PGP SIGNATURE----- --z+AhoeLdLI498vdY-- --===============0056420929== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============0056420929==--