From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 24/28] drm: Document drm_connector_helper_funcs Date: Mon, 7 Dec 2015 16:27:35 +0100 Message-ID: <20151207152735.GJ13177@ulmo> References: <1449218769-16577-1-git-send-email-daniel.vetter@ffwll.ch> <1449218769-16577-25-git-send-email-daniel.vetter@ffwll.ch> <20151207144222.GE13177@ulmo> <20151207144837.GL10243@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1302890810==" Return-path: In-Reply-To: <20151207144837.GL10243@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: intel-gfx@lists.freedesktop.org --===============1302890810== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qX4XtzAfKSOolMWY" Content-Disposition: inline --qX4XtzAfKSOolMWY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 07, 2015 at 03:48:37PM +0100, Daniel Vetter wrote: > On Mon, Dec 07, 2015 at 03:42:22PM +0100, Thierry Reding wrote: > > On Fri, Dec 04, 2015 at 09:46:05AM +0100, Daniel Vetter wrote: > > > Nothing special, except the somewhat awkard split in probe helper > >=20 > > "awkward" > >=20 > > > callbacks between here and drm_crtc_funcs. > > >=20 > > > Signed-off-by: Daniel Vetter > > > --- > > > include/drm/drm_modeset_helper_vtables.h | 106 +++++++++++++++++++++= ++++++++-- > > > 1 file changed, 101 insertions(+), 5 deletions(-) > > >=20 > > > diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/d= rm_modeset_helper_vtables.h > > > index 66b78c14154e..22cc51b278fb 100644 > > > --- a/include/drm/drm_modeset_helper_vtables.h > > > +++ b/include/drm/drm_modeset_helper_vtables.h > > > @@ -264,18 +264,114 @@ static inline void drm_encoder_helper_add(stru= ct drm_encoder *encoder, > > > =20 > > > /** > > > * struct drm_connector_helper_funcs - helper operations for connect= ors > > > - * @get_modes: get mode list for this connector > > > - * @mode_valid: is this mode valid on the given connector? (optional) > > > - * @best_encoder: return the preferred encoder for this connector > > > - * @atomic_best_encoder: atomic version of @best_encoder > > > * > > > - * The helper operations are called by the mid-layer CRTC helper. > > > + * These functions are used by the atomic and legacy modeset helpers= and by the > > > + * probe helpers. > > > */ > > > struct drm_connector_helper_funcs { > > > + /** > > > + * @get_modes: > > > + * > > > + * This function should fill in all modes currently valid for the s= ink > > > + * into the connector->probe_modes function. It should also update = the > >=20 > > What's probe_modes? I've never heard of it. Did you mean ->fill_modes()? > > Also it's strange to say "fill into the ... function". Perhaps "pass > > into the ... function" instead? >=20 > connector->probe*d*_modes *list* is what it should read. Fixed. As with all the other patches, with this and the nits fixed: Reviewed-by: Thierry Reding --qX4XtzAfKSOolMWY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWZaVnAAoJEN0jrNd/PrOh5WYQAJKjfFTcRX3gLB5tvpQGhwkt wIV6gN9TEPwHl4t4g5dcZDL4vOhEYQOdnAM7HsHYnfTiNDF+ZlxdIpebvDYuMkXZ rSmxUjBjrjjmXvN2m+Lx2w1pcZmSZIeUwLY2QZVGrmhRg5fcr6ln5BdD/nUd0FKC OjJaT0d6La06ZkEbYscfZGebQS4YurTU57ba4vJJLGCsmtNpEoAmJF/Ei0eUMrQW 4ZG3EmZRfCzQJ12idXQOhgxJr4twKr7EyHy0TesxZMatbfUWiFM9anvAcjgSHp3m lNltDMQb1tZY+kIy6dmrdpYqzClUaRCMobZy/TFSIbeNAwzLf2x9l46quhgxCYem ReaGcOXFTH9hnKUVsFwTQsZQuzwsYVtH1+FwIcLshRUITUdpOE+HcQNWQVlOrL+P ZQFwPF6sZcq6CD2mK9PtD6+SVhif+pWasqlgsq7lBi4VpW9Bm0yQEfLxejyZuMQh IIaRGW8YWT2LKmkrzbZHVn0lpjOcKrwT+TIsRzg+1gW5WBoFIftWjHehVHvG6ijY /+MxOw7ZRZzJjnGCkZf0zje4WvhYf/kx6M6u6KIw/8wDTjGQ9g4H0V20U6XQw3iq znFg3pX7CdiZ5wt7HINphai3etTctgq9g3BukTEqQEeCA4tQUFvrYFaYnFG6oysv 0oU5vG6bERkZBYJyBN94 =RyNs -----END PGP SIGNATURE----- --qX4XtzAfKSOolMWY-- --===============1302890810== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1302890810==--