Re: [PATCH 21/28] drm: Kerneldoc for drm_mode_config_funcs

Daniel Vetter
2015-12-07T13:34:25Z

On Mon, Dec 07, 2015 at 02:14:48PM +0100, Thierry Reding wrote:
> On Fri, Dec 04, 2015 at 09:46:02AM +0100, Daniel Vetter wrote:
> > + * This list is exhaustive. Specifically this hook is not allowed to
> > + * return -EINVAL (any invalid requests should be caught in
> > + * @atomic_check) or -EDEADLK (this function must not acquire
> > + * additional modeset locks). The core will also reject any async
> > + * atomic flips with -EINVAL already (for matching semantics in this
> > + * case with legacy page flips).
>
> Can you elaborate on this last assertion? Why does the core reject async
> atomic flips? I don't see where it does that.

Was an ongoing discussion with Daniels Stone about what exactly we should
do here. Separate patch, not yet resolved so I dropped that sentence for
now - currently core code does indeed not do that.

All other suggestions applied, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation