Re: [PATCH 03/28] drm: Reorganize helper vtables and their docs

Thierry Reding
2015-12-07T12:26:46Z

[-- Attachment #1.1: Type: text/plain, Size: 1557 bytes --]

On Mon, Dec 07, 2015 at 12:59:33PM +0100, Daniel Vetter wrote:
> On Mon, Dec 07, 2015 at 12:00:09PM +0100, Thierry Reding wrote:
> > On Fri, Dec 04, 2015 at 09:45:44AM +0100, Daniel Vetter wrote:
> > [...]
> > > diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
> > > index 10d0989db273..077e48d3cac2 100644
> > > --- a/drivers/gpu/drm/drm_crtc_helper.c
> > > +++ b/drivers/gpu/drm/drm_crtc_helper.c
> > > @@ -62,6 +62,11 @@
> > > * converting to the plane helpers). New drivers must not use these functions
> > > * but need to implement the atomic interface instead, potentially using the
> > > * atomic helpers for that.
> > > + *
> > > + * The these legacy modeset helpers use the same function table structures as
> >
> > s/The these/The/
> >
> > > diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h
> > > new file mode 100644
> > > index 000000000000..35c5a1c4e7ba
> > > --- /dev/null
> > > +++ b/include/drm/drm_modeset_helper_vtables.h
> > > @@ -0,0 +1,252 @@
> > > +/*
> > > + * Copyright © 2015 Intel Corporation
> > > + * Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > Perhaps inherit the copyright statements from the includes that you
> > extracted these from?
>
> Done for the above two - all the stuff below is just moved and would
> conflict massively with later patches. So left that as per our irc
> discussion.

For the record, I'm fine with leave the below as-is and fix it up in a
follow-up patch.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]