From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Wayne Boyer <wayne.boyer@intel.com>,
intel-gfx@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 4/5] drm/i915: Only set gem object L3 cache level for IVB devices
Date: Tue, 8 Dec 2015 23:07:01 +0200 [thread overview]
Message-ID: <20151208210701.GX4437@intel.com> (raw)
In-Reply-To: <20151208205048.GH26418@nuc-i3427.alporthouse.com>
On Tue, Dec 08, 2015 at 08:50:48PM +0000, Chris Wilson wrote:
> On Tue, Dec 08, 2015 at 07:45:50PM +0200, Ville Syrjälä wrote:
> > On Tue, Dec 08, 2015 at 09:38:52AM -0800, Wayne Boyer wrote:
> > > Do some further clean up based on the initial review of
> > > drm/i915: Separate cherryview from valleyview.
> > >
> > > In this case, in i915_gem_alloc_context_obj() only call
> > > i915_gem_object_set_cache_level() for Ivy Bridge devices
> > > since later platforms don't have L3 control bits in the PTE.
> > >
> > > v2: Expand comment to mention snooping requirement. (Ville, Imre)
> > >
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Signed-off-by: Wayne Boyer <wayne.boyer@intel.com>
> >
> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Loses Haswell.
Nope. HSW doesn't do L3 via PTEs.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-12-08 21:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 18:51 [PATCH 0/5] CHV and VLV separation and clean up Wayne Boyer
2015-12-07 18:51 ` [PATCH 1/5] drm/i915: Separate cherryview from valleyview Wayne Boyer
2015-12-08 11:44 ` Jani Nikula
2015-12-08 11:51 ` Ville Syrjälä
2015-12-08 19:46 ` Wayne Boyer
2015-12-09 17:10 ` Ville Syrjälä
2015-12-09 20:27 ` Boyer, Wayne
2015-12-09 20:29 ` Wayne Boyer
2015-12-09 20:59 ` Ville Syrjälä
2015-12-10 9:45 ` Jani Nikula
2015-12-07 18:51 ` [PATCH 2/5] drm/i915: Use HAS_PCH_SPLIT to determine correct devices Wayne Boyer
2015-12-07 19:18 ` Ville Syrjälä
2015-12-07 18:51 ` [PATCH 3/5] drm/i915: Remove VLV A0 hack Wayne Boyer
2015-12-07 19:19 ` Ville Syrjälä
2015-12-07 18:51 ` [PATCH 4/5] drm/i915: Only set gem object L3 cache level for IVB devices Wayne Boyer
2015-12-07 19:28 ` Ville Syrjälä
2015-12-07 19:56 ` Imre Deak
2015-12-07 22:26 ` Boyer, Wayne
2015-12-08 11:47 ` Ville Syrjälä
2015-12-08 17:38 ` Wayne Boyer
2015-12-08 17:45 ` Ville Syrjälä
2015-12-08 20:50 ` Chris Wilson
2015-12-08 21:07 ` Ville Syrjälä [this message]
2015-12-08 21:12 ` Chris Wilson
2015-12-07 18:51 ` [PATCH 5/5] drm/i915: Remove BUG_ON call in vlv_enable_pll Wayne Boyer
2015-12-07 19:29 ` Ville Syrjälä
2015-12-07 19:47 ` Ville Syrjälä
2015-12-07 23:02 ` Wayne Boyer
2015-12-08 11:48 ` Ville Syrjälä
2015-12-10 9:46 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151208210701.GX4437@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=wayne.boyer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox