From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 04/15] drm/i915: Remove pointless 'ddi_translations' local variable Date: Thu, 10 Dec 2015 14:22:58 +0100 Message-ID: <20151210132258.GB20822@phenom.ffwll.local> References: <1449597590-6971-1-git-send-email-ville.syrjala@linux.intel.com> <1449597590-6971-5-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E2EB7A08B for ; Thu, 10 Dec 2015 05:23:03 -0800 (PST) Received: by mail-wm0-f51.google.com with SMTP id c201so32822179wme.0 for ; Thu, 10 Dec 2015 05:23:03 -0800 (PST) Content-Disposition: inline In-Reply-To: <1449597590-6971-5-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBEZWMgMDgsIDIwMTUgYXQgMDc6NTk6MzlQTSArMDIwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBza2xfZ2V0X2J1Zl90cmFuc18qKCkgZG9uJ3QgbmVl ZCB0aGUgJ2RkaV90cmFuc2xhdGlvbnMnIGxvY2FsIHZhcmlhYmxlCj4gc2luY2UgYWxsIHRoZXkg d2l0aCBpcyBhc3NpZ24gYW5kIHJldHVybi4gSnVzdCByZXR1cm4gdGhlIHJpZ2h0IHRoaW5nCj4g ZGlyZWN0bHkgYW5kIGdldCByaWQgb2YgdGhlIGxvY2FsIHZhcmlhYmxlLgo+IAo+IFNpZ25lZC1v ZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpS ZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KCj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIHwgNDQgKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTYgaW5zZXJ0aW9u cygrKSwgMjggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RkaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBpbmRl eCBmZGI0YWFhMDg0ZDYuLmY4NTE3ZWQ0ZDYzNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kZGkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rk aS5jCj4gQEAgLTM0OCw3NSArMzQ4LDYzIEBAIGludGVsX2RpZ19wb3J0X3N1cHBvcnRzX2hkbWko Y29uc3Qgc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQpCj4gIAlyZXR1 cm4gaTkxNV9tbWlvX3JlZ192YWxpZChpbnRlbF9kaWdfcG9ydC0+aGRtaS5oZG1pX3JlZyk7Cj4g IH0KPiAgCj4gLXN0YXRpYyBjb25zdCBzdHJ1Y3QgZGRpX2J1Zl90cmFucyAqc2tsX2dldF9idWZf dHJhbnNfZHAoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAtCQkJCQkJCWludCAqbl9lbnRyaWVz KQo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGRkaV9idWZfdHJhbnMgKgo+ICtza2xfZ2V0X2J1Zl90 cmFuc19kcChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBpbnQgKm5fZW50cmllcykKPiAgewo+IC0J Y29uc3Qgc3RydWN0IGRkaV9idWZfdHJhbnMgKmRkaV90cmFuc2xhdGlvbnM7Cj4gLQo+ICAJaWYg KElTX1NLTF9VTFgoZGV2KSkgewo+IC0JCWRkaV90cmFuc2xhdGlvbnMgPSBza2xfeV9kZGlfdHJh bnNsYXRpb25zX2RwOwo+ICAJCSpuX2VudHJpZXMgPSBBUlJBWV9TSVpFKHNrbF95X2RkaV90cmFu c2xhdGlvbnNfZHApOwo+ICsJCXJldHVybiBza2xfeV9kZGlfdHJhbnNsYXRpb25zX2RwOwo+ICAJ fSBlbHNlIGlmIChJU19TS0xfVUxUKGRldikpIHsKPiAtCQlkZGlfdHJhbnNsYXRpb25zID0gc2ts X3VfZGRpX3RyYW5zbGF0aW9uc19kcDsKPiAgCQkqbl9lbnRyaWVzID0gQVJSQVlfU0laRShza2xf dV9kZGlfdHJhbnNsYXRpb25zX2RwKTsKPiArCQlyZXR1cm4gc2tsX3VfZGRpX3RyYW5zbGF0aW9u c19kcDsKPiAgCX0gZWxzZSB7Cj4gLQkJZGRpX3RyYW5zbGF0aW9ucyA9IHNrbF9kZGlfdHJhbnNs YXRpb25zX2RwOwo+ICAJCSpuX2VudHJpZXMgPSBBUlJBWV9TSVpFKHNrbF9kZGlfdHJhbnNsYXRp b25zX2RwKTsKPiArCQlyZXR1cm4gc2tsX2RkaV90cmFuc2xhdGlvbnNfZHA7Cj4gIAl9Cj4gLQo+ IC0JcmV0dXJuIGRkaV90cmFuc2xhdGlvbnM7Cj4gIH0KPiAgCj4gLXN0YXRpYyBjb25zdCBzdHJ1 Y3QgZGRpX2J1Zl90cmFucyAqc2tsX2dldF9idWZfdHJhbnNfZWRwKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsCj4gLQkJCQkJCQkgaW50ICpuX2VudHJpZXMpCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qg ZGRpX2J1Zl90cmFucyAqCj4gK3NrbF9nZXRfYnVmX3RyYW5zX2VkcChzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LCBpbnQgKm5fZW50cmllcykKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAtCWNvbnN0IHN0cnVjdCBkZGlfYnVmX3Ry YW5zICpkZGlfdHJhbnNsYXRpb25zOwo+ICAKPiAgCWlmIChJU19TS0xfVUxYKGRldikpIHsKPiAg CQlpZiAoZGV2X3ByaXYtPmVkcF9sb3dfdnN3aW5nKSB7Cj4gLQkJCWRkaV90cmFuc2xhdGlvbnMg PSBza2xfeV9kZGlfdHJhbnNsYXRpb25zX2VkcDsKPiAgCQkJKm5fZW50cmllcyA9IEFSUkFZX1NJ WkUoc2tsX3lfZGRpX3RyYW5zbGF0aW9uc19lZHApOwo+ICsJCQlyZXR1cm4gc2tsX3lfZGRpX3Ry YW5zbGF0aW9uc19lZHA7Cj4gIAkJfSBlbHNlIHsKPiAtCQkJZGRpX3RyYW5zbGF0aW9ucyA9IHNr bF95X2RkaV90cmFuc2xhdGlvbnNfZHA7Cj4gIAkJCSpuX2VudHJpZXMgPSBBUlJBWV9TSVpFKHNr bF95X2RkaV90cmFuc2xhdGlvbnNfZHApOwo+ICsJCQlyZXR1cm4gc2tsX3lfZGRpX3RyYW5zbGF0 aW9uc19kcDsKPiAgCQl9Cj4gIAl9IGVsc2UgaWYgKElTX1NLTF9VTFQoZGV2KSkgewo+ICAJCWlm IChkZXZfcHJpdi0+ZWRwX2xvd192c3dpbmcpIHsKPiAtCQkJZGRpX3RyYW5zbGF0aW9ucyA9IHNr bF91X2RkaV90cmFuc2xhdGlvbnNfZWRwOwo+ICAJCQkqbl9lbnRyaWVzID0gQVJSQVlfU0laRShz a2xfdV9kZGlfdHJhbnNsYXRpb25zX2VkcCk7Cj4gKwkJCXJldHVybiBza2xfdV9kZGlfdHJhbnNs YXRpb25zX2VkcDsKPiAgCQl9IGVsc2Ugewo+IC0JCQlkZGlfdHJhbnNsYXRpb25zID0gc2tsX3Vf ZGRpX3RyYW5zbGF0aW9uc19kcDsKPiAgCQkJKm5fZW50cmllcyA9IEFSUkFZX1NJWkUoc2tsX3Vf ZGRpX3RyYW5zbGF0aW9uc19kcCk7Cj4gKwkJCXJldHVybiBza2xfdV9kZGlfdHJhbnNsYXRpb25z X2RwOwo+ICAJCX0KPiAgCX0gZWxzZSB7Cj4gIAkJaWYgKGRldl9wcml2LT5lZHBfbG93X3Zzd2lu Zykgewo+IC0JCQlkZGlfdHJhbnNsYXRpb25zID0gc2tsX2RkaV90cmFuc2xhdGlvbnNfZWRwOwo+ ICAJCQkqbl9lbnRyaWVzID0gQVJSQVlfU0laRShza2xfZGRpX3RyYW5zbGF0aW9uc19lZHApOwo+ ICsJCQlyZXR1cm4gc2tsX2RkaV90cmFuc2xhdGlvbnNfZWRwOwo+ICAJCX0gZWxzZSB7Cj4gLQkJ CWRkaV90cmFuc2xhdGlvbnMgPSBza2xfZGRpX3RyYW5zbGF0aW9uc19kcDsKPiAgCQkJKm5fZW50 cmllcyA9IEFSUkFZX1NJWkUoc2tsX2RkaV90cmFuc2xhdGlvbnNfZHApOwo+ICsJCQlyZXR1cm4g c2tsX2RkaV90cmFuc2xhdGlvbnNfZHA7Cj4gIAkJfQo+ICAJfQo+IC0KPiAtCXJldHVybiBkZGlf dHJhbnNsYXRpb25zOwo+ICB9Cj4gIAo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGRkaV9idWZfdHJh bnMgKgo+IC1za2xfZ2V0X2J1Zl90cmFuc19oZG1pKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4g LQkJICAgICAgIGludCAqbl9lbnRyaWVzKQo+ICtza2xfZ2V0X2J1Zl90cmFuc19oZG1pKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsIGludCAqbl9lbnRyaWVzKQo+ICB7Cj4gLQljb25zdCBzdHJ1Y3Qg ZGRpX2J1Zl90cmFucyAqZGRpX3RyYW5zbGF0aW9uczsKPiAtCj4gIAlpZiAoSVNfU0tMX1VMWChk ZXYpKSB7Cj4gLQkJZGRpX3RyYW5zbGF0aW9ucyA9IHNrbF95X2RkaV90cmFuc2xhdGlvbnNfaGRt aTsKPiAgCQkqbl9lbnRyaWVzID0gQVJSQVlfU0laRShza2xfeV9kZGlfdHJhbnNsYXRpb25zX2hk bWkpOwo+ICsJCXJldHVybiBza2xfeV9kZGlfdHJhbnNsYXRpb25zX2hkbWk7Cj4gIAl9IGVsc2Ug ewo+IC0JCWRkaV90cmFuc2xhdGlvbnMgPSBza2xfZGRpX3RyYW5zbGF0aW9uc19oZG1pOwo+ICAJ CSpuX2VudHJpZXMgPSBBUlJBWV9TSVpFKHNrbF9kZGlfdHJhbnNsYXRpb25zX2hkbWkpOwo+ICsJ CXJldHVybiBza2xfZGRpX3RyYW5zbGF0aW9uc19oZG1pOwo+ICAJfQo+IC0KPiAtCXJldHVybiBk ZGlfdHJhbnNsYXRpb25zOwo+ICB9Cj4gIAo+ICAvKgo+IC0tIAo+IDIuNC4xMAo+IAo+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVs IFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cu ZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK