Re: [PATCH 11/15] drm/i915: Explicitly use ddi bug trans entry 9 for hdmi

[Daniel Vetter <daniel@ffwll.ch>]

On Tue, Dec 08, 2015 at 07:59:46PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> When the DDI port is in HDMI/DVI mode, it automagically uses the buffer
> translations values from entry 9. Let's make that explicit in the code.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Or WARN_ON(i != 9); Either way don't see that much benefit, but I guess
won't hurt either. Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 5f008f0fdc13..f812607045d6 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -516,9 +516,9 @@ void intel_prepare_ddi_buffers(struct intel_encoder *encoder)
>  		hdmi_level = hdmi_default_entry;
>  
>  	/* Entry 9 is for HDMI: */
> -	I915_WRITE(DDI_BUF_TRANS_LO(port, i),
> +	I915_WRITE(DDI_BUF_TRANS_LO(port, 9),
>  		   ddi_translations_hdmi[hdmi_level].trans1 | iboost_bit);
> -	I915_WRITE(DDI_BUF_TRANS_HI(port, i),
> +	I915_WRITE(DDI_BUF_TRANS_HI(port, 9),
>  		   ddi_translations_hdmi[hdmi_level].trans2);
>  }
>  
> -- 
> 2.4.10
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx