From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: Don't leak connector state on SDVO init failure Date: Thu, 10 Dec 2015 15:14:38 +0100 Message-ID: <20151210141438.GR20822@phenom.ffwll.local> References: <1449614932-20258-1-git-send-email-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by gabe.freedesktop.org (Postfix) with ESMTPS id 32EAB6E4C0 for ; Thu, 10 Dec 2015 06:14:42 -0800 (PST) Received: by mail-wm0-f51.google.com with SMTP id v187so35204617wmv.1 for ; Thu, 10 Dec 2015 06:14:42 -0800 (PST) Content-Disposition: inline In-Reply-To: <1449614932-20258-1-git-send-email-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBEZWMgMDgsIDIwMTUgYXQgMDI6NDg6NTFQTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBJbiBhbGwgb2Ygb3VyIHZhcmlvdXMgU0RWTyBzZXR1cCBmdW5jdGlvbnMsIHdlIGFsbG9j YXRlIGFuIFNEVk8KPiBjb25uZWN0b3IgKGFsb25nIHdpdGggYW4gYXNzb2NpYXRlZCBjb25uZWN0 b3ItPnN0YXRlKSBvYmplY3QsIHRoZW4KPiBwZXJmb3JtIGluaXRpYWxpemF0aW9uLiAgSWYgdGhh dCBpbml0aWFsaXphdGlvbiBmYWlscywgd2UgbmVlZCB0byBtYWtlCj4gc3VyZSB0byBmcmVlIHRo ZSBzdGF0ZSBvYmplY3QgYXMgd2VsbCBhcyB0aGUgY29ubmVjdG9yLgo+IAo+IFNpZ25lZC1vZmYt Ynk6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+CgpXaGVyZSBkbyB3ZSBh bGxvYyBjb25uZWN0b3ItPnN0YXRlIGluIHNkdm9fY29ubmVjdG9yX2luaXQoKT8gSSB0aG91Z2h0 IHRoZQpmbG93IGlzIDEpIHJlZ2lzdGVyIGFsbCB0aGUga21zIG9iamVjdHMgd2l0aCBvdXIgcGls ZSBvZiBfaW5pdCgpIGZ1bmN0aW9ucwoyKSBkbyBodyByZWFkb3V0LCB3aGljaCBpcyB0aGUgdGhp bmcgd2hpY2ggY3JlYXRlcyBhbGwgdGhlc2Ugc3RhdGVzLgoKTm9uZSBvZiB0aGUgb3RoZXIgY29u bmVjdG9ycyBzZWVtIHRvIGhhdmUgdGhpcyBpc3N1ZSAob3IgYXQgbGVhc3QgSSBkb24ndApzZWUg YSBwYXRjaCBmb3IgdGhlbSkuCi1EYW5pZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3Nkdm8uYyB8IDggKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0aW9u cygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMKPiBpbmRleCAwNjY3OWYxLi5mZjI4 ODY3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nkdm8uYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nkdm8uYwo+IEBAIC0yNDc5LDYgKzI0Nzks OCBAQCBpbnRlbF9zZHZvX2R2aV9pbml0KHN0cnVjdCBpbnRlbF9zZHZvICppbnRlbF9zZHZvLCBp bnQgZGV2aWNlKQo+ICAJfQo+ICAKPiAgCWlmIChpbnRlbF9zZHZvX2Nvbm5lY3Rvcl9pbml0KGlu dGVsX3Nkdm9fY29ubmVjdG9yLCBpbnRlbF9zZHZvKSA8IDApIHsKPiArCQlkcm1fYXRvbWljX2hl bHBlcl9jb25uZWN0b3JfZGVzdHJveV9zdGF0ZShjb25uZWN0b3IsCj4gKwkJCQkJCQkgIGNvbm5l Y3Rvci0+c3RhdGUpOwo+ICAJCWtmcmVlKGludGVsX3Nkdm9fY29ubmVjdG9yKTsKPiAgCQlyZXR1 cm4gZmFsc2U7Cj4gIAl9Cj4gQEAgLTI1MTQsNiArMjUxNiw4IEBAIGludGVsX3Nkdm9fdHZfaW5p dChzdHJ1Y3QgaW50ZWxfc2R2byAqaW50ZWxfc2R2bywgaW50IHR5cGUpCj4gIAlpbnRlbF9zZHZv LT5pc190diA9IHRydWU7Cj4gIAo+ICAJaWYgKGludGVsX3Nkdm9fY29ubmVjdG9yX2luaXQoaW50 ZWxfc2R2b19jb25uZWN0b3IsIGludGVsX3Nkdm8pIDwgMCkgewo+ICsJCWRybV9hdG9taWNfaGVs cGVyX2Nvbm5lY3Rvcl9kZXN0cm95X3N0YXRlKGNvbm5lY3RvciwKPiArCQkJCQkJCSAgY29ubmVj dG9yLT5zdGF0ZSk7Cj4gIAkJa2ZyZWUoaW50ZWxfc2R2b19jb25uZWN0b3IpOwo+ICAJCXJldHVy biBmYWxzZTsKPiAgCX0KPiBAQCAtMjU2MSw2ICsyNTY1LDggQEAgaW50ZWxfc2R2b19hbmFsb2df aW5pdChzdHJ1Y3QgaW50ZWxfc2R2byAqaW50ZWxfc2R2bywgaW50IGRldmljZSkKPiAgCX0KPiAg Cj4gIAlpZiAoaW50ZWxfc2R2b19jb25uZWN0b3JfaW5pdChpbnRlbF9zZHZvX2Nvbm5lY3Rvciwg aW50ZWxfc2R2bykgPCAwKSB7Cj4gKwkJZHJtX2F0b21pY19oZWxwZXJfY29ubmVjdG9yX2Rlc3Ry b3lfc3RhdGUoY29ubmVjdG9yLAo+ICsJCQkJCQkJICBjb25uZWN0b3ItPnN0YXRlKTsKPiAgCQlr ZnJlZShpbnRlbF9zZHZvX2Nvbm5lY3Rvcik7Cj4gIAkJcmV0dXJuIGZhbHNlOwo+ICAJfQo+IEBA IC0yNTk2LDYgKzI2MDIsOCBAQCBpbnRlbF9zZHZvX2x2ZHNfaW5pdChzdHJ1Y3QgaW50ZWxfc2R2 byAqaW50ZWxfc2R2bywgaW50IGRldmljZSkKPiAgCX0KPiAgCj4gIAlpZiAoaW50ZWxfc2R2b19j b25uZWN0b3JfaW5pdChpbnRlbF9zZHZvX2Nvbm5lY3RvciwgaW50ZWxfc2R2bykgPCAwKSB7Cj4g KwkJZHJtX2F0b21pY19oZWxwZXJfY29ubmVjdG9yX2Rlc3Ryb3lfc3RhdGUoY29ubmVjdG9yLAo+ ICsJCQkJCQkJICBjb25uZWN0b3ItPnN0YXRlKTsKPiAgCQlrZnJlZShpbnRlbF9zZHZvX2Nvbm5l Y3Rvcik7Cj4gIAkJcmV0dXJuIGZhbHNlOwo+ICAJfQo+IC0tIAo+IDIuMS40Cj4gCj4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFp bGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwg VmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5m ZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=