From: David Weinehall <david.weinehall@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] RFC: split PM workarounds into separate lib
Date: Thu, 10 Dec 2015 17:55:55 +0200 [thread overview]
Message-ID: <20151210155554.GA6509@boom> (raw)
In-Reply-To: <20151210100942.GP20822@phenom.ffwll.local>
On Thu, Dec 10, 2015 at 11:09:42AM +0100, Daniel Vetter wrote:
> On Tue, Dec 08, 2015 at 05:05:12PM -0200, Paulo Zanoni wrote:
> > 2015-12-08 11:42 GMT-02:00 Ville Syrjälä <ville.syrjala@linux.intel.com>:
> > > On Tue, Dec 08, 2015 at 10:50:39AM +0200, David Weinehall wrote:
> > >> Since the defaults for some external power management related settings
> > >> prevents us from testing our power management functionality properly,
> > >> we have to work around it. Currently this is done from the individual
> > >> test cases, but this is sub-optimal. This patch moves the PM-related
> > >> workarounds into a separate library, and adds some code to restore the
> > >> previous settings for the SATA link power management while at it.
> > >
> > > Why is it called "workarounds"? That gives me the impression we're
> > > working around something that's supposed to work but doesn't. That's not
> > > the case here.
> >
> > Well, in theory they could be considered workarounds since IMHO the
> > machine is supposed to be saving as much power as it can on an idle
> > state, but it isn't. But this more of a philosophical discussion and
> > we can debate forever.
> >
> > Anyway, if we rename the file to something like lib/igt_pm.c we'll be
> > able to move the residency-checking code and possibly more common
> > things there, so I'm not against the rename either.
>
> I like the ring of lib/igt_pm.c.
No reservations from me, igt_pm it is.
Kind regards, David
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-12-10 15:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 8:50 [PATCH i-g-t] RFC: split PM workarounds into separate lib David Weinehall
2015-12-08 8:50 ` [PATCH i-g-t] lib/pm_workarounds: Lib for PM workarounds David Weinehall
2015-12-08 13:22 ` [PATCH i-g-t] RFC: split PM workarounds into separate lib Zanoni, Paulo R
2015-12-10 16:05 ` David Weinehall
2015-12-08 13:42 ` Ville Syrjälä
2015-12-08 19:05 ` Paulo Zanoni
2015-12-10 10:09 ` Daniel Vetter
2015-12-10 15:55 ` David Weinehall [this message]
2015-12-10 16:01 ` David Weinehall
2015-12-11 17:03 ` Daniel Vetter
2015-12-15 9:14 ` [PATCH i-g-t v2] Add a lib for power management helpers David Weinehall
2015-12-15 9:14 ` [PATCH i-g-t] lib/igt_pm: Lib for power management David Weinehall
2015-12-18 19:27 ` Thomas Wood
2016-02-11 7:25 ` [PATCH v3 0/1] Add a lib for power management helpers David Weinehall
2016-02-11 7:25 ` [PATCH v3 1/1] lib/igt_pm: Lib for power management David Weinehall
2016-02-11 8:27 ` [PATCH v3 0/1] Add a lib for power management helpers Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151210155554.GA6509@boom \
--to=david.weinehall@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).