From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matt Roper <matthew.d.roper@intel.com>
Subject: Re: [PATCH 1/2] drm/i915: Don't leak connector state on
 SDVO init failure
Date: Thu, 10 Dec 2015 17:57:57 -0800
Message-ID: <20151211015757.GA855@intel.com>
References: <1449614932-20258-1-git-send-email-matthew.d.roper@intel.com>
 <20151210141438.GR20822@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id 2294C6E532
 for <intel-gfx@lists.freedesktop.org>; Thu, 10 Dec 2015 17:57:58 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20151210141438.GR20822@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBEZWMgMTAsIDIwMTUgYXQgMDM6MTQ6MzhQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3
cm90ZToKPiBPbiBUdWUsIERlYyAwOCwgMjAxNSBhdCAwMjo0ODo1MVBNIC0wODAwLCBNYXR0IFJv
cGVyIHdyb3RlOgo+ID4gSW4gYWxsIG9mIG91ciB2YXJpb3VzIFNEVk8gc2V0dXAgZnVuY3Rpb25z
LCB3ZSBhbGxvY2F0ZSBhbiBTRFZPCj4gPiBjb25uZWN0b3IgKGFsb25nIHdpdGggYW4gYXNzb2Np
YXRlZCBjb25uZWN0b3ItPnN0YXRlKSBvYmplY3QsIHRoZW4KPiA+IHBlcmZvcm0gaW5pdGlhbGl6
YXRpb24uICBJZiB0aGF0IGluaXRpYWxpemF0aW9uIGZhaWxzLCB3ZSBuZWVkIHRvIG1ha2UKPiA+
IHN1cmUgdG8gZnJlZSB0aGUgc3RhdGUgb2JqZWN0IGFzIHdlbGwgYXMgdGhlIGNvbm5lY3Rvci4K
PiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVs
LmNvbT4KPiAKPiBXaGVyZSBkbyB3ZSBhbGxvYyBjb25uZWN0b3ItPnN0YXRlIGluIHNkdm9fY29u
bmVjdG9yX2luaXQoKT8gSSB0aG91Z2h0IHRoZQo+IGZsb3cgaXMgMSkgcmVnaXN0ZXIgYWxsIHRo
ZSBrbXMgb2JqZWN0cyB3aXRoIG91ciBwaWxlIG9mIF9pbml0KCkgZnVuY3Rpb25zCj4gMikgZG8g
aHcgcmVhZG91dCwgd2hpY2ggaXMgdGhlIHRoaW5nIHdoaWNoIGNyZWF0ZXMgYWxsIHRoZXNlIHN0
YXRlcy4KCkl0J3MgYWxsb2NhdGVkIGJ5IGludGVsX3Nkdm9fY29ubmVjdG9yX2FsbG9jIC0+IGlu
dGVsX2Nvbm5lY3Rvcl9pbml0CndoaWNoIGdldHMgcnVuIGJlZm9yZSBpbnRlbF9zZHZvX2Nvbm5l
Y3Rvcl9pbml0KCkgZXZlbiBnZXRzIGNhbGxlZC4KVGhlcmUgYXJlIHR3byBzZXBhcmF0ZSAiaW5p
dCIgZnVuY3Rpb25zIHRoYXQgZ2V0IGNhbGxlZCBmb3IgU0RWTwpjb25uZWN0b3JzLi4udGhlIGZp
cnN0IGFsbG9jYXRlcyB0aGUgc3RhdGUgb2JqZWN0LCBidXQgdGhlIHNlY29uZCBjYW4KZmFpbCB0
b28gYW5kIHRyaWdnZXIgY2xlYW51cCAod2hpY2ggd2FzIGZhaWxpbmcgdG8gZGVzdHJveSB0aGUg
c3RhdGUpLgoKPiAKPiBOb25lIG9mIHRoZSBvdGhlciBjb25uZWN0b3JzIHNlZW0gdG8gaGF2ZSB0
aGlzIGlzc3VlIChvciBhdCBsZWFzdCBJIGRvbid0Cj4gc2VlIGEgcGF0Y2ggZm9yIHRoZW0pLgoK
SSBkb24ndCB0aGluayBhbnkgb2YgdGhlIG90aGVyIGNvbm5lY3RvciB0eXBlcyBoYXZlIGEgc2Vj
b25kLCBzcGVjaWFsCmluaXQgZnVuY3Rpb24gdGhhdCBnZXRzIHJ1biBhZnRlciBpbnRlbF9jb25u
ZWN0b3JfaW5pdCgpIGlzIGZpbmlzaGVkCnRoYXQgSSBjYW4gc2VlLiAKCgpNYXR0Cgo+IC1EYW5p
ZWwKPiAKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nkdm8uYyB8IDgg
KysrKysrKysKPiA+ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspCj4gPiAKPiA+IGRp
ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMgYi9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMKPiA+IGluZGV4IDA2Njc5ZjEuLmZmMjg4NjcgMTAwNjQ0
Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMKPiA+ICsrKyBiL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nkdm8uYwo+ID4gQEAgLTI0NzksNiArMjQ3OSw4IEBA
IGludGVsX3Nkdm9fZHZpX2luaXQoc3RydWN0IGludGVsX3Nkdm8gKmludGVsX3Nkdm8sIGludCBk
ZXZpY2UpCj4gPiAgCX0KPiA+ICAKPiA+ICAJaWYgKGludGVsX3Nkdm9fY29ubmVjdG9yX2luaXQo
aW50ZWxfc2R2b19jb25uZWN0b3IsIGludGVsX3Nkdm8pIDwgMCkgewo+ID4gKwkJZHJtX2F0b21p
Y19oZWxwZXJfY29ubmVjdG9yX2Rlc3Ryb3lfc3RhdGUoY29ubmVjdG9yLAo+ID4gKwkJCQkJCQkg
IGNvbm5lY3Rvci0+c3RhdGUpOwo+ID4gIAkJa2ZyZWUoaW50ZWxfc2R2b19jb25uZWN0b3IpOwo+
ID4gIAkJcmV0dXJuIGZhbHNlOwo+ID4gIAl9Cj4gPiBAQCAtMjUxNCw2ICsyNTE2LDggQEAgaW50
ZWxfc2R2b190dl9pbml0KHN0cnVjdCBpbnRlbF9zZHZvICppbnRlbF9zZHZvLCBpbnQgdHlwZSkK
PiA+ICAJaW50ZWxfc2R2by0+aXNfdHYgPSB0cnVlOwo+ID4gIAo+ID4gIAlpZiAoaW50ZWxfc2R2
b19jb25uZWN0b3JfaW5pdChpbnRlbF9zZHZvX2Nvbm5lY3RvciwgaW50ZWxfc2R2bykgPCAwKSB7
Cj4gPiArCQlkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0b3JfZGVzdHJveV9zdGF0ZShjb25uZWN0
b3IsCj4gPiArCQkJCQkJCSAgY29ubmVjdG9yLT5zdGF0ZSk7Cj4gPiAgCQlrZnJlZShpbnRlbF9z
ZHZvX2Nvbm5lY3Rvcik7Cj4gPiAgCQlyZXR1cm4gZmFsc2U7Cj4gPiAgCX0KPiA+IEBAIC0yNTYx
LDYgKzI1NjUsOCBAQCBpbnRlbF9zZHZvX2FuYWxvZ19pbml0KHN0cnVjdCBpbnRlbF9zZHZvICpp
bnRlbF9zZHZvLCBpbnQgZGV2aWNlKQo+ID4gIAl9Cj4gPiAgCj4gPiAgCWlmIChpbnRlbF9zZHZv
X2Nvbm5lY3Rvcl9pbml0KGludGVsX3Nkdm9fY29ubmVjdG9yLCBpbnRlbF9zZHZvKSA8IDApIHsK
PiA+ICsJCWRybV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rvcl9kZXN0cm95X3N0YXRlKGNvbm5lY3Rv
ciwKPiA+ICsJCQkJCQkJICBjb25uZWN0b3ItPnN0YXRlKTsKPiA+ICAJCWtmcmVlKGludGVsX3Nk
dm9fY29ubmVjdG9yKTsKPiA+ICAJCXJldHVybiBmYWxzZTsKPiA+ICAJfQo+ID4gQEAgLTI1OTYs
NiArMjYwMiw4IEBAIGludGVsX3Nkdm9fbHZkc19pbml0KHN0cnVjdCBpbnRlbF9zZHZvICppbnRl
bF9zZHZvLCBpbnQgZGV2aWNlKQo+ID4gIAl9Cj4gPiAgCj4gPiAgCWlmIChpbnRlbF9zZHZvX2Nv
bm5lY3Rvcl9pbml0KGludGVsX3Nkdm9fY29ubmVjdG9yLCBpbnRlbF9zZHZvKSA8IDApIHsKPiA+
ICsJCWRybV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rvcl9kZXN0cm95X3N0YXRlKGNvbm5lY3RvciwK
PiA+ICsJCQkJCQkJICBjb25uZWN0b3ItPnN0YXRlKTsKPiA+ICAJCWtmcmVlKGludGVsX3Nkdm9f
Y29ubmVjdG9yKTsKPiA+ICAJCXJldHVybiBmYWxzZTsKPiA+ICAJfQo+ID4gLS0gCj4gPiAyLjEu
NAo+ID4gCj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
Xwo+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr
dG9wLm9yZwo+ID4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv
L2ludGVsLWdmeAo+IAo+IC0tIAo+IERhbmllbCBWZXR0ZXIKPiBTb2Z0d2FyZSBFbmdpbmVlciwg
SW50ZWwgQ29ycG9yYXRpb24KPiBodHRwOi8vYmxvZy5mZndsbC5jaAoKLS0gCk1hdHQgUm9wZXIK
R3JhcGhpY3MgU29mdHdhcmUgRW5naW5lZXIKSW9URyBQbGF0Zm9ybSBFbmFibGluZyAmIERldmVs
b3BtZW50CkludGVsIENvcnBvcmF0aW9uCig5MTYpIDM1Ni0yNzk1Cl9fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50
ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==