From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm/i915: Don't leak connector state on SDVO init failure Date: Fri, 11 Dec 2015 18:28:43 +0100 Message-ID: <20151211172843.GO20822@phenom.ffwll.local> References: <1449614932-20258-1-git-send-email-matthew.d.roper@intel.com> <20151210141438.GR20822@phenom.ffwll.local> <20151211015757.GA855@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by gabe.freedesktop.org (Postfix) with ESMTPS id BAE266E0CF for ; Fri, 11 Dec 2015 09:28:47 -0800 (PST) Received: by wmnn186 with SMTP id n186so41217433wmn.0 for ; Fri, 11 Dec 2015 09:28:46 -0800 (PST) Content-Disposition: inline In-Reply-To: <20151211015757.GA855@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBEZWMgMTAsIDIwMTUgYXQgMDU6NTc6NTdQTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBPbiBUaHUsIERlYyAxMCwgMjAxNSBhdCAwMzoxNDozOFBNICswMTAwLCBEYW5pZWwgVmV0 dGVyIHdyb3RlOgo+ID4gT24gVHVlLCBEZWMgMDgsIDIwMTUgYXQgMDI6NDg6NTFQTSAtMDgwMCwg TWF0dCBSb3BlciB3cm90ZToKPiA+ID4gSW4gYWxsIG9mIG91ciB2YXJpb3VzIFNEVk8gc2V0dXAg ZnVuY3Rpb25zLCB3ZSBhbGxvY2F0ZSBhbiBTRFZPCj4gPiA+IGNvbm5lY3RvciAoYWxvbmcgd2l0 aCBhbiBhc3NvY2lhdGVkIGNvbm5lY3Rvci0+c3RhdGUpIG9iamVjdCwgdGhlbgo+ID4gPiBwZXJm b3JtIGluaXRpYWxpemF0aW9uLiAgSWYgdGhhdCBpbml0aWFsaXphdGlvbiBmYWlscywgd2UgbmVl ZCB0byBtYWtlCj4gPiA+IHN1cmUgdG8gZnJlZSB0aGUgc3RhdGUgb2JqZWN0IGFzIHdlbGwgYXMg dGhlIGNvbm5lY3Rvci4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IE1hdHQgUm9wZXIgPG1h dHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gPiAKPiA+IFdoZXJlIGRvIHdlIGFsbG9jIGNvbm5l Y3Rvci0+c3RhdGUgaW4gc2R2b19jb25uZWN0b3JfaW5pdCgpPyBJIHRob3VnaHQgdGhlCj4gPiBm bG93IGlzIDEpIHJlZ2lzdGVyIGFsbCB0aGUga21zIG9iamVjdHMgd2l0aCBvdXIgcGlsZSBvZiBf aW5pdCgpIGZ1bmN0aW9ucwo+ID4gMikgZG8gaHcgcmVhZG91dCwgd2hpY2ggaXMgdGhlIHRoaW5n IHdoaWNoIGNyZWF0ZXMgYWxsIHRoZXNlIHN0YXRlcy4KPiAKPiBJdCdzIGFsbG9jYXRlZCBieSBp bnRlbF9zZHZvX2Nvbm5lY3Rvcl9hbGxvYyAtPiBpbnRlbF9jb25uZWN0b3JfaW5pdAo+IHdoaWNo IGdldHMgcnVuIGJlZm9yZSBpbnRlbF9zZHZvX2Nvbm5lY3Rvcl9pbml0KCkgZXZlbiBnZXRzIGNh bGxlZC4KPiBUaGVyZSBhcmUgdHdvIHNlcGFyYXRlICJpbml0IiBmdW5jdGlvbnMgdGhhdCBnZXQg Y2FsbGVkIGZvciBTRFZPCj4gY29ubmVjdG9ycy4uLnRoZSBmaXJzdCBhbGxvY2F0ZXMgdGhlIHN0 YXRlIG9iamVjdCwgYnV0IHRoZSBzZWNvbmQgY2FuCj4gZmFpbCB0b28gYW5kIHRyaWdnZXIgY2xl YW51cCAod2hpY2ggd2FzIGZhaWxpbmcgdG8gZGVzdHJveSB0aGUgc3RhdGUpLgoKQWggcmlnaHQs IGRpZG4ndCBmaW5kIHRoYXQuIFN0YXJ0ZWQgYSBmdWxsIGF1ZGl0IGJ1dCBzdHVjayBhdAppbnRl bF9kcF9pbml0LiBUaGF0IGhhcyBhIGtmcmVlKGludGVsX2Nvbm5lY3RvciksIGJ1dCBzZWVtcyB0 byBtaXNzIHRoaXMKdG9vLgoKT24gdGhlIHBhdGNoIGl0c2VsZjogQ2FuJ3Qgd2UganVzdCBjYWxs IGRybV9jb25uZWN0b3JfY2xlYW51cD8gQW5kIGFuCmludGVsX2Nvbm5lY3RvcmVfZnJlZSB3aGlj aCB3cmFwcyB0aGF0ICsgdGhlIGtmcmVlIHdvdWxkIGJlIG5pY2UuIFdlbGwsCnRoYXQgd291bGQg bWVhbiB3ZSdkIG5lZWQgdG8gbW92ZSBkcm1fY29ubmVjdG9yX2luaXQgaW50bwppbnRlbF9jb25u ZWN0b3JfaW5pdCwgYnV0IEkgdGhpbmsgdGhhdCB3b3VsZCBtYWtlIGEgbG90IG9mIHNlbnNlIGVp dGhlcgp3YXkuCi1EYW5pZWwKCj4gCj4gPiAKPiA+IE5vbmUgb2YgdGhlIG90aGVyIGNvbm5lY3Rv cnMgc2VlbSB0byBoYXZlIHRoaXMgaXNzdWUgKG9yIGF0IGxlYXN0IEkgZG9uJ3QKPiA+IHNlZSBh IHBhdGNoIGZvciB0aGVtKS4KPiAKPiBJIGRvbid0IHRoaW5rIGFueSBvZiB0aGUgb3RoZXIgY29u bmVjdG9yIHR5cGVzIGhhdmUgYSBzZWNvbmQsIHNwZWNpYWwKPiBpbml0IGZ1bmN0aW9uIHRoYXQg Z2V0cyBydW4gYWZ0ZXIgaW50ZWxfY29ubmVjdG9yX2luaXQoKSBpcyBmaW5pc2hlZAo+IHRoYXQg SSBjYW4gc2VlLiAKPiAKPiAKPiBNYXR0Cj4gCj4gPiAtRGFuaWVsCj4gPiAKPiA+ID4gLS0tCj4g PiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMgfCA4ICsrKysrKysrCj4gPiA+ ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2R2by5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfc2R2by5jCj4gPiA+IGluZGV4IDA2Njc5ZjEuLmZmMjg4NjcgMTAwNjQ0Cj4gPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nkdm8uYwo+ID4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zZHZvLmMKPiA+ID4gQEAgLTI0NzksNiArMjQ3OSw4IEBA IGludGVsX3Nkdm9fZHZpX2luaXQoc3RydWN0IGludGVsX3Nkdm8gKmludGVsX3Nkdm8sIGludCBk ZXZpY2UpCj4gPiA+ICAJfQo+ID4gPiAgCj4gPiA+ICAJaWYgKGludGVsX3Nkdm9fY29ubmVjdG9y X2luaXQoaW50ZWxfc2R2b19jb25uZWN0b3IsIGludGVsX3Nkdm8pIDwgMCkgewo+ID4gPiArCQlk cm1fYXRvbWljX2hlbHBlcl9jb25uZWN0b3JfZGVzdHJveV9zdGF0ZShjb25uZWN0b3IsCj4gPiA+ ICsJCQkJCQkJICBjb25uZWN0b3ItPnN0YXRlKTsKPiA+ID4gIAkJa2ZyZWUoaW50ZWxfc2R2b19j b25uZWN0b3IpOwo+ID4gPiAgCQlyZXR1cm4gZmFsc2U7Cj4gPiA+ICAJfQo+ID4gPiBAQCAtMjUx NCw2ICsyNTE2LDggQEAgaW50ZWxfc2R2b190dl9pbml0KHN0cnVjdCBpbnRlbF9zZHZvICppbnRl bF9zZHZvLCBpbnQgdHlwZSkKPiA+ID4gIAlpbnRlbF9zZHZvLT5pc190diA9IHRydWU7Cj4gPiA+ ICAKPiA+ID4gIAlpZiAoaW50ZWxfc2R2b19jb25uZWN0b3JfaW5pdChpbnRlbF9zZHZvX2Nvbm5l Y3RvciwgaW50ZWxfc2R2bykgPCAwKSB7Cj4gPiA+ICsJCWRybV9hdG9taWNfaGVscGVyX2Nvbm5l Y3Rvcl9kZXN0cm95X3N0YXRlKGNvbm5lY3RvciwKPiA+ID4gKwkJCQkJCQkgIGNvbm5lY3Rvci0+ c3RhdGUpOwo+ID4gPiAgCQlrZnJlZShpbnRlbF9zZHZvX2Nvbm5lY3Rvcik7Cj4gPiA+ICAJCXJl dHVybiBmYWxzZTsKPiA+ID4gIAl9Cj4gPiA+IEBAIC0yNTYxLDYgKzI1NjUsOCBAQCBpbnRlbF9z ZHZvX2FuYWxvZ19pbml0KHN0cnVjdCBpbnRlbF9zZHZvICppbnRlbF9zZHZvLCBpbnQgZGV2aWNl KQo+ID4gPiAgCX0KPiA+ID4gIAo+ID4gPiAgCWlmIChpbnRlbF9zZHZvX2Nvbm5lY3Rvcl9pbml0 KGludGVsX3Nkdm9fY29ubmVjdG9yLCBpbnRlbF9zZHZvKSA8IDApIHsKPiA+ID4gKwkJZHJtX2F0 b21pY19oZWxwZXJfY29ubmVjdG9yX2Rlc3Ryb3lfc3RhdGUoY29ubmVjdG9yLAo+ID4gPiArCQkJ CQkJCSAgY29ubmVjdG9yLT5zdGF0ZSk7Cj4gPiA+ICAJCWtmcmVlKGludGVsX3Nkdm9fY29ubmVj dG9yKTsKPiA+ID4gIAkJcmV0dXJuIGZhbHNlOwo+ID4gPiAgCX0KPiA+ID4gQEAgLTI1OTYsNiAr MjYwMiw4IEBAIGludGVsX3Nkdm9fbHZkc19pbml0KHN0cnVjdCBpbnRlbF9zZHZvICppbnRlbF9z ZHZvLCBpbnQgZGV2aWNlKQo+ID4gPiAgCX0KPiA+ID4gIAo+ID4gPiAgCWlmIChpbnRlbF9zZHZv X2Nvbm5lY3Rvcl9pbml0KGludGVsX3Nkdm9fY29ubmVjdG9yLCBpbnRlbF9zZHZvKSA8IDApIHsK PiA+ID4gKwkJZHJtX2F0b21pY19oZWxwZXJfY29ubmVjdG9yX2Rlc3Ryb3lfc3RhdGUoY29ubmVj dG9yLAo+ID4gPiArCQkJCQkJCSAgY29ubmVjdG9yLT5zdGF0ZSk7Cj4gPiA+ICAJCWtmcmVlKGlu dGVsX3Nkdm9fY29ubmVjdG9yKTsKPiA+ID4gIAkJcmV0dXJuIGZhbHNlOwo+ID4gPiAgCX0KPiA+ ID4gLS0gCj4gPiA+IDIuMS40Cj4gPiA+IAo+ID4gPiBfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwo+ID4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiA+ IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ID4gaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+ID4gCj4gPiAtLSAKPiA+IERh bmllbCBWZXR0ZXIKPiA+IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+ID4g aHR0cDovL2Jsb2cuZmZ3bGwuY2gKPiAKPiAtLSAKPiBNYXR0IFJvcGVyCj4gR3JhcGhpY3MgU29m dHdhcmUgRW5naW5lZXIKPiBJb1RHIFBsYXRmb3JtIEVuYWJsaW5nICYgRGV2ZWxvcG1lbnQKPiBJ bnRlbCBDb3Jwb3JhdGlvbgo+ICg5MTYpIDM1Ni0yNzk1CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0 d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK