From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 5/6] drm/i915: Support for pread/pwrite from/to non shmem backed objects Date: Fri, 11 Dec 2015 19:15:41 +0100 Message-ID: <20151211181541.GQ20822@phenom.ffwll.local> References: <1449665182-10054-1-git-send-email-ankitprasad.r.sharma@intel.com> <1449665182-10054-6-git-send-email-ankitprasad.r.sharma@intel.com> <56685395.8040806@linux.intel.com> <5668838C.6060101@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id BAD036E0AF for ; Fri, 11 Dec 2015 10:15:45 -0800 (PST) Received: by mail-wm0-f44.google.com with SMTP id c17so21335873wmd.1 for ; Fri, 11 Dec 2015 10:15:45 -0800 (PST) Content-Disposition: inline In-Reply-To: <5668838C.6060101@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Gordon Cc: intel-gfx@lists.freedesktop.org, shashidhar.hiremath@intel.com, akash.goel@intel.com, ankitprasad.r.sharma@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBEZWMgMDksIDIwMTUgYXQgMDc6Mzk6NTZQTSArMDAwMCwgRGF2ZSBHb3Jkb24gd3Jv dGU6Cj4gT24gMDkvMTIvMTUgMTY6MTUsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+ID4KPiA+SGks Cj4gPgo+ID5PbiAwOS8xMi8xNSAxMjo0NiwgYW5raXRwcmFzYWQuci5zaGFybWFAaW50ZWwuY29t IHdyb3RlOgo+ID4+RnJvbTogQW5raXRwcmFzYWQgU2hhcm1hIDxhbmtpdHByYXNhZC5yLnNoYXJt YUBpbnRlbC5jb20+Cj4gPj4KPiA+PlRoaXMgcGF0Y2ggYWRkcyBzdXBwb3J0IGZvciBleHRlbmRp bmcgdGhlIHByZWFkL3B3cml0ZSBmdW5jdGlvbmFsaXR5Cj4gPj5mb3Igb2JqZWN0cyBub3QgYmFj a2VkIGJ5IHNobWVtLiBUaGUgYWNjZXNzIHdpbGwgYmUgbWFkZSB0aHJvdWdoCj4gPj5ndHQgaW50 ZXJmYWNlLiBUaGlzIHdpbGwgY292ZXIgb2JqZWN0cyBiYWNrZWQgYnkgc3RvbGVuIG1lbW9yeSBh cyB3ZWxsCj4gPj5hcyBvdGhlciBub24tc2htZW0gYmFja2VkIG9iamVjdHMuCj4gPj4KPiA+PnYy OiBEcm9wIGxvY2tzIGFyb3VuZCBzbG93X3VzZXJfYWNjZXNzLCBwcmVmYXVsdCB0aGUgcGFnZXMg YmVmb3JlCj4gPj5hY2Nlc3MgKENocmlzKQo+ID4+Cj4gPj52MzogUmViYXNlZCB0byB0aGUgbGF0 ZXN0IGRybS1pbnRlbC1uaWdodGx5IChBbmtpdCkKPiA+Pgo+ID4+djQ6IE1vdmVkIHBhZ2UgYmFz ZSAmIG9mZnNldCBjYWxjdWxhdGlvbnMgb3V0c2lkZSB0aGUgY29weSBsb29wLAo+ID4+Y29ycmVj dGVkIGRhdGEgdHlwZXMgZm9yIHNpemUgYW5kIG9mZnNldCB2YXJpYWJsZXMsIGNvcnJlY3RlZCBp Zi1lbHNlCj4gPj5icmFjZXMgZm9ybWF0IChUdnJ0a28va2VybmVsZG9jcykKPiA+Pgo+ID4+djU6 IEVuYWJsZWQgcHJlYWQvcHdyaXRlIGZvciBhbGwgbm9uLXNobWVtIGJhY2tlZCBvYmplY3RzIGlu Y2x1ZGluZwo+ID4+d2l0aG91dCB0aWxpbmcgcmVzdHJpY3Rpb25zIChBbmtpdCkKPiA+Pgo+ID4+ djY6IFVzaW5nIHB3cml0ZV9mYXN0IGZvciBub24tc2htZW0gYmFja2VkIG9iamVjdHMgYXMgd2Vs bCAoQ2hyaXMpCj4gPj4KPiA+PnY3OiBVcGRhdGVkIGNvbW1pdCBtZXNzYWdlLCBSZW5hbWVkIGk5 MTVfZ2VtX2d0dF9yZWFkIHRvCj4gPj5pOTE1X2dlbV9ndHRfY29weSwKPiA+PmFkZGVkIHB3cml0 ZSBzbG93IHBhdGggZm9yIG5vbi1zaG1lbSBiYWNrZWQgb2JqZWN0cyAoQ2hyaXMvVHZydGtvKQo+ ID4+Cj4gPj52ODogVXBkYXRlZCB2NyBjb21taXQgbWVzc2FnZSwgbXV0ZXggdW5sb2NrIGFyb3Vu ZCBwd3JpdGUgc2xvdyBwYXRoIGZvcgo+ID4+bm9uLXNobWVtIGJhY2tlZCBvYmplY3RzIChUdnJ0 a28pCj4gPj4KPiA+PlRlc3RjYXNlOiBpZ3QvZ2VtX3N0b2xlbgo+ID4+Cj4gPj5TaWduZWQtb2Zm LWJ5OiBBbmtpdHByYXNhZCBTaGFybWEgPGFua2l0cHJhc2FkLnIuc2hhcm1hQGludGVsLmNvbT4K PiA+Pi0tLQo+ID4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIHwgMTUxCj4gPj4r KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tCj4gPj4gIDEgZmlsZSBjaGFu Z2VkLCAxMjcgaW5zZXJ0aW9ucygrKSwgMjQgZGVsZXRpb25zKC0pCj4gPj4KPiA+PmRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPj5iL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMKPiA+PmluZGV4IGVkOTdkZTYuLjY4ZWQ2N2EgMTAwNjQ0Cj4gPj4t LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPj4rKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPj5AQCAtNjE0LDYgKzYxNCw5OSBAQCBzaG1lbV9wcmVh ZF9zbG93KHN0cnVjdCBwYWdlICpwYWdlLCBpbnQKPiA+PnNobWVtX3BhZ2Vfb2Zmc2V0LCBpbnQg cGFnZV9sZW5ndGgsCj4gPj4gICAgICByZXR1cm4gcmV0ID8gLSBFRkFVTFQgOiAwOwo+ID4+ICB9 Cj4gPj4KPiA+PitzdGF0aWMgaW5saW5lIHVpbnQ2NF90Cj4gPj4rc2xvd191c2VyX2FjY2Vzcyhz dHJ1Y3QgaW9fbWFwcGluZyAqbWFwcGluZywKPiA+PisgICAgICAgICB1aW50NjRfdCBwYWdlX2Jh c2UsIGludCBwYWdlX29mZnNldCwKPiA+PisgICAgICAgICBjaGFyIF9fdXNlciAqdXNlcl9kYXRh LAo+ID4+KyAgICAgICAgIGludCBsZW5ndGgsIGJvb2wgcHdyaXRlKQo+ID4+K3sKPiA+PisgICAg dm9pZCBfX2lvbWVtICp2YWRkcl9pbmF0b21pYzsKPiA+PisgICAgdm9pZCAqdmFkZHI7Cj4gPj4r ICAgIHVpbnQ2NF90IHVud3JpdHRlbjsKPiA+PisKPiA+PisgICAgdmFkZHJfaW5hdG9taWMgPSBp b19tYXBwaW5nX21hcF93YyhtYXBwaW5nLCBwYWdlX2Jhc2UpOwo+ID4+KyAgICAvKiBXZSBjYW4g dXNlIHRoZSBjcHUgbWVtIGNvcHkgZnVuY3Rpb24gYmVjYXVzZSB0aGlzIGlzIFg4Ni4gKi8KPiA+ PisgICAgdmFkZHIgPSAodm9pZCBfX2ZvcmNlICopdmFkZHJfaW5hdG9taWMgKyBwYWdlX29mZnNl dDsKPiA+PisgICAgaWYgKHB3cml0ZSkKPiA+PisgICAgICAgIHVud3JpdHRlbiA9IF9fY29weV9m cm9tX3VzZXIodmFkZHIsIHVzZXJfZGF0YSwgbGVuZ3RoKTsKPiA+PisgICAgZWxzZQo+ID4+KyAg ICAgICAgdW53cml0dGVuID0gX19jb3B5X3RvX3VzZXIodXNlcl9kYXRhLCB2YWRkciwgbGVuZ3Ro KTsKPiA+PisKPiA+PisgICAgaW9fbWFwcGluZ191bm1hcCh2YWRkcl9pbmF0b21pYyk7Cj4gPj4r ICAgIHJldHVybiB1bndyaXR0ZW47Cj4gPj4rfQo+ID4+Kwo+ID4+K3N0YXRpYyBpbnQKPiA+Pitp OTE1X2dlbV9ndHRfY29weShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4+KyAgICAgICAgICAg c3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwgdWludDY0X3Qgc2l6ZSwKPiA+PisgICAg ICAgICAgIHVpbnQ2NF90IGRhdGFfb2Zmc2V0LCB1aW50NjRfdCBkYXRhX3B0cikKPiA+Pit7Cj4g Pj4rICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZh dGU7Cj4gPj4rICAgIGNoYXIgX191c2VyICp1c2VyX2RhdGE7Cj4gPj4rICAgIHVpbnQ2NF90IHJl bWFpbjsKPiA+PisgICAgdWludDY0X3Qgb2Zmc2V0LCBwYWdlX2Jhc2U7Cj4gPj4rICAgIGludCBw YWdlX29mZnNldCwgcGFnZV9sZW5ndGgsIHJldCA9IDA7Cj4gPj4rCj4gPj4rICAgIHJldCA9IGk5 MTVfZ2VtX29ial9nZ3R0X3BpbihvYmosIDAsIFBJTl9NQVBQQUJMRSk7Cj4gPj4rICAgIGlmIChy ZXQpCj4gPj4rICAgICAgICBnb3RvIG91dDsKPiA+PisKPiA+PisgICAgcmV0ID0gaTkxNV9nZW1f b2JqZWN0X3NldF90b19ndHRfZG9tYWluKG9iaiwgZmFsc2UpOwo+ID4+KyAgICBpZiAocmV0KQo+ ID4+KyAgICAgICAgZ290byBvdXRfdW5waW47Cj4gPj4rCj4gPj4rICAgIHJldCA9IGk5MTVfZ2Vt X29iamVjdF9wdXRfZmVuY2Uob2JqKTsKPiA+PisgICAgaWYgKHJldCkKPiA+PisgICAgICAgIGdv dG8gb3V0X3VucGluOwo+ID4+Kwo+ID4+KyAgICB1c2VyX2RhdGEgPSB0b191c2VyX3B0cihkYXRh X3B0cik7Cj4gPj4rICAgIHJlbWFpbiA9IHNpemU7Cj4gPj4rICAgIG9mZnNldCA9IGk5MTVfZ2Vt X29ial9nZ3R0X29mZnNldChvYmopICsgZGF0YV9vZmZzZXQ7Cj4gPj4rCj4gPj4rICAgIG11dGV4 X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ID4+KyAgICBpZiAobGlrZWx5KCFpOTE1LnBy ZWZhdWx0X2Rpc2FibGUpKQo+ID4+KyAgICAgICAgcmV0ID0gZmF1bHRfaW5fbXVsdGlwYWdlc193 cml0ZWFibGUodXNlcl9kYXRhLCByZW1haW4pOwo+ID4+Kwo+ID4+KyAgICAvKgo+ID4+KyAgICAg KiBwYWdlX29mZnNldCA9IG9mZnNldCB3aXRoaW4gcGFnZQo+ID4+KyAgICAgKiBwYWdlX2Jhc2Ug PSBwYWdlIG9mZnNldCB3aXRoaW4gYXBlcnR1cmUKPiA+PisgICAgICovCj4gPj4rICAgIHBhZ2Vf b2Zmc2V0ID0gb2Zmc2V0X2luX3BhZ2Uob2Zmc2V0KTsKPiA+PisgICAgcGFnZV9iYXNlID0gb2Zm c2V0ICYgUEFHRV9NQVNLOwo+ID4+Kwo+ID4+KyAgICB3aGlsZSAocmVtYWluID4gMCkgewo+ID4+ KyAgICAgICAgLyogcGFnZV9sZW5ndGggPSBieXRlcyB0byBjb3B5IGZvciB0aGlzIHBhZ2UgKi8K PiA+PisgICAgICAgIHBhZ2VfbGVuZ3RoID0gcmVtYWluOwo+ID4+KyAgICAgICAgaWYgKChwYWdl X29mZnNldCArIHJlbWFpbikgPiBQQUdFX1NJWkUpCj4gPj4rICAgICAgICAgICAgcGFnZV9sZW5n dGggPSBQQUdFX1NJWkUgLSBwYWdlX29mZnNldDsKPiA+PisKPiA+PisgICAgICAgIC8qIFRoaXMg aXMgYSBzbG93IHJlYWQvd3JpdGUgYXMgaXQgdHJpZXMgdG8gcmVhZCBmcm9tCj4gPj4rICAgICAg ICAgKiBhbmQgd3JpdGUgdG8gdXNlciBtZW1vcnkgd2hpY2ggbWF5IHJlc3VsdCBpbnRvIHBhZ2UK PiA+PisgICAgICAgICAqIGZhdWx0cwo+ID4+KyAgICAgICAgICovCj4gPj4rICAgICAgICByZXQg PSBzbG93X3VzZXJfYWNjZXNzKGRldl9wcml2LT5ndHQubWFwcGFibGUsIHBhZ2VfYmFzZSwKPiA+ PisgICAgICAgICAgICAgICAgICAgICAgIHBhZ2Vfb2Zmc2V0LCB1c2VyX2RhdGEsCj4gPj4rICAg ICAgICAgICAgICAgICAgICAgICBwYWdlX2xlbmd0aCwgZmFsc2UpOwo+ID4+Kwo+ID4+KyAgICAg ICAgaWYgKHJldCkgewo+ID4+KyAgICAgICAgICAgIHJldCA9IC1FRkFVTFQ7Cj4gPj4rICAgICAg ICAgICAgYnJlYWs7Cj4gPj4rICAgICAgICB9Cj4gPj4rCj4gPj4rICAgICAgICByZW1haW4gLT0g cGFnZV9sZW5ndGg7Cj4gPj4rICAgICAgICB1c2VyX2RhdGEgKz0gcGFnZV9sZW5ndGg7Cj4gPj4r ICAgICAgICBwYWdlX2Jhc2UgKz0gcGFnZV9sZW5ndGg7Cj4gPj4rICAgICAgICBwYWdlX29mZnNl dCA9IDA7Cj4gPj4rICAgIH0KPiA+PisKPiA+PisgICAgbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3Rf bXV0ZXgpOwo+ID4+Kwo+ID4+K291dF91bnBpbjoKPiA+PisgICAgaTkxNV9nZW1fb2JqZWN0X2dn dHRfdW5waW4ob2JqKTsKPiA+PitvdXQ6Cj4gPj4rICAgIHJldHVybiByZXQ7Cj4gPj4rfQo+ID4+ Kwo+ID4+ICBzdGF0aWMgaW50Cj4gPj4gIGk5MTVfZ2VtX3NobWVtX3ByZWFkKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsCj4gPj4gICAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVj dCAqb2JqLAo+ID4+QEAgLTczNywxNyArODMwLDE0IEBAIGk5MTVfZ2VtX3ByZWFkX2lvY3RsKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gPj52b2lkICpkYXRhLAo+ID4+ICAgICAgICAgIGdvdG8g b3V0Owo+ID4+ICAgICAgfQo+ID4+Cj4gPj4tICAgIC8qIHByaW1lIG9iamVjdHMgaGF2ZSBubyBi YWNraW5nIGZpbHAgdG8gR0VNIHByZWFkL3B3cml0ZQo+ID4+LSAgICAgKiBwYWdlcyBmcm9tLgo+ ID4+LSAgICAgKi8KPiA+Pi0gICAgaWYgKCFvYmotPmJhc2UuZmlscCkgewo+ID4+LSAgICAgICAg cmV0ID0gLUVJTlZBTDsKPiA+Pi0gICAgICAgIGdvdG8gb3V0Owo+ID4+LSAgICB9Cj4gPj4tCj4g Pj4gICAgICB0cmFjZV9pOTE1X2dlbV9vYmplY3RfcHJlYWQob2JqLCBhcmdzLT5vZmZzZXQsIGFy Z3MtPnNpemUpOwo+ID4+Cj4gPj4tICAgIHJldCA9IGk5MTVfZ2VtX3NobWVtX3ByZWFkKGRldiwg b2JqLCBhcmdzLCBmaWxlKTsKPiA+PisgICAgLyogcHJlYWQgZm9yIG5vbiBzaG1lbSBiYWNrZWQg b2JqZWN0cyAqLwo+ID4+KyAgICBpZiAoIW9iai0+YmFzZS5maWxwICYmIG9iai0+dGlsaW5nX21v ZGUgPT0gSTkxNV9USUxJTkdfTk9ORSkKPiA+PisgICAgICAgIHJldCA9IGk5MTVfZ2VtX2d0dF9j b3B5KGRldiwgb2JqLCBhcmdzLT5zaXplLAo+ID4+KyAgICAgICAgICAgICAgICAgICAgYXJncy0+ b2Zmc2V0LCBhcmdzLT5kYXRhX3B0cik7Cj4gPj4rICAgIGVsc2UKPiA+PisgICAgICAgIHJldCA9 IGk5MTVfZ2VtX3NobWVtX3ByZWFkKGRldiwgb2JqLCBhcmdzLCBmaWxlKTsKPiA+Cj4gPkhtLCBp dCB3aWxsIGVuZCB1cCBjYWxsaW5nIGk5MTVfZ2VtX3NobWVtX3ByZWFkIGZvciBub24tc2htZW0g YmFja2VkCj4gPm9iamVjdHMgaWYgdGlsaW5nIGlzIHNldC4gU291bmRzIHdyb25nIHRvIG1lIHVu bGVzcyBJIGFtIG1pc3Npbmcgc29tZXRoaW5nPwo+IAo+IFdoaWNoIEdFTSBvYmplY3RzIGhhdmUg b2JqLT5iYXNlLmZpbHAgc2V0PyBJcyBpdCBPTkxZIHJlZ3VsYXIgZ3R0LXR5cGUKCm9iai0+YmFz ZS5maWxwIGlzIGZvciBzaG1lbSBiYWNrZWQgc3R1ZmYuIGd0dCBpcyBpcnJlbGV2YW50IGZvciBi YWNraW5nCnN0b3JhZ2UsIHdlbGwgZXhjZXB0IGlmIHlvdSBjYW4ndCByZWFkIHRoZSBzaG1lbSBz dHVmZiBkaXJlY3RseSB3aXRoIHRoZQpjcHUgdGhlIG9ubHkgd2F5IGlzIHRvIGdvIHRocm91Z2gg YSBndHQgZGV2aWNlIG1hcHBpbmcuCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUg RW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==