From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 3/5] drm: Move more framebuffer doc from docbook to kerneldoc Date: Mon, 14 Dec 2015 16:58:13 +0100 Message-ID: <20151214155813.GC1998@ulmo> References: <1449564561-3896-1-git-send-email-daniel.vetter@ffwll.ch> <1449564561-3896-3-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0924644395==" Return-path: In-Reply-To: <1449564561-3896-3-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , Thierry Reding , DRI Development List-Id: intel-gfx@lists.freedesktop.org --===============0924644395== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eRtJSFbw+EEWtPj3" Content-Disposition: inline --eRtJSFbw+EEWtPj3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 08, 2015 at 09:49:19AM +0100, Daniel Vetter wrote: [...] > @@ -187,6 +189,9 @@ struct drm_framebuffer_funcs { > * copying the current screen contents to a private buffer and blending > * between that and the new contents. > * > + * GEM based drivers should call drm_gem_handle_create() to create the > + * handle. > + * > * RETURNS: > * > * 0 on success or a negative error code on failure. > @@ -1727,6 +1732,17 @@ struct drm_mode_config_funcs { > * requested metadata, but most of that is left to the driver. See > * struct &drm_mode_fb_cmd2 for details. > * > + * If the parameters are deemed valid and the backing storage objects in > + * the underlying memory manager all exists then the drivers to allocate "... all exist, then the driver allocates a new &drm_framebuffer structure ..."? > + * a new &drm_framebuffer structure, subclassed to contain > + * driver-specific information (like the internal native buffer object > + * references). It also needs to fill out all relevant metadata, which > + * should by done by calling drm_helper_mode_fill_fb_struct(). "should be done" > + * > + * The initializing is finalized by calling drm_framebuffer_init(), "The initialization" Other than that, looks good: Reviewed-by: Thierry Reding --eRtJSFbw+EEWtPj3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWbucTAAoJEN0jrNd/PrOh07sP/0cjCgjjAO/gGbJFPR2fPY28 dLZznCDw7P+jAZyMYMAIhMcq5p1kAkcZGIvMp0YfvxeEYntPD5OBalfxJkGoQ4ZG KizTOZY4qoeGH13OBCLfA/PFhNweJlncayLEJ8Wl/+ONPDuuSc2LkIaYLxuqlMbX te3b9oKZl6NgWNtSFRqg4rS7FAQ+KShoP8vfXCK0jidYhbr7+g+VNxSObKEZU6sW 1PFBDsyfuWKHhr4fdy198PuwM/IrEY1IOfnPS2UHATY7rPm7gPmCA0vlZxwX5fm2 1iViWlLaVzPinPhPxpyMwRKoxXOeZLGfbFY7DK6wlWRW50EE67ZjbBfaj4rkuo0s 5Ea12IZwQYcdjrOkzxUQ9aY3rnJmsHzkU9o6nEwAA+J4q/YzQGWy5qLXMtxjG4r8 ePvXyUsyle2r/ClRUdPYFqqJaM29op/gmaWFwKKNCKf3q5HatyTGmy1IjNflt7i8 KV0Bj/SKkW9z+D4bFaDcAMXpAd+ubJqQM4G5qHcGEy9MpM+Ph8yhJIQwK1msz9cp J6gXUoIkdtLoVf0ffUWWpZMxJ0Ho8fvFOsmAJhu0yAKw6/i2/hFJTQ049T7o4uEw we4yLWesywh7tCww2OwonqJ7L+9zLCQnyFYbhPuaaf0g53b6lFRHJI/uvBmGUhJe Aw3w+E/W2XmLL3Y/LiJC =X4Xb -----END PGP SIGNATURE----- --eRtJSFbw+EEWtPj3-- --===============0924644395== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============0924644395==--