Re: [PATCH 08/10] drm/i915: Expect child dev size of 22 bytes for VBT < 106

Jani Nikula
2015-12-16T08:58:29Z

On Mon, 14 Dec 2015, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> My 830 has VBT version 105 with child device size of 22 bytes.
> Let's assume that's correct and adjust our expectations.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Let's see what blows up...

Acked-by: Jani Nikula <jani.nikula@intel.com>

> ---
> drivers/gpu/drm/i915/intel_bios.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 770b825dabc0..c99a96989113 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -1089,7 +1089,9 @@ parse_device_mapping(struct drm_i915_private *dev_priv,
> DRM_DEBUG_KMS("No general definition block is found, no devices defined.\n");
> return;
> }
> - if (bdb->version < 109) {
> + if (bdb->version < 106) {
> + expected_size = 22;
> + } else if (bdb->version < 109) {
> expected_size = 27;
> } else if (bdb->version < 195) {
> BUILD_BUG_ON(sizeof(struct old_child_dev_config) != 33);

--
Jani Nikula, Intel Open Source Technology Center