Re: [PATCH 00/10] drm/i915: Fixes from my attempt at running igt on gen2

Daniel Vetter
2016-01-12T16:02:06Z

On Tue, Jan 12, 2016 at 04:54:27PM +0200, Ville Syrjälä wrote:
> On Mon, Dec 14, 2015 at 06:23:39PM +0200, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > It's been a while since I last ran igt on gen2, so I figured I'd
> > give it a shot. 855 had some failures, 830 no longer worked at
> > all. So I went ahead and fixed them, and here's the result.
> >
> > The first three patches are not even gen2 specific bugs I caught
> > with this effort. The rest is for gen2.
> >
> > I have some fixes for igt as well, which I'll post separately.
> >
> > The good news is that with these patches (and the igt fixes) my
> > 855 completes a full kms_flip run without failures, and the BAT
> > set has only one failure (gem_render_tiled_blits). 830 is fairly
> > good too, but it does have a lot of underruns and pipe_assert()
> > dmesg warnings. Lot of those are due to the pipe enable quirks
> > since we implement those quite haphazardly.
> >
> > The series is available here:
> > git://github.com/vsyrjala/linux.git gen2_igt_fixes
> >
> > Ville Syrjälä (10):
> > drm/i915: Cleanup phys status page too
> > drm/i915: Wait for pipe to start before sampling vblank timestamps on
> > gen2
> > drm/i915: Allow 27 bytes child_dev for VBT <109
> > drm/i915: Expect child dev size of 22 bytes for VBT < 106
> > drm/i915: Use MI_BATCH_BUFFER_START on 830/845
>
> Merged these. Thanks for the reviews.

CI seems extremely unhappy about your series. Haven't checked whether it's
something else or your stuff, but since we've decided last week that BAT
CI approval is required such a patch series shouldn't be merged any more.

Ok meanwhile I think since we're still just ramping up, but still.
-Daniel

>
> > drm/i915: Release mmaps on partial ggtt vma unbind
> > drm/i915: Write out crc frame counts in hex
> > drm/i915: Use drm_vblank_count() on gen2 for crc frame count
> > drm/i915: Enable vblank_disable_immediate on gen2
> > drm/i915: Reject < 8 byte batches on 830/845
>
> And at some point I'll need to figure out what to do with the
> rest. Some I'll just drop for sure.
>
> >
> > drivers/gpu/drm/i915/i915_debugfs.c | 13 ++++++++++++-
> > drivers/gpu/drm/i915/i915_gem.c | 3 +++
> > drivers/gpu/drm/i915/i915_gem_execbuffer.c | 3 +++
> > drivers/gpu/drm/i915/i915_irq.c | 14 +++++---------
> > drivers/gpu/drm/i915/intel_bios.c | 21 ++++++++++++--------
> > drivers/gpu/drm/i915/intel_display.c | 11 +++++++++++
> > drivers/gpu/drm/i915/intel_ringbuffer.c | 31 +++++++++++++++++++++++-------
> > 7 files changed, 71 insertions(+), 25 deletions(-)
> >
> > --
> > 2.4.10
>
> --
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation