From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 09/32] drm/i915: Prevent leaking of -EIO from i915_wait_request() Date: Wed, 16 Dec 2015 13:53:28 +0100 Message-ID: <20151216125328.GL30437@phenom.ffwll.local> References: <1449833608-22125-1-git-send-email-chris@chris-wilson.co.uk> <1449833608-22125-10-git-send-email-chris@chris-wilson.co.uk> <20151216095206.GR30437@phenom.ffwll.local> <20151216110620.GH6851@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 127676E8C6 for ; Wed, 16 Dec 2015 04:53:32 -0800 (PST) Received: by mail-wm0-f41.google.com with SMTP id l126so36691290wml.1 for ; Wed, 16 Dec 2015 04:53:32 -0800 (PST) Content-Disposition: inline In-Reply-To: <20151216110620.GH6851@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Daniel Vetter , intel-gfx@lists.freedesktop.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBEZWMgMTYsIDIwMTUgYXQgMTE6MDY6MjBBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIFdlZCwgRGVjIDE2LCAyMDE1IGF0IDEwOjUyOjA2QU0gKzAxMDAsIERhbmllbCBW ZXR0ZXIgd3JvdGU6Cj4gPiBPbiBGcmksIERlYyAxMSwgMjAxNSBhdCAxMTozMzowNUFNICswMDAw LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPiA+ID4gaW5kZXggZDdiYmQwMTVkZTM1Li44NzViZGY4MTRkNzMgMTAwNjQ0Cj4gPiA+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ID4gQEAgLTEzNDA1LDEwICsxMzQw NSw2IEBAIHN0YXRpYyBpbnQgaW50ZWxfYXRvbWljX3ByZXBhcmVfY29tbWl0KHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsCj4gPiA+ICAKPiA+ID4gIAkJCXJldCA9IF9faTkxNV93YWl0X3JlcXVlc3Qo aW50ZWxfcGxhbmVfc3RhdGUtPndhaXRfcmVxLAo+ID4gPiAgCQkJCQkJICB0cnVlLCBOVUxMLCBO VUxMKTsKPiA+ID4gLQo+ID4gPiAtCQkJLyogU3dhbGxvdyAtRUlPIGVycm9ycyB0byBhbGxvdyB1 cGRhdGVzIGR1cmluZyBodyBsb2NrdXAuICovCj4gPiA+IC0JCQlpZiAocmV0ID09IC1FSU8pCj4g PiAKPiA+IEknZCBsaWtlIHRvIGtlZXAgYSBXQVJOX09OIGhlcmUgc2luY2UgaXQncyBBQkkgcmVs ZXZhbnQsIGFuZCBjb25zaXN0ZW50Cj4gPiB3aXRoIHRoZSBvdGhlciBwbGFjZXMgd2UndmUgaGFk IGEgV0FSTl9PTigtRUlPKS4KPiA+IAo+ID4gPiAtCQkJCXJldCA9IDA7Cj4gPiA+ICAJCQlpZiAo cmV0KSB7Cj4gPiA+ICAJCQkJbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ID4gPiAg CQkJCWRybV9hdG9taWNfaGVscGVyX2NsZWFudXBfcGxhbmVzKGRldiwgc3RhdGUpOwo+ID4gPiBA QCAtMTM3NDQsOSArMTM3NDAsNyBAQCBpbnRlbF9wcmVwYXJlX3BsYW5lX2ZiKHN0cnVjdCBkcm1f cGxhbmUgKnBsYW5lLAo+ID4gPiAgCQkgKi8KPiA+ID4gIAkJaWYgKG5lZWRzX21vZGVzZXQoY3J0 Y19zdGF0ZSkpCj4gPiA+ICAJCQlyZXQgPSBpOTE1X2dlbV9vYmplY3Rfd2FpdF9yZW5kZXJpbmco b2xkX29iaiwgdHJ1ZSk7Cj4gPiA+IC0KPiA+ID4gLQkJLyogU3dhbGxvdyAtRUlPIGVycm9ycyB0 byBhbGxvdyB1cGRhdGVzIGR1cmluZyBodyBsb2NrdXAuICovCj4gPiA+IC0JCWlmIChyZXQgJiYg cmV0ICE9IC1FSU8pCj4gPiA+ICsJCWlmIChyZXQpCj4gPiAKPiA+IFNhbWUgaGVyZSByZWFsbHku Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDg3NWJkZjgxNGQ3 My4uMTU4NmQ5MTA3Y2JhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ IEBAIC0xMzQwNiw2ICsxMzQwNiw4IEBAIHN0YXRpYyBpbnQgaW50ZWxfYXRvbWljX3ByZXBhcmVf Y29tbWl0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gICAgICAgICAgICAgICAgICAgICAgICAg cmV0ID0gX19pOTE1X3dhaXRfcmVxdWVzdChpbnRlbF9wbGFuZV9zdGF0ZS0+d2FpdF9yZXEsCj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0cnVlLCBO VUxMLCBOVUxMKTsKPiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAocmV0KSB7Cj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAvKiBBbnkgaGFuZyBzaG91bGQgYmUgc3dhbGxvd2Vk IGJ5IHRoZSB3YWl0ICovCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBXQVJOX09O KHJldCA9PSAtRUlPKTsKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG11dGV4X2xv Y2soJmRldi0+c3RydWN0X211dGV4KTsKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGRybV9hdG9taWNfaGVscGVyX2NsZWFudXBfcGxhbmVzKGRldiwgc3RhdGUpOwo+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgbXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7 Cj4gQEAgLTEzNzQwLDggKzEzNzQyLDExIEBAIGludGVsX3ByZXBhcmVfcGxhbmVfZmIoc3RydWN0 IGRybV9wbGFuZSAqcGxhbmUsCj4gICAgICAgICAgICAgICAgICAqLwo+ICAgICAgICAgICAgICAg ICBpZiAobmVlZHNfbW9kZXNldChjcnRjX3N0YXRlKSkKPiAgICAgICAgICAgICAgICAgICAgICAg ICByZXQgPSBpOTE1X2dlbV9vYmplY3Rfd2FpdF9yZW5kZXJpbmcob2xkX29iaiwgdHJ1ZSk7Cj4g LSAgICAgICAgICAgICAgIGlmIChyZXQpCj4gKyAgICAgICAgICAgICAgIGlmIChyZXQpIHsKPiAr ICAgICAgICAgICAgICAgICAgICAgICAvKiBHUFUgaGFuZ3Mgc2hvdWxkIGhhdmUgYmVlbiBzd2Fs bG93ZWQgYnkgdGhlIHdhaXQgKi8KPiArICAgICAgICAgICAgICAgICAgICAgICBXQVJOX09OKHJl dCA9PSAtRUlPKTsKPiAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gcmV0Owo+ICsgICAg ICAgICAgICAgICB9Cj4gICAgICAgICB9Cj4gIAo+ICAgICAgICAgLyogRm9yIGZyYW1lYnVmZmVy IGJhY2tlZCBieSBkbWFidWYsIHdhaXQgZm9yIGZlbmNlICovCgpsZ3RtLgoKPiA+IFdlIGFscmVh ZHkgaGF2ZSBhIFdBUk5fT04gaW4gdGhlIG1taW9fZmxpcCwgc28gYXJlIGNvdmVyZWQgdGhlcmUg YWxyZWFkeS4KPiA+IAo+ID4gT3RoZXJ3aXNlIGxvb2tzIGdvb2QsIGFuZCB3aXRoIHRoZSBhYm92 ZSBhZGRyZXNzZWQgYW5kIHVuZGVyIHRoZQo+ID4gYXNzdW1wdGlvbiB0aGF0IHRoZSBsYXN0IGNh bGxlciBvZiBjaGVja193ZWRnZSBpcyBpbiByZXF1ZXN0X2FsbG9jICh3aGljaAo+ID4gSSB3YXMg dG9vIGxhenkgdG8gY2hlY2sgcGVyZmVjdGx5KToKPiAKPiBZZXMsIGxhdGVyIGl0IGlzIG1vdmVk IHRvIHRoZSBuZXcgaTkxNV9nZW1fcmVxdWVzdC5jIGFuZCBtYWRlIHN0YXRpYwo+IGFsb25nc2lk ZSBpdCdzIG9ubHkgY2FsbGVyIHJlcXVlc3RfYWxsb2MoKS4KClllYWgsIHItYiBjb25maXJtZWQg Oy0pCi1EYW5pZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENv cnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==