From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: Kalyan Kondapally <kalyan.kondapally@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/skl: Increase ddb blocks to support large cursor sizes
Date: Fri, 18 Dec 2015 17:34:26 +0200 [thread overview]
Message-ID: <20151218153426.GT4437@intel.com> (raw)
In-Reply-To: <20151218151417.GL2778@intel.com>
On Fri, Dec 18, 2015 at 07:14:17AM -0800, Matt Roper wrote:
> On Fri, Dec 18, 2015 at 05:10:12PM +0200, Ville Syrjälä wrote:
> > On Fri, Dec 18, 2015 at 06:58:58AM -0800, Matt Roper wrote:
> > > On Fri, Dec 18, 2015 at 12:35:47PM +0200, Ville Syrjälä wrote:
> > > > On Wed, Dec 16, 2015 at 07:06:20PM -0800, Radhakrishna Sripada wrote:
> > > > > Original value of 32 blocks is not sufficient when using cursor size of
> > > > > 256x256 causing FIFO underruns when the reworked wm
> > > > > caluclations in
> > > > >
> > > > > commit 024c9045221fe45482863c47c4b4c47d37f97cbf
> > > > > Author: Matt Roper <matthew.d.roper@intel.com>
> > > > > Date: Thu Sep 24 15:53:11 2015 -0700
> > > > >
> > > > > drm/i915/skl: Eliminate usage of pipe_wm_parameters from SKL-style WM (v4)
> > > >
> > > > Well that commit is obviously incorrect. It's now using the pipe src
> > > > width as the plane width for all planes.
> > > >
> > >
> > > Yeah, we already noted that bug in another email thread, but decided
> > > that it was unrelated to the problems Radhakrishna is facing.
> > > Radhakrishna is only using a cursor (which doesn't use that buggy
> > > function)
> >
> > Pop quiz: what does it use then?
>
> All non-cursor planes (i.e., primary+sprite). Cursors use a fixed DDB
> allocation (currently 32 blocks as suggested by bspec, but
> Radhakrishna's testing has found this to be too small, so his patch here
> is bumping that number up.
Oh I'm talking about the WM calculation, not the DDB allocation.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-12-18 15:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 3:06 [PATCH] drm/i915/skl: Increase ddb blocks to support large cursor sizes Radhakrishna Sripada
2015-12-18 10:01 ` Jani Nikula
2015-12-18 10:35 ` Ville Syrjälä
2015-12-18 14:58 ` Matt Roper
2015-12-18 15:10 ` Ville Syrjälä
2015-12-18 15:14 ` Matt Roper
2015-12-18 15:24 ` Matt Roper
2015-12-21 12:09 ` Daniel Vetter
2015-12-23 2:52 ` Kumar, Shobhit
2016-01-04 13:48 ` Kumar, Shobhit
2016-01-05 10:14 ` Daniel Vetter
2016-02-16 10:14 ` Kumar, Shobhit
2016-02-18 8:28 ` Kumar, Shobhit
2015-12-18 15:34 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151218153426.GT4437@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kalyan.kondapally@intel.com \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).