From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 03/32] drm/i915: Only spin whilst waiting on the current request Date: Fri, 18 Dec 2015 17:12:21 +0100 Message-ID: <20151218161221.GC30437@phenom.ffwll.local> References: <1449833608-22125-1-git-send-email-chris@chris-wilson.co.uk> <1449833608-22125-4-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 407966EAB9 for ; Fri, 18 Dec 2015 08:12:23 -0800 (PST) Received: by mail-wm0-f49.google.com with SMTP id l126so71691764wml.1 for ; Fri, 18 Dec 2015 08:12:23 -0800 (PST) Content-Disposition: inline In-Reply-To: <1449833608-22125-4-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, stable@vger.kernel.org, "Rantala, Valtteri" , Eero Tamminen List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBEZWMgMTEsIDIwMTUgYXQgMTE6MzI6NTlBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IExpbWl0IGJ1c3l3YWl0aW5nIG9ubHkgdG8gdGhlIHJlcXVlc3QgY3VycmVudGx5IGJl aW5nIHByb2Nlc3NlZCBieSB0aGUKPiBHUFUuIElmIHRoZSByZXF1ZXN0IGlzIG5vdCBjdXJyZW50 bHkgYmVpbmcgcHJvY2Vzc2VkIGJ5IHRoZSBHUFUsIHRoZXJlCj4gaXMgYSB2ZXJ5IGxvdyBsaWtl bGlob29kIG9mIGl0IGJlaW5nIGNvbXBsZXRlZCB3aXRoaW4gdGhlIDIgbWljcm9zZWNvbmQKPiBz cGluIHRpbWVvdXQgYW5kIHNvIHdlIHdpbGwganVzdCBiZSB3YXN0aW5nIENQVSBjeWNsZXMuCj4g Cj4gdjI6IENoZWNrIGZvciBsb2dpY2FsIGludmVyc2lvbiB3aGVuIHJlYmFzaW5nIC0gd2Ugd2Vy ZSBpbmNvcnJlY3RseQo+IGNoZWNraW5nIGZvciB0aGlzIHJlcXVlc3QgYmVpbmcgYWN0aXZlLCBh bmQgaW5zdGVhZCBidXN5d2FpdGluZyBmb3IKPiB3aGVuIHRoZSBHUFUgd2FzIG5vdCB5ZXQgcHJv Y2Vzc2luZyB0aGUgcmVxdWVzdCBvZiBpbnRlcmVzdC4KPiAKPiB2MzogVHJ5IGFub3RoZXIgY29s b3VyIGZvciB0aGUgc2Vxbm8gbmFtZXMuCj4gdjQ6IEFub3RoZXIgY29sb3VyIGZvciB0aGUgZnVu Y3Rpb24gbmFtZXMuCj4gCj4gdjU6IFJlbW92ZSB0aGUgZm9yY2VkIGNvaGVyZW5jeSB3aGVuIGNo ZWNraW5nIGZvciB0aGUgYWN0aXZlIHJlcXVlc3QuIE9uCj4gcmVmbGVjdGlvbiBhbmQgcGxlbnR5 IG9mIHJlY2VudCBleHBlcmltZW50YXRpb24sIHRoZSBpc3N1ZSBpcyBub3QgYQo+IGNhY2hlIGNv aGVyZW5jeSBwcm9ibGVtIC0gYnV0IGFuIGlycS9zZXFubyBvcmRlcmluZyBwcm9ibGVtICh0aW1p bmcgaXNzdWUpLgo+IEhlcmUsIHdlIGRvIG5vdCBuZWVkIHRoZSB3L2EgdG8gZm9yY2Ugb3JkZXJp bmcgb2YgdGhlIHJlYWQgd2l0aCBhbgo+IGludGVycnVwdC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBD aHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBSZXZpZXdlZC1ieTogVHZy dGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGxpbnV4LmludGVsLmNvbT4KPiBDYzogIlJvZ296 aGtpbiwgRG1pdHJ5IFYiIDxkbWl0cnkudi5yb2dvemhraW5AaW50ZWwuY29tPgo+IENjOiBEYW5p ZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8 dHZydGtvLnVyc3VsaW5AbGludXguaW50ZWwuY29tPgo+IENjOiBFZXJvIFRhbW1pbmVuIDxlZXJv LnQudGFtbWluZW5AaW50ZWwuY29tPgo+IENjOiAiUmFudGFsYSwgVmFsdHRlcmkiIDx2YWx0dGVy aS5yYW50YWxhQGludGVsLmNvbT4KPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwoKTWVyZ2Vk IHRoZXNlIDMgcGF0Y2hlcywgdGhhbmtzLgotRGFuaWVsCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5oIHwgMjcgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCAgOCArKysrKysrLQo+ICAyIGZpbGVzIGNo YW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5oCj4gaW5kZXggNWVkZDM5MzUyZTk3Li44YzQzMDNiNjY0ZDkgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMjE4Miw4ICsyMTgyLDE3IEBAIHN0cnVjdCBkcm1faTkx NV9nZW1fcmVxdWVzdCB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNTsKPiAgCXN0 cnVjdCBpbnRlbF9lbmdpbmVfY3MgKnJpbmc7Cj4gIAo+IC0JLyoqIEdFTSBzZXF1ZW5jZSBudW1i ZXIgYXNzb2NpYXRlZCB3aXRoIHRoaXMgcmVxdWVzdC4gKi8KPiAtCXVpbnQzMl90IHNlcW5vOwo+ ICsJIC8qKiBHRU0gc2VxdWVuY2UgbnVtYmVyIGFzc29jaWF0ZWQgd2l0aCB0aGUgcHJldmlvdXMg cmVxdWVzdCwKPiArCSAgKiB3aGVuIHRoZSBIV1MgYnJlYWRjcnVtYiBpcyBlcXVhbCB0byB0aGlz IHRoZSBHUFUgaXMgcHJvY2Vzc2luZwo+ICsJICAqIHRoaXMgcmVxdWVzdC4KPiArCSAgKi8KPiAr CXUzMiBwcmV2aW91c19zZXFubzsKPiArCj4gKwkgLyoqIEdFTSBzZXF1ZW5jZSBudW1iZXIgYXNz b2NpYXRlZCB3aXRoIHRoaXMgcmVxdWVzdCwKPiArCSAgKiB3aGVuIHRoZSBIV1MgYnJlYWRjcnVt YiBpcyBlcXVhbCBvciBncmVhdGVyIHRoYW4gdGhpcyB0aGUgR1BVCj4gKwkgICogaGFzIGZpbmlz aGVkIHByb2Nlc3NpbmcgdGhpcyByZXF1ZXN0Lgo+ICsJICAqLwo+ICsJdTMyIHNlcW5vOwo+ICAK PiAgCS8qKiBQb3NpdGlvbiBpbiB0aGUgcmluZ2J1ZmZlciBvZiB0aGUgc3RhcnQgb2YgdGhlIHJl cXVlc3QgKi8KPiAgCXUzMiBoZWFkOwo+IEBAIC0yOTU4LDE1ICsyOTY3LDE3IEBAIGk5MTVfc2Vx bm9fcGFzc2VkKHVpbnQzMl90IHNlcTEsIHVpbnQzMl90IHNlcTIpCj4gIAlyZXR1cm4gKGludDMy X3QpKHNlcTEgLSBzZXEyKSA+PSAwOwo+ICB9Cj4gIAo+ICtzdGF0aWMgaW5saW5lIGJvb2wgaTkx NV9nZW1fcmVxdWVzdF9zdGFydGVkKHN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxLAo+ ICsJCQkJCSAgIGJvb2wgbGF6eV9jb2hlcmVuY3kpCj4gK3sKPiArCXUzMiBzZXFubyA9IHJlcS0+ cmluZy0+Z2V0X3NlcW5vKHJlcS0+cmluZywgbGF6eV9jb2hlcmVuY3kpOwo+ICsJcmV0dXJuIGk5 MTVfc2Vxbm9fcGFzc2VkKHNlcW5vLCByZXEtPnByZXZpb3VzX3NlcW5vKTsKPiArfQo+ICsKPiAg c3RhdGljIGlubGluZSBib29sIGk5MTVfZ2VtX3JlcXVlc3RfY29tcGxldGVkKHN0cnVjdCBkcm1f aTkxNV9nZW1fcmVxdWVzdCAqcmVxLAo+ICAJCQkJCSAgICAgIGJvb2wgbGF6eV9jb2hlcmVuY3kp Cj4gIHsKPiAtCXUzMiBzZXFubzsKPiAtCj4gLQlCVUdfT04ocmVxID09IE5VTEwpOwo+IC0KPiAt CXNlcW5vID0gcmVxLT5yaW5nLT5nZXRfc2Vxbm8ocmVxLT5yaW5nLCBsYXp5X2NvaGVyZW5jeSk7 Cj4gLQo+ICsJdTMyIHNlcW5vID0gcmVxLT5yaW5nLT5nZXRfc2Vxbm8ocmVxLT5yaW5nLCBsYXp5 X2NvaGVyZW5jeSk7Cj4gIAlyZXR1cm4gaTkxNV9zZXFub19wYXNzZWQoc2Vxbm8sIHJlcS0+c2Vx bm8pOwo+ICB9Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4IDQ2YTg0YzQ0N2Q4 Zi4uMjlkOThkZGJiYzgwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf Z2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gQEAgLTExOTMs OSArMTE5MywxMyBAQCBzdGF0aWMgaW50IF9faTkxNV9zcGluX3JlcXVlc3Qoc3RydWN0IGRybV9p OTE1X2dlbV9yZXF1ZXN0ICpyZXEsIGludCBzdGF0ZSkKPiAgCSAqIHRha2VzIHRvIHNsZWVwIG9u IGEgcmVxdWVzdCwgb24gdGhlIG9yZGVyIG9mIGEgbWljcm9zZWNvbmQuCj4gIAkgKi8KPiAgCj4g LQlpZiAoaTkxNV9nZW1fcmVxdWVzdF9nZXRfcmluZyhyZXEpLT5pcnFfcmVmY291bnQpCj4gKwlp ZiAocmVxLT5yaW5nLT5pcnFfcmVmY291bnQpCj4gIAkJcmV0dXJuIC1FQlVTWTsKPiAgCj4gKwkv KiBPbmx5IHNwaW4gaWYgd2Uga25vdyB0aGUgR1BVIGlzIHByb2Nlc3NpbmcgdGhpcyByZXF1ZXN0 ICovCj4gKwlpZiAoIWk5MTVfZ2VtX3JlcXVlc3Rfc3RhcnRlZChyZXEsIHRydWUpKQo+ICsJCXJl dHVybiAtRUFHQUlOOwo+ICsKPiAgCXRpbWVvdXQgPSBsb2NhbF9jbG9ja191cygmY3B1KSArIDU7 Cj4gIAl3aGlsZSAoIW5lZWRfcmVzY2hlZCgpKSB7Cj4gIAkJaWYgKGk5MTVfZ2VtX3JlcXVlc3Rf Y29tcGxldGVkKHJlcSwgdHJ1ZSkpCj4gQEAgLTEyMDksNiArMTIxMyw3IEBAIHN0YXRpYyBpbnQg X19pOTE1X3NwaW5fcmVxdWVzdChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcSwgaW50 IHN0YXRlKQo+ICAKPiAgCQljcHVfcmVsYXhfbG93bGF0ZW5jeSgpOwo+ICAJfQo+ICsKPiAgCWlm IChpOTE1X2dlbV9yZXF1ZXN0X2NvbXBsZXRlZChyZXEsIGZhbHNlKSkKPiAgCQlyZXR1cm4gMDsK PiAgCj4gQEAgLTI2MDAsNiArMjYwNSw3IEBAIHZvaWQgX19pOTE1X2FkZF9yZXF1ZXN0KHN0cnVj dCBkcm1faTkxNV9nZW1fcmVxdWVzdCAqcmVxdWVzdCwKPiAgCXJlcXVlc3QtPmJhdGNoX29iaiA9 IG9iajsKPiAgCj4gIAlyZXF1ZXN0LT5lbWl0dGVkX2ppZmZpZXMgPSBqaWZmaWVzOwo+ICsJcmVx dWVzdC0+cHJldmlvdXNfc2Vxbm8gPSByaW5nLT5sYXN0X3N1Ym1pdHRlZF9zZXFubzsKPiAgCXJp bmctPmxhc3Rfc3VibWl0dGVkX3NlcW5vID0gcmVxdWVzdC0+c2Vxbm87Cj4gIAlsaXN0X2FkZF90 YWlsKCZyZXF1ZXN0LT5saXN0LCAmcmluZy0+cmVxdWVzdF9saXN0KTsKPiAgCj4gLS0gCj4gMi42 LjMKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3Jh dGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=