From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/3] drm: Balance error path for GEM handle allocation Date: Mon, 4 Jan 2016 17:24:11 +0200 Message-ID: <20160104152411.GX4437@intel.com> References: <1451902261-25380-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1451902261-25380-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKYW4gMDQsIDIwMTYgYXQgMTA6MTA6NTlBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFRoZSBjdXJyZW50IGVycm9yIHBhdGggZm9yIGZhaWx1cmUgd2hlbiBlc3RhYmxpc2hp bmcgYSBoYW5kbGUgZm9yIGEgR0VNCj4gb2JqZWN0IGlzIHVuYmFsYW5jZSwgZS5nLiB3ZSBjYWxs IG9iamVjdF9jbG9zZSgpIHdpdGhvdXQgY2FsbGluZyBmaXJzdAo+IG9iamVjdF9vcGVuKCkuIFVz ZSB0aGUgdHlwaWNhbCBvbmlvbiBzdHJ1Y3R1cmUgdG8gb25seSB1bmRvIHdoYXQgaGFzCj4gYmVl biBzZXQgdXAgcHJpb3IgdG8gdGhlIGVycm9yLgo+IAo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdp bHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v ZHJtX2dlbS5jIHwgMjkgKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9nZW0uYwo+ IGluZGV4IDJlMTBiYmE0NDY4Yi4uYTA4MTc2ZGViYzBlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9kcm1fZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbS5jCj4gQEAg LTM0MywyNyArMzQzLDMyIEBAIGRybV9nZW1faGFuZGxlX2NyZWF0ZV90YWlsKHN0cnVjdCBkcm1f ZmlsZSAqZmlsZV9wcml2LAo+ICAJc3Bpbl91bmxvY2soJmZpbGVfcHJpdi0+dGFibGVfbG9jayk7 Cj4gIAlpZHJfcHJlbG9hZF9lbmQoKTsKPiAgCW11dGV4X3VubG9jaygmZGV2LT5vYmplY3RfbmFt ZV9sb2NrKTsKPiAtCWlmIChyZXQgPCAwKSB7Cj4gLQkJZHJtX2dlbV9vYmplY3RfaGFuZGxlX3Vu cmVmZXJlbmNlX3VubG9ja2VkKG9iaik7Cj4gLQkJcmV0dXJuIHJldDsKPiAtCX0KPiArCWlmIChy ZXQgPCAwKQo+ICsJCWdvdG8gZXJyX3VucmVmOwo+ICsKPiAgCSpoYW5kbGVwID0gcmV0Owo+ICAK PiAgCXJldCA9IGRybV92bWFfbm9kZV9hbGxvdygmb2JqLT52bWFfbm9kZSwgZmlsZV9wcml2LT5m aWxwKTsKPiAtCWlmIChyZXQpIHsKPiAtCQlkcm1fZ2VtX2hhbmRsZV9kZWxldGUoZmlsZV9wcml2 LCAqaGFuZGxlcCk7Cj4gLQkJcmV0dXJuIHJldDsKPiAtCX0KPiArCWlmIChyZXQpCj4gKwkJZ290 byBlcnJfcmVtb3ZlOwo+ICAKPiAgCWlmIChkZXYtPmRyaXZlci0+Z2VtX29wZW5fb2JqZWN0KSB7 Cj4gIAkJcmV0ID0gZGV2LT5kcml2ZXItPmdlbV9vcGVuX29iamVjdChvYmosIGZpbGVfcHJpdik7 Cj4gLQkJaWYgKHJldCkgewo+IC0JCQlkcm1fZ2VtX2hhbmRsZV9kZWxldGUoZmlsZV9wcml2LCAq aGFuZGxlcCk7Cj4gLQkJCXJldHVybiByZXQ7Cj4gLQkJfQo+ICsJCWlmIChyZXQpCj4gKwkJCWdv dG8gZXJyX3Jldm9rZTsKPiAgCX0KPiAgCj4gIAlyZXR1cm4gMDsKPiArCj4gK2Vycl9yZXZva2U6 Cj4gKwlkcm1fdm1hX25vZGVfcmV2b2tlKCZvYmotPnZtYV9ub2RlLCBmaWxlX3ByaXYtPmZpbHAp Owo+ICtlcnJfcmVtb3ZlOgo+ICsJc3Bpbl9sb2NrKCZmaWxlX3ByaXYtPnRhYmxlX2xvY2spOwo+ ICsJaWRyX3JlbW92ZSgmZmlsZV9wcml2LT5vYmplY3RfaWRyLCAqaGFuZGxlcCk7Cj4gKwlzcGlu X3VubG9jaygmZmlsZV9wcml2LT50YWJsZV9sb2NrKTsKPiArZXJyX3VucmVmOgo+ICsJZHJtX2dl bV9vYmplY3RfaGFuZGxlX3VucmVmZXJlbmNlX3VubG9ja2VkKG9iaik7Cj4gKwlyZXR1cm4gcmV0 OwoKRmlyc3QgSSBtaXNyZWFkIHRoaXMgYXMgZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVuY2VfdW5s b2NrZWQoKQphbmQgdGhvdWdoIHdlJ2QgbGVhayB0aGUgaGFuZGxlX2NvdW50KyssIGJ1dCBpdCdz CmRybV9nZW1fb2JqZWN0X2hhbmRsZV91bnJlZmVyZW5jZV91bmxvY2tlZCgpIHdoaWNoIGRvZXMg dGhlCmhhbmRsZV9jb3VudC0tIHdlIG5lZWQuCgpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOk IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gIH0KPiAgCj4gIC8qKgo+IC0tIAo+ IDIuNi40Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==