From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/3] drm: Only bump object-reference count when adding first handle Date: Mon, 4 Jan 2016 17:29:58 +0200 Message-ID: <20160104152958.GY4437@intel.com> References: <1451902261-25380-1-git-send-email-chris@chris-wilson.co.uk> <1451902261-25380-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1451902261-25380-2-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKYW4gMDQsIDIwMTYgYXQgMTA6MTE6MDBBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFdlIG9ubHkgbmVlZCBhIHNpbmdsZSByZWZlcmVuY2UgY291bnQgZm9yIGFsbCBoYW5k bGVzIChpLmUuIG5vbi16ZXJvCj4gb2JqLT5oYW5kbGVfY291bnQpIGFuZCBzbyBjYW4gdHJpbSBh IGZldyBhdG9taWMgb3BlcmF0aW9ucyBieSBvbmx5Cj4gdGFraW5nIHRoZSByZWZlcmVuY2Ugb24g dGhlIGZpcnN0IGhhbmRsZSBhbmQgZHJvcHBpbmcgaXQgYWZ0ZXIgdGhlIGxhc3QuCj4gCj4gU2ln bmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMgfCAxNyArKysrKysrKysrKystLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f Z2VtLmMKPiBpbmRleCBhMDgxNzZkZWJjMGUuLmFkOTU1ZDdjOTlmZCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2dlbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9nZW0u Ywo+IEBAIC0yMjAsNiArMjIwLDkgQEAgc3RhdGljIHZvaWQgZHJtX2dlbV9vYmplY3RfZXhwb3J0 ZWRfZG1hX2J1Zl9mcmVlKHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqKQo+ICBzdGF0aWMgdm9p ZAo+ICBkcm1fZ2VtX29iamVjdF9oYW5kbGVfdW5yZWZlcmVuY2VfdW5sb2NrZWQoc3RydWN0IGRy bV9nZW1fb2JqZWN0ICpvYmopCj4gIHsKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBvYmot PmRldjsKPiArCWJvb2wgZmluYWwgPSBmYWxzZTsKPiArCj4gIAlpZiAoV0FSTl9PTihvYmotPmhh bmRsZV9jb3VudCA9PSAwKSkKPiAgCQlyZXR1cm47Cj4gIAo+IEBAIC0yMjksMTQgKzIzMiwxNiBA QCBkcm1fZ2VtX29iamVjdF9oYW5kbGVfdW5yZWZlcmVuY2VfdW5sb2NrZWQoc3RydWN0IGRybV9n ZW1fb2JqZWN0ICpvYmopCj4gIAkqIGNoZWNrZWQgZm9yIGEgbmFtZQo+ICAJKi8KPiAgCj4gLQlt dXRleF9sb2NrKCZvYmotPmRldi0+b2JqZWN0X25hbWVfbG9jayk7Cj4gKwltdXRleF9sb2NrKCZk ZXYtPm9iamVjdF9uYW1lX2xvY2spOwo+ICAJaWYgKC0tb2JqLT5oYW5kbGVfY291bnQgPT0gMCkg ewo+ICAJCWRybV9nZW1fb2JqZWN0X2hhbmRsZV9mcmVlKG9iaik7Cj4gIAkJZHJtX2dlbV9vYmpl Y3RfZXhwb3J0ZWRfZG1hX2J1Zl9mcmVlKG9iaik7Cj4gKwkJZmluYWwgPSB0cnVlOwo+ICAJfQo+ IC0JbXV0ZXhfdW5sb2NrKCZvYmotPmRldi0+b2JqZWN0X25hbWVfbG9jayk7Cj4gKwltdXRleF91 bmxvY2soJmRldi0+b2JqZWN0X25hbWVfbG9jayk7Cj4gIAo+IC0JZHJtX2dlbV9vYmplY3RfdW5y ZWZlcmVuY2VfdW5sb2NrZWQob2JqKTsKPiArCWlmIChmaW5hbCkKPiArCQlkcm1fZ2VtX29iamVj dF91bnJlZmVyZW5jZV91bmxvY2tlZChvYmopOwo+ICB9Cj4gIAo+ICAvKioKPiBAQCAtMzI5LDYg KzMzNCw4IEBAIGRybV9nZW1faGFuZGxlX2NyZWF0ZV90YWlsKHN0cnVjdCBkcm1fZmlsZSAqZmls ZV9wcml2LAo+ICAJaW50IHJldDsKPiAgCj4gIAlXQVJOX09OKCFtdXRleF9pc19sb2NrZWQoJmRl di0+b2JqZWN0X25hbWVfbG9jaykpOwo+ICsJaWYgKG9iai0+aGFuZGxlX2NvdW50KysgPT0gMCkK PiArCQlkcm1fZ2VtX29iamVjdF9yZWZlcmVuY2Uob2JqKTsKCkhtbS4gWWVhaCwgaGFuZGxlX2Nv dW50IGlzIHByb3RlY3RlZCBieSBvYmplY3RfbmFtZV9sb2NrLCBzbyB0aGlzIGxvb2tzCmJldHRl ciBoZXJlIHJhdGhlciB0aGFuIHdpdGhpbiB0aGUgc3BpbmxvY2tlZCBzZWN0aW9uLgoKUGF0Y2gg bG9va3Mgc2FuZToKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cgo+ICAKPiAgCS8qCj4gIAkgKiBHZXQgdGhlIHVzZXItdmlzaWJsZSBo YW5kbGUgdXNpbmcgaWRyLiAgUHJlbG9hZCBhbmQgcGVyZm9ybQo+IEBAIC0zMzgsMTAgKzM0NSwx MCBAQCBkcm1fZ2VtX2hhbmRsZV9jcmVhdGVfdGFpbChzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJp diwKPiAgCXNwaW5fbG9jaygmZmlsZV9wcml2LT50YWJsZV9sb2NrKTsKPiAgCj4gIAlyZXQgPSBp ZHJfYWxsb2MoJmZpbGVfcHJpdi0+b2JqZWN0X2lkciwgb2JqLCAxLCAwLCBHRlBfTk9XQUlUKTsK PiAtCWRybV9nZW1fb2JqZWN0X3JlZmVyZW5jZShvYmopOwo+IC0Jb2JqLT5oYW5kbGVfY291bnQr KzsKPiArCj4gIAlzcGluX3VubG9jaygmZmlsZV9wcml2LT50YWJsZV9sb2NrKTsKPiAgCWlkcl9w cmVsb2FkX2VuZCgpOwo+ICsKPiAgCW11dGV4X3VubG9jaygmZGV2LT5vYmplY3RfbmFtZV9sb2Nr KTsKPiAgCWlmIChyZXQgPCAwKQo+ICAJCWdvdG8gZXJyX3VucmVmOwo+IC0tIAo+IDIuNi40Cj4g Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0t IApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg==