From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/3] drm: Balance error path for GEM handle allocation Date: Mon, 4 Jan 2016 17:33:45 +0200 Message-ID: <20160104153345.GA4437@intel.com> References: <1451902261-25380-1-git-send-email-chris@chris-wilson.co.uk> <20160104101850.GA12349@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160104101850.GA12349@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKYW4gMDQsIDIwMTYgYXQgMTA6MTg6NTBBTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIE1vbiwgSmFuIDA0LCAyMDE2IGF0IDEwOjEwOjU5QU0gKzAwMDAsIENocmlzIFdp bHNvbiB3cm90ZToKPiA+IFRoZSBjdXJyZW50IGVycm9yIHBhdGggZm9yIGZhaWx1cmUgd2hlbiBl c3RhYmxpc2hpbmcgYSBoYW5kbGUgZm9yIGEgR0VNCj4gPiBvYmplY3QgaXMgdW5iYWxhbmNlLCBl LmcuIHdlIGNhbGwgb2JqZWN0X2Nsb3NlKCkgd2l0aG91dCBjYWxsaW5nIGZpcnN0Cj4gPiBvYmpl Y3Rfb3BlbigpLiBVc2UgdGhlIHR5cGljYWwgb25pb24gc3RydWN0dXJlIHRvIG9ubHkgdW5kbyB3 aGF0IGhhcwo+ID4gYmVlbiBzZXQgdXAgcHJpb3IgdG8gdGhlIGVycm9yLgo+ID4gCj4gPiBTaWdu ZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+IC0t LQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMgfCAyOSArKysrKysrKysrKysrKysrKy0t LS0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxMiBkZWxl dGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbS5jCj4gPiBpbmRleCAyZTEwYmJhNDQ2OGIuLmEwODE3 NmRlYmMwZSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiA+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiA+IEBAIC0zNDMsMjcgKzM0MywzMiBAQCBk cm1fZ2VtX2hhbmRsZV9jcmVhdGVfdGFpbChzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiwKPiA+ ICAJc3Bpbl91bmxvY2soJmZpbGVfcHJpdi0+dGFibGVfbG9jayk7Cj4gPiAgCWlkcl9wcmVsb2Fk X2VuZCgpOwo+ID4gIAltdXRleF91bmxvY2soJmRldi0+b2JqZWN0X25hbWVfbG9jayk7Cj4gPiAt CWlmIChyZXQgPCAwKSB7Cj4gPiAtCQlkcm1fZ2VtX29iamVjdF9oYW5kbGVfdW5yZWZlcmVuY2Vf dW5sb2NrZWQob2JqKTsKPiA+IC0JCXJldHVybiByZXQ7Cj4gPiAtCX0KPiA+ICsJaWYgKHJldCA8 IDApCj4gPiArCQlnb3RvIGVycl91bnJlZjsKPiA+ICsKPiA+ICAJKmhhbmRsZXAgPSByZXQ7Cj4g PiAgCj4gPiAgCXJldCA9IGRybV92bWFfbm9kZV9hbGxvdygmb2JqLT52bWFfbm9kZSwgZmlsZV9w cml2LT5maWxwKTsKPiA+IC0JaWYgKHJldCkgewo+ID4gLQkJZHJtX2dlbV9oYW5kbGVfZGVsZXRl KGZpbGVfcHJpdiwgKmhhbmRsZXApOwo+ID4gLQkJcmV0dXJuIHJldDsKPiA+IC0JfQo+ID4gKwlp ZiAocmV0KQo+ID4gKwkJZ290byBlcnJfcmVtb3ZlOwo+ID4gIAo+ID4gIAlpZiAoZGV2LT5kcml2 ZXItPmdlbV9vcGVuX29iamVjdCkgewo+ID4gIAkJcmV0ID0gZGV2LT5kcml2ZXItPmdlbV9vcGVu X29iamVjdChvYmosIGZpbGVfcHJpdik7Cj4gPiAtCQlpZiAocmV0KSB7Cj4gPiAtCQkJZHJtX2dl bV9oYW5kbGVfZGVsZXRlKGZpbGVfcHJpdiwgKmhhbmRsZXApOwo+ID4gLQkJCXJldHVybiByZXQ7 Cj4gPiAtCQl9Cj4gPiArCQlpZiAocmV0KQo+ID4gKwkJCWdvdG8gZXJyX3Jldm9rZTsKPiA+ICAJ fQo+ID4gIAo+ID4gIAlyZXR1cm4gMDsKPiA+ICsKPiA+ICtlcnJfcmV2b2tlOgo+ID4gKwlkcm1f dm1hX25vZGVfcmV2b2tlKCZvYmotPnZtYV9ub2RlLCBmaWxlX3ByaXYtPmZpbHApOwo+ID4gK2Vy cl9yZW1vdmU6Cj4gPiArCXNwaW5fbG9jaygmZmlsZV9wcml2LT50YWJsZV9sb2NrKTsKPiA+ICsJ aWRyX3JlbW92ZSgmZmlsZV9wcml2LT5vYmplY3RfaWRyLCAqaGFuZGxlcCk7Cj4gCj4gRm9yIGJv bnVzIHBvaW50cywgd2UgY291bGQgKmhhbmRsZXAgPSAwOyBoZXJlLgoKRm9yIHRoZXNlIHNvcnQg b2YgdGhpbmdzIEkgdXN1YWxseSBwcmVmZXIgdG8gbm90IGNsb2JiZXIgYW55CnJldHVybiBwYXJh bWV0ZXJzIHVubGVzcyB0aGUgd2hvbGUgb3BlcmF0aW9uIHN1Y2VlZHMuCiAKPiAKPiA+ICsJc3Bp bl91bmxvY2soJmZpbGVfcHJpdi0+dGFibGVfbG9jayk7Cj4gPiArZXJyX3VucmVmOgo+ID4gKwlk cm1fZ2VtX29iamVjdF9oYW5kbGVfdW5yZWZlcmVuY2VfdW5sb2NrZWQob2JqKTsKPiA+ICsJcmV0 dXJuIHJldDsKPiA+ICB9Cj4gCj4gLS0gCj4gQ2hyaXMgV2lsc29uLCBJbnRlbCBPcGVuIFNvdXJj ZSBUZWNobm9sb2d5IENlbnRyZQo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=