From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/3] drm: Balance error path for GEM handle allocation Date: Mon, 4 Jan 2016 17:37:01 +0200 Message-ID: <20160104153701.GB4437@intel.com> References: <1451902261-25380-1-git-send-email-chris@chris-wilson.co.uk> <20160104152411.GX4437@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160104152411.GX4437@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKYW4gMDQsIDIwMTYgYXQgMDU6MjQ6MTFQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIE1vbiwgSmFuIDA0LCAyMDE2IGF0IDEwOjEwOjU5QU0gKzAwMDAsIENocmlz IFdpbHNvbiB3cm90ZToKPiA+IFRoZSBjdXJyZW50IGVycm9yIHBhdGggZm9yIGZhaWx1cmUgd2hl biBlc3RhYmxpc2hpbmcgYSBoYW5kbGUgZm9yIGEgR0VNCj4gPiBvYmplY3QgaXMgdW5iYWxhbmNl LCBlLmcuIHdlIGNhbGwgb2JqZWN0X2Nsb3NlKCkgd2l0aG91dCBjYWxsaW5nIGZpcnN0Cj4gPiBv YmplY3Rfb3BlbigpLiBVc2UgdGhlIHR5cGljYWwgb25pb24gc3RydWN0dXJlIHRvIG9ubHkgdW5k byB3aGF0IGhhcwo+ID4gYmVlbiBzZXQgdXAgcHJpb3IgdG8gdGhlIGVycm9yLgo+ID4gCj4gPiBT aWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+ IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMgfCAyOSArKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxMiBk ZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2Vt LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbS5jCj4gPiBpbmRleCAyZTEwYmJhNDQ2OGIuLmEw ODE3NmRlYmMwZSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiA+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtLmMKPiA+IEBAIC0zNDMsMjcgKzM0MywzMiBA QCBkcm1fZ2VtX2hhbmRsZV9jcmVhdGVfdGFpbChzdHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiwK PiA+ICAJc3Bpbl91bmxvY2soJmZpbGVfcHJpdi0+dGFibGVfbG9jayk7Cj4gPiAgCWlkcl9wcmVs b2FkX2VuZCgpOwo+ID4gIAltdXRleF91bmxvY2soJmRldi0+b2JqZWN0X25hbWVfbG9jayk7Cj4g PiAtCWlmIChyZXQgPCAwKSB7Cj4gPiAtCQlkcm1fZ2VtX29iamVjdF9oYW5kbGVfdW5yZWZlcmVu Y2VfdW5sb2NrZWQob2JqKTsKPiA+IC0JCXJldHVybiByZXQ7Cj4gPiAtCX0KPiA+ICsJaWYgKHJl dCA8IDApCj4gPiArCQlnb3RvIGVycl91bnJlZjsKPiA+ICsKPiA+ICAJKmhhbmRsZXAgPSByZXQ7 Cj4gPiAgCj4gPiAgCXJldCA9IGRybV92bWFfbm9kZV9hbGxvdygmb2JqLT52bWFfbm9kZSwgZmls ZV9wcml2LT5maWxwKTsKPiA+IC0JaWYgKHJldCkgewo+ID4gLQkJZHJtX2dlbV9oYW5kbGVfZGVs ZXRlKGZpbGVfcHJpdiwgKmhhbmRsZXApOwo+ID4gLQkJcmV0dXJuIHJldDsKPiA+IC0JfQo+ID4g KwlpZiAocmV0KQo+ID4gKwkJZ290byBlcnJfcmVtb3ZlOwo+ID4gIAo+ID4gIAlpZiAoZGV2LT5k cml2ZXItPmdlbV9vcGVuX29iamVjdCkgewo+ID4gIAkJcmV0ID0gZGV2LT5kcml2ZXItPmdlbV9v cGVuX29iamVjdChvYmosIGZpbGVfcHJpdik7Cj4gPiAtCQlpZiAocmV0KSB7Cj4gPiAtCQkJZHJt X2dlbV9oYW5kbGVfZGVsZXRlKGZpbGVfcHJpdiwgKmhhbmRsZXApOwo+ID4gLQkJCXJldHVybiBy ZXQ7Cj4gPiAtCQl9Cj4gPiArCQlpZiAocmV0KQo+ID4gKwkJCWdvdG8gZXJyX3Jldm9rZTsKPiA+ ICAJfQo+ID4gIAo+ID4gIAlyZXR1cm4gMDsKPiA+ICsKPiA+ICtlcnJfcmV2b2tlOgo+ID4gKwlk cm1fdm1hX25vZGVfcmV2b2tlKCZvYmotPnZtYV9ub2RlLCBmaWxlX3ByaXYtPmZpbHApOwo+ID4g K2Vycl9yZW1vdmU6Cj4gPiArCXNwaW5fbG9jaygmZmlsZV9wcml2LT50YWJsZV9sb2NrKTsKPiA+ ICsJaWRyX3JlbW92ZSgmZmlsZV9wcml2LT5vYmplY3RfaWRyLCAqaGFuZGxlcCk7Cj4gPiArCXNw aW5fdW5sb2NrKCZmaWxlX3ByaXYtPnRhYmxlX2xvY2spOwo+ID4gK2Vycl91bnJlZjoKPiA+ICsJ ZHJtX2dlbV9vYmplY3RfaGFuZGxlX3VucmVmZXJlbmNlX3VubG9ja2VkKG9iaik7Cj4gPiArCXJl dHVybiByZXQ7Cj4gCj4gRmlyc3QgSSBtaXNyZWFkIHRoaXMgYXMgZHJtX2dlbV9vYmplY3RfdW5y ZWZlcmVuY2VfdW5sb2NrZWQoKQo+IGFuZCB0aG91Z2ggd2UnZCBsZWFrIHRoZSBoYW5kbGVfY291 bnQrKywgYnV0IGl0J3MKPiBkcm1fZ2VtX29iamVjdF9oYW5kbGVfdW5yZWZlcmVuY2VfdW5sb2Nr ZWQoKSB3aGljaCBkb2VzIHRoZQo+IGhhbmRsZV9jb3VudC0tIHdlIG5lZWQuCj4gCj4gUmV2aWV3 ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpC VFcgd2hpbGUgbG9va2luZyBhdCB0aGUgY29kZSBJIHNwb3R0ZWQgdGhhdCBkcm1fZ2VtX2hhbmRs ZV9kZWxldGUoKQpjb250YWlucyBhbiBvcGVuIGNvZGVkIGNvcHkgb2YgZHJtX2dlbV9vYmplY3Rf cmVsZWFzZV9oYW5kbGUoKS4gTWlnaHQKbWFrZSBzZW5zZSB0byBlbGltaW5hdGUgdGhhdCBkdXBs aWNhdGlvbi4KCj4gCj4gPiAgfQo+ID4gIAo+ID4gIC8qKgo+ID4gLS0gCj4gPiAyLjYuNAo+ID4g Cj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4g ZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+ID4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+ID4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo+IAo+IC0tIAo+IFZpbGxlIFN5cmrDpGzDpAo+IEludGVsIE9UQwo+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOk bMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAo=