From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH i-g-t 2/6] lib: Extract ssme common fb create+fill methods into helpers Date: Mon, 4 Jan 2016 18:23:18 +0200 Message-ID: <20160104162318.GF4437@intel.com> References: <1450459550-16504-1-git-send-email-ville.syrjala@linux.intel.com> <1450459550-16504-2-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 0211989BD5 for ; Mon, 4 Jan 2016 08:23:21 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Thomas Wood Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBEZWMgMjEsIDIwMTUgYXQgMTA6NDI6NDZBTSArMDAwMCwgVGhvbWFzIFdvb2Qgd3Jv dGU6Cj4gT24gMTggRGVjZW1iZXIgMjAxNSBhdCAxNzoyNSwgIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4gd3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPgo+ID4KPiA+IFNldmVyYWwgdGVzdHMgZG8gb25lIG9yIG1vcmUg b2YgdGhlIGZvbGxvd2luOgo+ID4gKiBpZ3RfY3JlYXRlX2ZiKCkgKyBpZ3RfcGFpbnRfdGVzdF9w YXR0ZXJuKCkKPiA+ICogaWd0X2NyZWF0ZV9jb2xvcl9mYigpICsgaWd0X3BhaW50X3Rlc3RfcGF0 dGVybigpCj4gPiAqIGlndF9jcmVhdGVfZmIoKSArIGlndF9wYWludF9pbWFnZSgpCj4gPgo+ID4g RXh0cmFjdCB0aGVtIGludG8gbmV3IGhlbHBlczogaWd0X2NyZWF0ZV9wYXR0ZXJuX2ZiKCksCj4g PiBpZ3RfY3JlYXRlX2NvbG9yX3BhdHRlcm5fZmIoKSwgaWd0X2NyZWF0ZV9pbWFnZV9mYigpLgo+ IAo+IENvdXBsZSBvZiB0eXBvcyBhYm92ZTogInNzbWUiLCAiZm9sbG93aW4iLCAiaGVscGVzIgo+ IAo+IAo+ID4KPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFs YUBsaW51eC5pbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBsaWIvaWd0X2ZiLmMgICAgICAgICAgICAg IHwgMTI0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiA+ ICBsaWIvaWd0X2ZiLmggICAgICAgICAgICAgIHwgIDExICsrKysKPiA+ICB0ZXN0cy9rbXNfYXRv bWljLmMgICAgICAgIHwgIDMwICsrKystLS0tLS0tCj4gPiAgdGVzdHMva21zX2ZsaXBfdGlsaW5n LmMgICB8ICAyNSArKystLS0tLS0tCj4gPiAgdGVzdHMva21zX3BhbmVsX2ZpdHRpbmcuYyB8ICA0 MiArKysrLS0tLS0tLS0tLS0tCj4gPiAgdGVzdHMva21zX3BsYW5lX3NjYWxpbmcuYyB8ICA2MCAr KysrKystLS0tLS0tLS0tLS0tLS0tCj4gPiAgdGVzdHMva21zX3B3cml0ZV9jcmMuYyAgICB8ICAg OSArLS0tCj4gPiAgdGVzdHMva21zX3NldG1vZGUuYyAgICAgICB8ICAxMSArKy0tCj4gPiAgdGVz dHMvcG1fbHBzcC5jICAgICAgICAgICB8ICAxMSArLS0tCj4gPiAgdGVzdHMvcG1fcnBtLmMgICAg ICAgICAgICB8ICAxMCArKy0tCj4gPiAgdGVzdHMvdGVzdGRpc3BsYXkuYyAgICAgICB8ICAgOCAr Ky0KPiA+ICAxMSBmaWxlcyBjaGFuZ2VkLCAxODggaW5zZXJ0aW9ucygrKSwgMTUzIGRlbGV0aW9u cygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9saWIvaWd0X2ZiLmMgYi9saWIvaWd0X2ZiLmMKPiA+ IGluZGV4IDNlYTk5MTVjNDJjNC4uYjNjNzg0MGEyMmFlIDEwMDY0NAo+ID4gLS0tIGEvbGliL2ln dF9mYi5jCj4gPiArKysgYi9saWIvaWd0X2ZiLmMKPiA+IEBAIC01MzcsNiArNTM3LDEzMCBAQCB1 bnNpZ25lZCBpbnQgaWd0X2NyZWF0ZV9jb2xvcl9mYihpbnQgZmQsIGludCB3aWR0aCwgaW50IGhl aWdodCwKPiA+ICAgICAgICAgcmV0dXJuIGZiX2lkOwo+ID4gIH0KPiA+Cj4gPiArLyoqCj4gPiAr ICogaWd0X2NyZWF0ZV9wYXR0ZXJuX2ZiOgo+ID4gKyAqIEBmZDogb3BlbiBpOTE1IGRybSBmaWxl IGRlc2NyaXB0b3IKPiA+ICsgKiBAd2lkdGg6IHdpZHRoIG9mIHRoZSBmcmFtZWJ1ZmZlciBpbiBw aXhlbAo+ID4gKyAqIEBoZWlnaHQ6IGhlaWdodCBvZiB0aGUgZnJhbWVidWZmZXIgaW4gcGl4ZWwK PiA+ICsgKiBAZm9ybWF0OiBkcm0gZm91cmNjIHBpeGVsIGZvcm1hdCBjb2RlCj4gPiArICogQHRp bGluZzogdGlsaW5nIGxheW91dCBvZiB0aGUgZnJhbWVidWZmZXIKPiA+ICsgKiBAZmI6IHBvaW50 ZXIgdG8gYW4gI2lndF9mYiBzdHJ1Y3R1cmUKPiA+ICsgKgo+ID4gKyAqIFRoaXMgZnVuY3Rpb24g YWxsb2NhdGVzIGEgZ2VtIGJ1ZmZlciBvYmplY3Qgc3VpdGFibGUgdG8gYmFjayBhIGZyYW1lYnVm ZmVyCj4gPiArICogd2l0aCB0aGUgcmVxdWVzdGVkIHByb3BlcnRpZXMgYW5kIHRoZW4gd3JhcHMg aXQgdXAgaW4gYSBkcm0gZnJhbWVidWZmZXIKPiA+ICsgKiBvYmplY3QuIEFsbCBtZXRhZGF0YSBp cyBzdG9yZWQgaW4gQGZiLgo+ID4gKyAqCj4gPiArICogQ29tcGFyZWQgdG8gaWd0X2NyZWF0ZV9m YigpIHRoaXMgZnVuY3Rpb24gYWxzbyBmaWxscyB0aGUgZW50aXJlIGZyYW1lYnVmZmVyCj4gPiAr ICogd2l0aCB0aGUgdGVzdCBwYXR0ZXJuLgo+ID4gKyAqCj4gPiArICogUmV0dXJuczoKPiA+ICsg KiBUaGUga21zIGlkIG9mIHRoZSBjcmVhdGVkIGZyYW1lYnVmZmVyIG9uIHN1Y2Nlc3Mgb3IgYSBu ZWdhdGl2ZSBlcnJvciBjb2RlIG9uCj4gPiArICogZmFpbHVyZS4KPiA+ICsgKi8KPiA+ICt1bnNp Z25lZCBpbnQgaWd0X2NyZWF0ZV9wYXR0ZXJuX2ZiKGludCBmZCwgaW50IHdpZHRoLCBpbnQgaGVp Z2h0LAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCBmb3Jt YXQsIHVpbnQ2NF90IHRpbGluZywKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgc3RydWN0IGlndF9mYiAqZmIgLyogb3V0ICovKQo+ID4gK3sKPiA+ICsgICAgICAgdW5zaWdu ZWQgaW50IGZiX2lkOwo+ID4gKyAgICAgICBjYWlyb190ICpjcjsKPiA+ICsKPiA+ICsgICAgICAg ZmJfaWQgPSBpZ3RfY3JlYXRlX2ZiKGZkLCB3aWR0aCwgaGVpZ2h0LCBmb3JtYXQsIHRpbGluZywg ZmIpOwo+ID4gKyAgICAgICBpZ3RfYXNzZXJ0KGZiX2lkKTsKPiA+ICsKPiA+ICsgICAgICAgY3Ig PSBpZ3RfZ2V0X2NhaXJvX2N0eChmZCwgZmIpOwo+ID4gKyAgICAgICBpZ3RfcGFpbnRfdGVzdF9w YXR0ZXJuKGNyLCB3aWR0aCwgaGVpZ2h0KTsKPiA+ICsgICAgICAgaWd0X2Fzc2VydChjYWlyb19z dGF0dXMoY3IpID09IDApOwo+ID4gKyAgICAgICBjYWlyb19kZXN0cm95KGNyKTsKPiA+ICsKPiA+ ICsgICAgICAgcmV0dXJuIGZiX2lkOwo+ID4gK30KPiA+ICsKPiA+ICsvKioKPiA+ICsgKiBpZ3Rf Y3JlYXRlX3BhdHRlcm5fZmI6Cj4gCj4gVGhpcyBzaG91bGQgYmUgaWd0X2NyZWF0ZV9jb2xvcl9w YXR0ZXJuX2ZiLgo+IAo+IAo+ID4gKyAqIEBmZDogb3BlbiBpOTE1IGRybSBmaWxlIGRlc2NyaXB0 b3IKPiA+ICsgKiBAd2lkdGg6IHdpZHRoIG9mIHRoZSBmcmFtZWJ1ZmZlciBpbiBwaXhlbAo+ID4g KyAqIEBoZWlnaHQ6IGhlaWdodCBvZiB0aGUgZnJhbWVidWZmZXIgaW4gcGl4ZWwKPiA+ICsgKiBA Zm9ybWF0OiBkcm0gZm91cmNjIHBpeGVsIGZvcm1hdCBjb2RlCj4gPiArICogQHRpbGluZzogdGls aW5nIGxheW91dCBvZiB0aGUgZnJhbWVidWZmZXIKPiA+ICsgKiBAcjogcmVkIHZhbHVlIHRvIHVz ZSBhcyBmaWxsIGNvbG9yCj4gPiArICogQGc6IGdyZWUgdmFsdWUgdG8gdXNlIGFzIGZpbGwgY29s b3IKPiAKPiBUeXBvIG9mICJncmVlbiIgaGVyZS4KCkkgdGhpbmsgdGhpcyB3YXMgY29weSBwYXN0 ZWQgZnJvbSBzb21ld2hlcmUgZWxzZS4gSSdsbCBmaXggdXAgdGhlCm9yaWdpbmFsIGFzIHdlbGwu CgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK