From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/docs: more leftovers from the big vtable documentation pile Date: Tue, 5 Jan 2016 15:48:10 +0100 Message-ID: <20160105144810.GA18886@ulmo.nvidia.com> References: <1450286305-8980-1-git-send-email-daniel.vetter@ffwll.ch> <1451890416-9535-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1704350078==" Return-path: In-Reply-To: <1451890416-9535-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , Thierry Reding , Laurent Pinchart , DRI Development List-Id: intel-gfx@lists.freedesktop.org --===============1704350078== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2oS5YaxWCcQjTEyO" Content-Disposition: inline --2oS5YaxWCcQjTEyO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 04, 2016 at 07:53:36AM +0100, Daniel Vetter wrote: > Another pile of vfuncs from the old gpu.tmpl xml documentation that > I've forgotten to delete. I spotted a few more things to > clarify/extend in the new kerneldoc while going through this once > more. >=20 > v2: Spelling fixes (Thierry). Found a couple more. > diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_m= odeset_helper_vtables.h > index 29e0dc50031d..ce5cbf63b5cf 100644 > --- a/include/drm/drm_modeset_helper_vtables.h > +++ b/include/drm/drm_modeset_helper_vtables.h > @@ -131,6 +131,12 @@ struct drm_crtc_helper_funcs { > * Atomic drivers which need to inspect and adjust more state should > * instead use the @atomic_check callback. > * > + * Also beware that the neither core nor helpers filter modes before I'd drop the "the" above: "... that neither core nor helpers..." > + * passing the to the driver. More specifically modes rejected by the "passing them"? > + * ->mode_valid callback from #drm_connector_helper_funcs can still be > + * requested by userspace and therefore also need to be rejected in > + * either this hook, or the one in #drm_encoder_helper_funcs. > + * > * RETURNS: > * > * True if an acceptable configuration is possible, false if the modeset > @@ -188,7 +194,9 @@ struct drm_crtc_helper_funcs { > * This callback is used by the legacy CRTC helpers to set a new > * framebuffer and scanout position. It is optional and used as an > * optimized fast-path instead of a full mode set operation with all the > - * resulting flickering. Since it can't update other planes it's > + * resulting flickering. If it is not present > + * drm_crtc_helper_set_config() will fall back to a full modeset, using > + * the ->mode_set() callbac. Since it can't update other planes it's "callback" > * incompatible with atomic modeset support. > * > * This callback is only used by the CRTC helpers and deprecated. > @@ -439,6 +447,12 @@ struct drm_encoder_helper_funcs { > * Atomic drivers which need to inspect and adjust more state should > * instead use the @atomic_check callback. > * > + * Also beware that the neither core nor helpers filter modes before > + * passing the to the driver. More specifically modes rejected by the Same as above. Thierry --2oS5YaxWCcQjTEyO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWi9elAAoJEN0jrNd/PrOhoukQALXpAhpWnRqRjHnDuYQ5EeeD mxzUU9c4r5/rWcOar/pAyr3+JdYd//7F3jBNWmwYzJ2naNNgS65Y+OXiJBwzfOWS ceCgGawlfQjhOdmiyJ3W712TR8Ce31EWCWzdQrdeIKrSO3gTShHMSNmhf9Gw5lPF SetihbeWGfiCRv0Cj2BUU8+V7A4TvJtx+ZFpqGC3cagI754DyWuODe8zHSK3m/Tj 20/E8eIB//yStLPkx3baI6UL7i9q0VLr2PtClaESVHHVJ2/UCMzOB58fs7K1m/6n PKNXYkhhMY+/RSsBJ3ezV/Sl5x38DAgpbj8ms3iltbVd3wd9wQ76tMLgU8AlhIpH Je8TLB9lfb3HyVb1FNfkZfMo6FvT9ZrmK708H12SjhITK5Cf5cnP/6NvcmqQ1shj TdbqN56RkZdk+g0YhAtl4lzu3VJIxcHqYNKLo0lXRzCiLmdKDyI8w79Dm6U3fA0y 1hoLbXUC8WwOrUiLM9/N2SnoS5jtUPBEXPXbzXF6H+lZ/5Ekd4zjYMpucUN6DRVe 1bmvF8Jetc11hhTXDQ6xWdDocKICwmZA0UruIjyRee1FH71noqgwle5S/U9TBG+4 DG1DV0OSXio7VgIVgThd5pZ9Haq4OQIcQIfRaUYGI+5t4kwCShz5hPTjDWTyaHC9 kFhK1MbqkJYDhd80oQEx =p50a -----END PGP SIGNATURE----- --2oS5YaxWCcQjTEyO-- --===============1704350078== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1704350078==--