From: Daniel Vetter <daniel@ffwll.ch>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915: Restore inhibiting the load of the default context
Date: Wed, 6 Jan 2016 11:07:22 +0100 [thread overview]
Message-ID: <20160106100722.GG8076@phenom.ffwll.local> (raw)
In-Reply-To: <20151210104554.GU20822@phenom.ffwll.local>
On Thu, Dec 10, 2015 at 11:45:54AM +0100, Daniel Vetter wrote:
> On Thu, Dec 10, 2015 at 12:19:29PM +0200, Mika Kuoppala wrote:
> > Chris Wilson <chris@chris-wilson.co.uk> writes:
> >
> > > Following a GPU reset, we may leave the context in a poorly defined
> > > state, and reloading from that context will leave the GPU flummoxed. For
> > > secondary contexts, this will lead to that context being banned - but
> > > currently it is also causing the default context to become banned,
> > > leading to turmoil in the shared state.
> > >
> > > This is a regression from
> > >
> > > commit 6702cf16e0ba8b0129f5aa1b6609d4e9c70bc13b [v4.1]
> > > Author: Ben Widawsky <benjamin.widawsky@intel.com>
> > > Date: Mon Mar 16 16:00:58 2015 +0000
> > >
> > > drm/i915: Initialize all contexts
> > >
> > > which quietly introduced the removal of the MI_RESTORE_INHIBIT on the
> > > default context.
> > >
> > > v2: Mark the global default context as uninitialized on GPU reset so
> > > that the context-local workarounds are reloaded upon re-enabling.
> > >
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>
>
> Queued for -next, thanks for the patch.
I guess I dropped this one again, but now merged again since it fixes a
suspend/resume regression.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-06 10:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 10:07 [PATCH] drm/i915: Restore inhibiting the load of the default context Chris Wilson
2015-11-27 11:32 ` Mika Kuoppala
2015-11-27 13:14 ` Chris Wilson
2015-11-27 13:28 ` [PATCH v2] " Chris Wilson
2015-12-10 10:19 ` Mika Kuoppala
2015-12-10 10:45 ` Daniel Vetter
2016-01-06 10:07 ` Daniel Vetter [this message]
2015-12-10 13:24 ` Francisco Jerez
2015-12-10 13:37 ` Chris Wilson
2015-12-10 13:57 ` Francisco Jerez
2015-12-10 14:03 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106100722.GG8076@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox