* [PATCH] drm/i915/kbl: Enable PW1 and Misc I/O power wells
@ 2016-01-06 12:08 Michel Thierry
2016-01-06 12:24 ` Damien Lespiau
2016-01-06 14:20 ` ✓ success: Fi.CI.BAT Patchwork
0 siblings, 2 replies; 4+ messages in thread
From: Michel Thierry @ 2016-01-06 12:08 UTC (permalink / raw)
To: intel-gfx
My kbl stopped working because of this.
Fixes regression from
commit 2f693e28b8df69f67beced5e18bb2b91c2bfcec2
Author: Damien Lespiau <damien.lespiau@intel.com>
Date: Wed Nov 4 19:24:12 2015 +0200
drm/i915: Make turning on/off PW1 and Misc I/O part of the init/fini
sequences
Cc: Damien Lespiau <damien.lespiau@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Michel Thierry <michel.thierry@intel.com>
---
drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index ddbdbff..4b44e68 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -1851,7 +1851,7 @@ void skl_pw1_misc_io_init(struct drm_i915_private *dev_priv)
{
struct i915_power_well *well;
- if (!IS_SKYLAKE(dev_priv))
+ if (!(IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv)))
return;
well = lookup_power_well(dev_priv, SKL_DISP_PW_1);
@@ -1865,7 +1865,7 @@ void skl_pw1_misc_io_fini(struct drm_i915_private *dev_priv)
{
struct i915_power_well *well;
- if (!IS_SKYLAKE(dev_priv))
+ if (!(IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv)))
return;
well = lookup_power_well(dev_priv, SKL_DISP_PW_1);
--
2.6.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915/kbl: Enable PW1 and Misc I/O power wells
2016-01-06 12:08 [PATCH] drm/i915/kbl: Enable PW1 and Misc I/O power wells Michel Thierry
@ 2016-01-06 12:24 ` Damien Lespiau
2016-01-06 13:14 ` Daniel Vetter
2016-01-06 14:20 ` ✓ success: Fi.CI.BAT Patchwork
1 sibling, 1 reply; 4+ messages in thread
From: Damien Lespiau @ 2016-01-06 12:24 UTC (permalink / raw)
To: Michel Thierry; +Cc: intel-gfx
On Wed, Jan 06, 2016 at 12:08:36PM +0000, Michel Thierry wrote:
> My kbl stopped working because of this.
>
> Fixes regression from
> commit 2f693e28b8df69f67beced5e18bb2b91c2bfcec2
> Author: Damien Lespiau <damien.lespiau@intel.com>
> Date: Wed Nov 4 19:24:12 2015 +0200
> drm/i915: Make turning on/off PW1 and Misc I/O part of the init/fini
> sequences
>
> Cc: Damien Lespiau <damien.lespiau@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Michel Thierry <michel.thierry@intel.com>
Part of a time where IS_SKYLAKE() would have been true for KBL...
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
--
Damien
> ---
> drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index ddbdbff..4b44e68 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -1851,7 +1851,7 @@ void skl_pw1_misc_io_init(struct drm_i915_private *dev_priv)
> {
> struct i915_power_well *well;
>
> - if (!IS_SKYLAKE(dev_priv))
> + if (!(IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv)))
> return;
>
> well = lookup_power_well(dev_priv, SKL_DISP_PW_1);
> @@ -1865,7 +1865,7 @@ void skl_pw1_misc_io_fini(struct drm_i915_private *dev_priv)
> {
> struct i915_power_well *well;
>
> - if (!IS_SKYLAKE(dev_priv))
> + if (!(IS_SKYLAKE(dev_priv) || IS_KABYLAKE(dev_priv)))
> return;
>
> well = lookup_power_well(dev_priv, SKL_DISP_PW_1);
> --
> 2.6.4
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915/kbl: Enable PW1 and Misc I/O power wells
2016-01-06 12:24 ` Damien Lespiau
@ 2016-01-06 13:14 ` Daniel Vetter
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2016-01-06 13:14 UTC (permalink / raw)
To: Damien Lespiau; +Cc: intel-gfx
On Wed, Jan 06, 2016 at 01:24:58PM +0100, Damien Lespiau wrote:
> On Wed, Jan 06, 2016 at 12:08:36PM +0000, Michel Thierry wrote:
> > My kbl stopped working because of this.
> >
> > Fixes regression from
> > commit 2f693e28b8df69f67beced5e18bb2b91c2bfcec2
> > Author: Damien Lespiau <damien.lespiau@intel.com>
> > Date: Wed Nov 4 19:24:12 2015 +0200
> > drm/i915: Make turning on/off PW1 and Misc I/O part of the init/fini
> > sequences
> >
> > Cc: Damien Lespiau <damien.lespiau@intel.com>
> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > Cc: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>
> > Cc: Imre Deak <imre.deak@intel.com>
> > Signed-off-by: Michel Thierry <michel.thierry@intel.com>
>
> Part of a time where IS_SKYLAKE() would have been true for KBL...
>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ success: Fi.CI.BAT
2016-01-06 12:08 [PATCH] drm/i915/kbl: Enable PW1 and Misc I/O power wells Michel Thierry
2016-01-06 12:24 ` Damien Lespiau
@ 2016-01-06 14:20 ` Patchwork
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2016-01-06 14:20 UTC (permalink / raw)
To: Michel Thierry; +Cc: intel-gfx
== Summary ==
Built on 142b83d5713d07d01f6a0a1993761651459c2e66 drm-intel-nightly: 2016y-01m-06d-13h-21m-32s UTC integration manifest
Test gem_storedw_loop:
Subgroup basic-render:
pass -> DMESG-WARN (skl-i7k-2) UNSTABLE
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-a-frame-sequence:
pass -> DMESG-WARN (byt-nuc) UNSTABLE
bdw-nuci7 total:132 pass:0 dwarn:0 dfail:0 fail:0 skip:132
bsw-nuc-2 total:135 pass:115 dwarn:0 dfail:0 fail:0 skip:20
byt-nuc total:135 pass:120 dwarn:2 dfail:0 fail:0 skip:13
skl-i5k-2 total:135 pass:125 dwarn:2 dfail:0 fail:0 skip:8
skl-i7k-2 total:135 pass:125 dwarn:2 dfail:0 fail:0 skip:8
snb-dellxps total:135 pass:123 dwarn:0 dfail:0 fail:0 skip:12
Results at /archive/results/CI_IGT_test/Patchwork_1099/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-06 14:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-06 12:08 [PATCH] drm/i915/kbl: Enable PW1 and Misc I/O power wells Michel Thierry
2016-01-06 12:24 ` Damien Lespiau
2016-01-06 13:14 ` Daniel Vetter
2016-01-06 14:20 ` ✓ success: Fi.CI.BAT Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox