* [PATCH] drm/i915: shut up gen8+ SDE irq dmesg noise, again
@ 2016-01-07 8:29 Jani Nikula
2016-01-07 9:23 ` Chris Wilson
2016-01-07 9:32 ` Daniel Vetter
0 siblings, 2 replies; 5+ messages in thread
From: Jani Nikula @ 2016-01-07 8:29 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, drm-intel-fixes
We still keep getting
[ 4.249930] [drm:gen8_irq_handler [i915]] *ERROR* The master control interrupt lied (SDE)!
This reverts
commit 820da7ae46332fa709b171eb7ba57cbd023fa6df
Author: Jani Nikula <jani.nikula@intel.com>
Date: Wed Nov 25 16:47:23 2015 +0200
Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"
which in itself is a revert, so this is just doing
commit 97e5ed1111dcc5300a0f59a55248cd243937a8ab
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Fri Oct 23 10:56:12 2015 +0200
drm/i915: shut up gen8+ SDE irq dmesg noise
all over again. I'll stop pretending I understand what's going on like I
did when I thought I'd fixed this for good in
commit 6a39d7c986be4fd18eb019e9cdbf774ec36c9f77
Author: Jani Nikula <jani.nikula@intel.com>
Date: Wed Nov 25 16:47:22 2015 +0200
drm/i915: fix the SDE irq dmesg warnings properly
Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
Reference: http://mid.gmane.org/20151213124945.GA5715@nuc-i3427.alporthouse.com
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92084
Cc: drm-intel-fixes@lists.freedesktop.org
Fixes: 820da7ae4633 ("Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"")
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_irq.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 3f8c753997ba..fa8afa7860ae 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -2414,9 +2414,13 @@ static irqreturn_t gen8_irq_handler(int irq, void *arg)
spt_irq_handler(dev, pch_iir);
else
cpt_irq_handler(dev, pch_iir);
- } else
- DRM_ERROR("The master control interrupt lied (SDE)!\n");
-
+ } else {
+ /*
+ * Like on previous PCH there seems to be something
+ * fishy going on with forwarding PCH interrupts.
+ */
+ DRM_DEBUG_DRIVER("The master control interrupt lied (SDE)!\n");
+ }
}
I915_WRITE_FW(GEN8_MASTER_IRQ, GEN8_MASTER_IRQ_CONTROL);
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: shut up gen8+ SDE irq dmesg noise, again
2016-01-07 8:29 [PATCH] drm/i915: shut up gen8+ SDE irq dmesg noise, again Jani Nikula
@ 2016-01-07 9:23 ` Chris Wilson
2016-01-07 9:32 ` Daniel Vetter
1 sibling, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2016-01-07 9:23 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, drm-intel-fixes
On Thu, Jan 07, 2016 at 10:29:10AM +0200, Jani Nikula wrote:
> We still keep getting
>
> [ 4.249930] [drm:gen8_irq_handler [i915]] *ERROR* The master control interrupt lied (SDE)!
>
> This reverts
>
> commit 820da7ae46332fa709b171eb7ba57cbd023fa6df
> Author: Jani Nikula <jani.nikula@intel.com>
> Date: Wed Nov 25 16:47:23 2015 +0200
>
> Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"
>
> which in itself is a revert, so this is just doing
>
> commit 97e5ed1111dcc5300a0f59a55248cd243937a8ab
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Fri Oct 23 10:56:12 2015 +0200
>
> drm/i915: shut up gen8+ SDE irq dmesg noise
>
> all over again. I'll stop pretending I understand what's going on like I
> did when I thought I'd fixed this for good in
>
> commit 6a39d7c986be4fd18eb019e9cdbf774ec36c9f77
> Author: Jani Nikula <jani.nikula@intel.com>
> Date: Wed Nov 25 16:47:22 2015 +0200
>
> drm/i915: fix the SDE irq dmesg warnings properly
>
> Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reference: http://mid.gmane.org/20151213124945.GA5715@nuc-i3427.alporthouse.com
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92084
> Cc: drm-intel-fixes@lists.freedesktop.org
> Fixes: 820da7ae4633 ("Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"")
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
(still not convinced that even a debug error message gives us any
insight over and above mmio tracing)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: shut up gen8+ SDE irq dmesg noise, again
2016-01-07 8:29 [PATCH] drm/i915: shut up gen8+ SDE irq dmesg noise, again Jani Nikula
2016-01-07 9:23 ` Chris Wilson
@ 2016-01-07 9:32 ` Daniel Vetter
2016-01-07 9:57 ` Jani Nikula
1 sibling, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2016-01-07 9:32 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, drm-intel-fixes
On Thu, Jan 07, 2016 at 10:29:10AM +0200, Jani Nikula wrote:
> We still keep getting
>
> [ 4.249930] [drm:gen8_irq_handler [i915]] *ERROR* The master control interrupt lied (SDE)!
>
> This reverts
>
> commit 820da7ae46332fa709b171eb7ba57cbd023fa6df
> Author: Jani Nikula <jani.nikula@intel.com>
> Date: Wed Nov 25 16:47:23 2015 +0200
>
> Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"
>
> which in itself is a revert, so this is just doing
>
> commit 97e5ed1111dcc5300a0f59a55248cd243937a8ab
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date: Fri Oct 23 10:56:12 2015 +0200
>
> drm/i915: shut up gen8+ SDE irq dmesg noise
>
> all over again. I'll stop pretending I understand what's going on like I
> did when I thought I'd fixed this for good in
>
> commit 6a39d7c986be4fd18eb019e9cdbf774ec36c9f77
> Author: Jani Nikula <jani.nikula@intel.com>
> Date: Wed Nov 25 16:47:22 2015 +0200
>
> drm/i915: fix the SDE irq dmesg warnings properly
>
> Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
> Reference: http://mid.gmane.org/20151213124945.GA5715@nuc-i3427.alporthouse.com
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92084
> Cc: drm-intel-fixes@lists.freedesktop.org
> Fixes: 820da7ae4633 ("Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"")
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Oh well, agreed it's time to give up :(
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 3f8c753997ba..fa8afa7860ae 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -2414,9 +2414,13 @@ static irqreturn_t gen8_irq_handler(int irq, void *arg)
> spt_irq_handler(dev, pch_iir);
> else
> cpt_irq_handler(dev, pch_iir);
> - } else
> - DRM_ERROR("The master control interrupt lied (SDE)!\n");
> -
> + } else {
> + /*
> + * Like on previous PCH there seems to be something
> + * fishy going on with forwarding PCH interrupts.
> + */
> + DRM_DEBUG_DRIVER("The master control interrupt lied (SDE)!\n");
> + }
> }
>
> I915_WRITE_FW(GEN8_MASTER_IRQ, GEN8_MASTER_IRQ_CONTROL);
> --
> 2.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: shut up gen8+ SDE irq dmesg noise, again
2016-01-07 9:32 ` Daniel Vetter
@ 2016-01-07 9:57 ` Jani Nikula
2016-01-07 12:13 ` Josh Boyer
0 siblings, 1 reply; 5+ messages in thread
From: Jani Nikula @ 2016-01-07 9:57 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx, drm-intel-fixes
On Thu, 07 Jan 2016, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, Jan 07, 2016 at 10:29:10AM +0200, Jani Nikula wrote:
>> We still keep getting
>>
>> [ 4.249930] [drm:gen8_irq_handler [i915]] *ERROR* The master control interrupt lied (SDE)!
>>
>> This reverts
>>
>> commit 820da7ae46332fa709b171eb7ba57cbd023fa6df
>> Author: Jani Nikula <jani.nikula@intel.com>
>> Date: Wed Nov 25 16:47:23 2015 +0200
>>
>> Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"
>>
>> which in itself is a revert, so this is just doing
>>
>> commit 97e5ed1111dcc5300a0f59a55248cd243937a8ab
>> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Date: Fri Oct 23 10:56:12 2015 +0200
>>
>> drm/i915: shut up gen8+ SDE irq dmesg noise
>>
>> all over again. I'll stop pretending I understand what's going on like I
>> did when I thought I'd fixed this for good in
>>
>> commit 6a39d7c986be4fd18eb019e9cdbf774ec36c9f77
>> Author: Jani Nikula <jani.nikula@intel.com>
>> Date: Wed Nov 25 16:47:22 2015 +0200
>>
>> drm/i915: fix the SDE irq dmesg warnings properly
>>
>> Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Reference: http://mid.gmane.org/20151213124945.GA5715@nuc-i3427.alporthouse.com
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92084
>> Cc: drm-intel-fixes@lists.freedesktop.org
>> Fixes: 820da7ae4633 ("Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"")
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Oh well, agreed it's time to give up :(
>
> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Thanks, pushed to drm-intel-next-queued.
BR,
Jani.
>> ---
>> drivers/gpu/drm/i915/i915_irq.c | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
>> index 3f8c753997ba..fa8afa7860ae 100644
>> --- a/drivers/gpu/drm/i915/i915_irq.c
>> +++ b/drivers/gpu/drm/i915/i915_irq.c
>> @@ -2414,9 +2414,13 @@ static irqreturn_t gen8_irq_handler(int irq, void *arg)
>> spt_irq_handler(dev, pch_iir);
>> else
>> cpt_irq_handler(dev, pch_iir);
>> - } else
>> - DRM_ERROR("The master control interrupt lied (SDE)!\n");
>> -
>> + } else {
>> + /*
>> + * Like on previous PCH there seems to be something
>> + * fishy going on with forwarding PCH interrupts.
>> + */
>> + DRM_DEBUG_DRIVER("The master control interrupt lied (SDE)!\n");
>> + }
>> }
>>
>> I915_WRITE_FW(GEN8_MASTER_IRQ, GEN8_MASTER_IRQ_CONTROL);
>> --
>> 2.1.4
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/i915: shut up gen8+ SDE irq dmesg noise, again
2016-01-07 9:57 ` Jani Nikula
@ 2016-01-07 12:13 ` Josh Boyer
0 siblings, 0 replies; 5+ messages in thread
From: Josh Boyer @ 2016-01-07 12:13 UTC (permalink / raw)
To: Jani Nikula; +Cc: Intel Graphics Development, drm-intel-fixes
On Thu, Jan 7, 2016 at 4:57 AM, Jani Nikula <jani.nikula@intel.com> wrote:
> On Thu, 07 Jan 2016, Daniel Vetter <daniel@ffwll.ch> wrote:
>> On Thu, Jan 07, 2016 at 10:29:10AM +0200, Jani Nikula wrote:
>>> We still keep getting
>>>
>>> [ 4.249930] [drm:gen8_irq_handler [i915]] *ERROR* The master control interrupt lied (SDE)!
>>>
>>> This reverts
>>>
>>> commit 820da7ae46332fa709b171eb7ba57cbd023fa6df
>>> Author: Jani Nikula <jani.nikula@intel.com>
>>> Date: Wed Nov 25 16:47:23 2015 +0200
>>>
>>> Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"
>>>
>>> which in itself is a revert, so this is just doing
>>>
>>> commit 97e5ed1111dcc5300a0f59a55248cd243937a8ab
>>> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
>>> Date: Fri Oct 23 10:56:12 2015 +0200
>>>
>>> drm/i915: shut up gen8+ SDE irq dmesg noise
>>>
>>> all over again. I'll stop pretending I understand what's going on like I
>>> did when I thought I'd fixed this for good in
>>>
>>> commit 6a39d7c986be4fd18eb019e9cdbf774ec36c9f77
>>> Author: Jani Nikula <jani.nikula@intel.com>
>>> Date: Wed Nov 25 16:47:22 2015 +0200
>>>
>>> drm/i915: fix the SDE irq dmesg warnings properly
>>>
>>> Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> Reference: http://mid.gmane.org/20151213124945.GA5715@nuc-i3427.alporthouse.com
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92084
>>> Cc: drm-intel-fixes@lists.freedesktop.org
>>> Fixes: 820da7ae4633 ("Revert "drm/i915: shut up gen8+ SDE irq dmesg noise"")
>>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>> Oh well, agreed it's time to give up :(
>>
>> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> Thanks, pushed to drm-intel-next-queued.
Given people still see this on 4.3.y and what will soon be 4.4 final,
which is a long term stable release, should it be CC'd to stable?
josh
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-07 12:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-07 8:29 [PATCH] drm/i915: shut up gen8+ SDE irq dmesg noise, again Jani Nikula
2016-01-07 9:23 ` Chris Wilson
2016-01-07 9:32 ` Daniel Vetter
2016-01-07 9:57 ` Jani Nikula
2016-01-07 12:13 ` Josh Boyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox