intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Cleaning up DDI translation tables
@ 2016-01-05 19:18 Rodrigo Vivi
  2016-01-06 11:30 ` ✗ failure: Fi.CI.BAT Patchwork
  2016-01-07 16:37 ` [PATCH] drm/i915: Cleaning up DDI translation tables Ville Syrjälä
  0 siblings, 2 replies; 3+ messages in thread
From: Rodrigo Vivi @ 2016-01-05 19:18 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

No functional changes.

That state the obvious and just duplicate the place we
need to change whenever the table is updated. So let's clean it.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index bc8a497..d3611f5 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -133,12 +133,12 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = {
 	{ 0x00002016, 0x000000A0, 0x0 },
 	{ 0x00005012, 0x0000009B, 0x0 },
 	{ 0x00007011, 0x00000088, 0x0 },
-	{ 0x80009010, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
+	{ 0x80009010, 0x000000C0, 0x1 },
 	{ 0x00002016, 0x0000009B, 0x0 },
 	{ 0x00005012, 0x00000088, 0x0 },
-	{ 0x80007011, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
+	{ 0x80007011, 0x000000C0, 0x1 },
 	{ 0x00002016, 0x000000DF, 0x0 },
-	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
+	{ 0x80005012, 0x000000C0, 0x1 },
 };
 
 /* Skylake U */
@@ -146,12 +146,12 @@ static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
 	{ 0x0000201B, 0x000000A2, 0x0 },
 	{ 0x00005012, 0x00000088, 0x0 },
 	{ 0x80007011, 0x000000CD, 0x0 },
-	{ 0x80009010, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
+	{ 0x80009010, 0x000000C0, 0x1 },
 	{ 0x0000201B, 0x0000009D, 0x0 },
-	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
-	{ 0x80007011, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
+	{ 0x80005012, 0x000000C0, 0x1 },
+	{ 0x80007011, 0x000000C0, 0x1 },
 	{ 0x00002016, 0x00000088, 0x0 },
-	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
+	{ 0x80005012, 0x000000C0, 0x1 },
 };
 
 /* Skylake Y */
@@ -159,12 +159,12 @@ static const struct ddi_buf_trans skl_y_ddi_translations_dp[] = {
 	{ 0x00000018, 0x000000A2, 0x0 },
 	{ 0x00005012, 0x00000088, 0x0 },
 	{ 0x80007011, 0x000000CD, 0x0 },
-	{ 0x80009010, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
+	{ 0x80009010, 0x000000C0, 0x3 },
 	{ 0x00000018, 0x0000009D, 0x0 },
-	{ 0x80005012, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
-	{ 0x80007011, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
+	{ 0x80005012, 0x000000C0, 0x3 },
+	{ 0x80007011, 0x000000C0, 0x3 },
 	{ 0x00000018, 0x00000088, 0x0 },
-	{ 0x80005012, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
+	{ 0x80005012, 0x000000C0, 0x3 },
 };
 
 /*
-- 
2.4.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* ✗ failure: Fi.CI.BAT
  2016-01-05 19:18 [PATCH] drm/i915: Cleaning up DDI translation tables Rodrigo Vivi
@ 2016-01-06 11:30 ` Patchwork
  2016-01-07 16:37 ` [PATCH] drm/i915: Cleaning up DDI translation tables Ville Syrjälä
  1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2016-01-06 11:30 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: intel-gfx

== Summary ==

HEAD is now at 89d0d1b drm-intel-nightly: 2016y-01m-06d-10h-37m-17s UTC integration manifest
Applying: drm/i915: Cleaning up DDI translation tables
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 drm/i915: Cleaning up DDI translation tables

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/i915: Cleaning up DDI translation tables
  2016-01-05 19:18 [PATCH] drm/i915: Cleaning up DDI translation tables Rodrigo Vivi
  2016-01-06 11:30 ` ✗ failure: Fi.CI.BAT Patchwork
@ 2016-01-07 16:37 ` Ville Syrjälä
  1 sibling, 0 replies; 3+ messages in thread
From: Ville Syrjälä @ 2016-01-07 16:37 UTC (permalink / raw)
  To: Rodrigo Vivi; +Cc: intel-gfx

On Tue, Jan 05, 2016 at 11:18:55AM -0800, Rodrigo Vivi wrote:
> No functional changes.
> 
> That state the obvious and just duplicate the place we
> need to change whenever the table is updated. So let's clean it.
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index bc8a497..d3611f5 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -133,12 +133,12 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = {
>  	{ 0x00002016, 0x000000A0, 0x0 },
>  	{ 0x00005012, 0x0000009B, 0x0 },
>  	{ 0x00007011, 0x00000088, 0x0 },
> -	{ 0x80009010, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
> +	{ 0x80009010, 0x000000C0, 0x1 },
>  	{ 0x00002016, 0x0000009B, 0x0 },
>  	{ 0x00005012, 0x00000088, 0x0 },
> -	{ 0x80007011, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
> +	{ 0x80007011, 0x000000C0, 0x1 },
>  	{ 0x00002016, 0x000000DF, 0x0 },
> -	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
> +	{ 0x80005012, 0x000000C0, 0x1 },
>  };
>  
>  /* Skylake U */
> @@ -146,12 +146,12 @@ static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
>  	{ 0x0000201B, 0x000000A2, 0x0 },
>  	{ 0x00005012, 0x00000088, 0x0 },
>  	{ 0x80007011, 0x000000CD, 0x0 },
> -	{ 0x80009010, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
> +	{ 0x80009010, 0x000000C0, 0x1 },
>  	{ 0x0000201B, 0x0000009D, 0x0 },
> -	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
> -	{ 0x80007011, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
> +	{ 0x80005012, 0x000000C0, 0x1 },
> +	{ 0x80007011, 0x000000C0, 0x1 },
>  	{ 0x00002016, 0x00000088, 0x0 },
> -	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
> +	{ 0x80005012, 0x000000C0, 0x1 },
>  };
>  
>  /* Skylake Y */
> @@ -159,12 +159,12 @@ static const struct ddi_buf_trans skl_y_ddi_translations_dp[] = {
>  	{ 0x00000018, 0x000000A2, 0x0 },
>  	{ 0x00005012, 0x00000088, 0x0 },
>  	{ 0x80007011, 0x000000CD, 0x0 },
> -	{ 0x80009010, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
> +	{ 0x80009010, 0x000000C0, 0x3 },
>  	{ 0x00000018, 0x0000009D, 0x0 },
> -	{ 0x80005012, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
> -	{ 0x80007011, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
> +	{ 0x80005012, 0x000000C0, 0x3 },
> +	{ 0x80007011, 0x000000C0, 0x3 },
>  	{ 0x00000018, 0x00000088, 0x0 },
> -	{ 0x80005012, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
> +	{ 0x80005012, 0x000000C0, 0x3 },
>  };
>  
>  /*
> -- 
> 2.4.3

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-01-07 16:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-05 19:18 [PATCH] drm/i915: Cleaning up DDI translation tables Rodrigo Vivi
2016-01-06 11:30 ` ✗ failure: Fi.CI.BAT Patchwork
2016-01-07 16:37 ` [PATCH] drm/i915: Cleaning up DDI translation tables Ville Syrjälä

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).