From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Update Skylake DDI translation table for HDMI.
Date: Thu, 7 Jan 2016 18:53:49 +0200 [thread overview]
Message-ID: <20160107165349.GM4437@intel.com> (raw)
In-Reply-To: <1452021087-21673-1-git-send-email-rodrigo.vivi@intel.com>
On Tue, Jan 05, 2016 at 11:11:27AM -0800, Rodrigo Vivi wrote:
> When debuging an intermittent corrupted screen I suspected on DDI
> translation table and checked we are out of date with the spec.
>
> I'm not sure this will fix my bug yet, but it is always good to follow
> the spec.
>
> v2: Ville caught a switched i-boost value. Thanks!
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index e6408e5..ff7db85 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -226,26 +226,26 @@ static const struct ddi_buf_trans skl_ddi_translations_hdmi[] = {
> { 0x00000018, 0x000000A1, 0x0 },
> { 0x00000018, 0x00000098, 0x0 },
> { 0x00004013, 0x00000088, 0x0 },
> - { 0x00006012, 0x00000087, 0x0 },
> + { 0x80006012, 0x000000CD, 0x1 },
> { 0x00000018, 0x000000DF, 0x0 },
> - { 0x00003015, 0x00000087, 0x0 }, /* Default */
> - { 0x00003015, 0x000000C7, 0x0 },
> - { 0x00000018, 0x000000C7, 0x0 },
> + { 0x80003015, 0x000000CD, 0x1 }, /* Default */
> + { 0x80003015, 0x000000C0, 0x1 },
> + { 0x80000018, 0x000000C0, 0x1 },
> };
>
> /* Skylake Y */
> static const struct ddi_buf_trans skl_y_ddi_translations_hdmi[] = {
> { 0x00000018, 0x000000A1, 0x0 },
> { 0x00005012, 0x000000DF, 0x0 },
> - { 0x00007011, 0x00000084, 0x0 },
> + { 0x80007011, 0x000000CB, 0x3 },
> { 0x00000018, 0x000000A4, 0x0 },
> { 0x00000018, 0x0000009D, 0x0 },
> { 0x00004013, 0x00000080, 0x0 },
> - { 0x00006013, 0x000000C7, 0x0 },
> + { 0x80006013, 0x000000C0, 0x3 },
> { 0x00000018, 0x0000008A, 0x0 },
> - { 0x00003015, 0x000000C7, 0x0 }, /* Default */
> - { 0x80003015, 0x000000C7, 0x7 }, /* Uses I_boost level 0x7 */
> - { 0x00000018, 0x000000C7, 0x0 },
> + { 0x80003015, 0x000000C0, 0x3 }, /* Default */
> + { 0x80003015, 0x000000C0, 0x3 },
> + { 0x80000018, 0x000000C0, 0x3 },
> };
>
> struct bxt_ddi_buf_trans {
> --
> 2.4.3
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-07 16:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 15:32 [PATCH] drm/i915: Update Skylake DDI translation table for HDMI Rodrigo Vivi
2016-01-05 17:49 ` ✗ warning: Fi.CI.BAT Patchwork
2016-01-05 18:39 ` [PATCH] drm/i915: Update Skylake DDI translation table for HDMI Ville Syrjälä
2016-01-05 18:47 ` Vivi, Rodrigo
2016-01-05 19:11 ` Rodrigo Vivi
2016-01-07 16:53 ` Ville Syrjälä [this message]
2016-01-06 9:49 ` ✓ success: Fi.CI.BAT Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107165349.GM4437@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).