From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH] drm/i915/skl: Use proper plane dimensions for DDB and WM calculations Date: Fri, 8 Jan 2016 18:09:16 -0800 Message-ID: <20160109020915.GJ21100@intel.com> References: <1450711877-18753-1-git-send-email-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 72E17898E1 for ; Fri, 8 Jan 2016 18:09:29 -0800 (PST) Content-Disposition: inline In-Reply-To: <1450711877-18753-1-git-send-email-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: "Kondapally, Kalyan" , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBEZWMgMjEsIDIwMTUgYXQgMDc6MzE6MTdBTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBJbiBjb21taXQKPiAKPiAgICAgICAgIGNvbW1pdCAwMjRjOTA0NTIyMWZlNDU0ODI4NjNj NDdjNGI0YzQ3ZDM3Zjk3Y2JmCj4gICAgICAgICBBdXRob3I6IE1hdHQgUm9wZXIgPG1hdHRoZXcu ZC5yb3BlckBpbnRlbC5jb20+Cj4gICAgICAgICBEYXRlOiAgIFRodSBTZXAgMjQgMTU6NTM6MTEg MjAxNSAtMDcwMAo+IAo+ICAgICAgICAgICAgIGRybS9pOTE1L3NrbDogRWxpbWluYXRlIHVzYWdl IG9mIHBpcGVfd21fcGFyYW1ldGVycyBmcm9tIFNLTC1zdHlsZSBXTSAodjQpCj4gCj4gSSBmdW1i bGVkIHdoaWxlIGNvbnZlcnRpbmcgdGhlIGRpbWVuc2lvbnMgc3RvcmVkIGluIHRoZSBwbGFuZV9w YXJhbWV0ZXJzCj4gc3RydWN0dXJlIHRvIHRoZSB2YWx1ZXMgc3RvcmVkIGluIHBsYW5lIHN0YXRl IGFuZCBhY2NpZGVudGFsbHkgcmVwbGFjZWQKPiB0aGUgcGxhbmUgZGltZW5zaW9ucyB3aXRoIHRo ZSBwaXBlIGRpbWVuc2lvbnMgaW4gYm90aCB0aGUgRERCIGFsbG9jYXRpb24KPiBmdW5jdGlvbiBh bmQgdGhlIFdNIGNhbGN1bGF0aW9uIGZ1bmN0aW9uLiAgT24gdGhlIEREQiBzaWRlIHRoaXMgaXMK PiBoYXJtbGVzcyBzaW5jZSB3ZSBlZmZlY3RpdmVseSB0cmVhdCBhbGwgb2Ygb3VyIG5vbi1jdXJz b3IgcGxhbmVzIGFzCj4gZnVsbC1zY3JlZW4gd2hpY2ggbWF5IG5vdCBiZSBvcHRpbWFsLCBidXQg Z2VuZXJhbGx5IHdvbid0IGNhdXNlIGFueQo+IHByb2JsZW1zIGVpdGhlciAoYW5kIGluIDk5JSBv ZiB0aGUgY2FzZXMgd2hlcmUgdGhlcmUncyBubyBzcHJpdGUgcGxhbmUKPiB1c2FnZSBvciBwcmlt YXJ5IHBsYW5lIHdpbmRvd2luZywgdGhlcmUncyBubyBlZmZlY3QgYXQgYWxsKS4gIE9uIHRoZSBX TQo+IGNhbGN1bGF0aW9uIHNpZGUgdGhlcmUncyBtb3JlIHBvdGVudGlhbCBmb3IgdGhpcyBmdW1i bGUgdG8gY2F1c2UgYWN0dWFsCj4gcHJvYmxlbXMgc2luY2UgY3Vyc29ycyBhbHNvIGdldCBtaXNj YWxjdWxhdGVkLgo+IAo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAaW50ZWwu Y29tPgo+IENjOiAiS29uZGFwYWxseSwgS2FseWFuIiA8a2FseWFuLmtvbmRhcGFsbHlAaW50ZWwu Y29tPgo+IENjOiBSYWRoYWtyaXNobmEgU3JpcGFkYSA8cmFkaGFrcmlzaG5hLnNyaXBhZGFAaW50 ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRl bC5jb20+CgpCdW1wOyBJIHRoaW5rIHRoaXMgcGF0Y2ggZ290IGxvc3QgaW4gdGhlIG1peCB3aGls ZSBtb3N0IHBlb3BsZSB3ZXJlIG91dApvdmVyIHRoZSBob2xpZGF5IGJyZWFrLgoKCk1hdHQKCj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCAyNCArKysrKysrKysrKysr LS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDExIGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+IGluZGV4IDhkMGQ2ZjUuLmY0ZDRj YzcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBAQCAtMjg0NSwyNSArMjg0NSwyMiBA QCBza2xfcGxhbmVfcmVsYXRpdmVfZGF0YV9yYXRlKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlICpjc3RhdGUsCj4gIAkJCSAgICAgY29uc3Qgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqcHN0 YXRlLAo+ICAJCQkgICAgIGludCB5KQo+ICB7Cj4gLQlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxf Y3J0YyA9IHRvX2ludGVsX2NydGMoY3N0YXRlLT5iYXNlLmNydGMpOwo+ICsJc3RydWN0IGludGVs X3BsYW5lX3N0YXRlICppbnRlbF9wc3RhdGUgPSB0b19pbnRlbF9wbGFuZV9zdGF0ZShwc3RhdGUp Owo+ICAJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBwc3RhdGUtPmZiOwo+ICsJdW5zaWdu ZWQgdyA9IGRybV9yZWN0X3dpZHRoKCZpbnRlbF9wc3RhdGUtPmRzdCk7Cj4gKwl1bnNpZ25lZCBo ID0gZHJtX3JlY3RfaGVpZ2h0KCZpbnRlbF9wc3RhdGUtPmRzdCk7Cj4gIAo+ICAJLyogZm9yIHBs YW5hciBmb3JtYXQgKi8KPiAgCWlmIChmYi0+cGl4ZWxfZm9ybWF0ID09IERSTV9GT1JNQVRfTlYx Mikgewo+ICAJCWlmICh5KSAgLyogeS1wbGFuZSBkYXRhIHJhdGUgKi8KPiAtCQkJcmV0dXJuIGlu dGVsX2NydGMtPmNvbmZpZy0+cGlwZV9zcmNfdyAqCj4gLQkJCQlpbnRlbF9jcnRjLT5jb25maWct PnBpcGVfc3JjX2ggKgo+IC0JCQkJZHJtX2Zvcm1hdF9wbGFuZV9jcHAoZmItPnBpeGVsX2Zvcm1h dCwgMCk7Cj4gKwkJCXJldHVybiB3ICogaCAqIGRybV9mb3JtYXRfcGxhbmVfY3BwKGZiLT5waXhl bF9mb3JtYXQsIDApOwo+ICAJCWVsc2UgICAgLyogdXYtcGxhbmUgZGF0YSByYXRlICovCj4gLQkJ CXJldHVybiAoaW50ZWxfY3J0Yy0+Y29uZmlnLT5waXBlX3NyY193LzIpICoKPiAtCQkJCShpbnRl bF9jcnRjLT5jb25maWctPnBpcGVfc3JjX2gvMikgKgo+ICsJCQlyZXR1cm4gKHcvMikgKiAoaC8y KSAqCj4gIAkJCQlkcm1fZm9ybWF0X3BsYW5lX2NwcChmYi0+cGl4ZWxfZm9ybWF0LCAxKTsKPiAg CX0KPiAgCj4gIAkvKiBmb3IgcGFja2VkIGZvcm1hdHMgKi8KPiAtCXJldHVybiBpbnRlbF9jcnRj LT5jb25maWctPnBpcGVfc3JjX3cgKgo+IC0JCWludGVsX2NydGMtPmNvbmZpZy0+cGlwZV9zcmNf aCAqCj4gLQkJZHJtX2Zvcm1hdF9wbGFuZV9jcHAoZmItPnBpeGVsX2Zvcm1hdCwgMCk7Cj4gKwly ZXR1cm4gdyAqIGggKiBkcm1fZm9ybWF0X3BsYW5lX2NwcChmYi0+cGl4ZWxfZm9ybWF0LCAwKTsK PiAgfQo+ICAKPiAgLyoKPiBAQCAtMjk2MCw2ICsyOTU3LDggQEAgc2tsX2FsbG9jYXRlX3BpcGVf ZGRiKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4gIAkgKiBGSVhNRTogd2UgbWF5 IG5vdCBhbGxvY2F0ZSBldmVyeSBzaW5nbGUgYmxvY2sgaGVyZS4KPiAgCSAqLwo+ICAJdG90YWxf ZGF0YV9yYXRlID0gc2tsX2dldF90b3RhbF9yZWxhdGl2ZV9kYXRhX3JhdGUoY3N0YXRlKTsKPiAr CWlmICghdG90YWxfZGF0YV9yYXRlKQo+ICsJCXJldHVybjsKPiAgCj4gIAlzdGFydCA9IGFsbG9j LT5zdGFydDsKPiAgCWZvcl9lYWNoX2ludGVsX3BsYW5lX29uX2NydGMoZGV2LCBpbnRlbF9jcnRj LCBpbnRlbF9wbGFuZSkgewo+IEBAIC0zMDkzLDEyICszMDkyLDE1IEBAIHN0YXRpYyBib29sIHNr bF9jb21wdXRlX3BsYW5lX3dtKGNvbnN0IHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPiAgewo+ICAJc3RydWN0IGRybV9wbGFuZSAqcGxhbmUgPSAmaW50ZWxfcGxhbmUtPmJhc2U7 Cj4gIAlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IHBsYW5lLT5zdGF0ZS0+ZmI7Cj4gKwlz dHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKmludGVsX3BzdGF0ZSA9Cj4gKwkJdG9faW50ZWxfcGxh bmVfc3RhdGUocGxhbmUtPnN0YXRlKTsKPiAgCXVpbnQzMl90IGxhdGVuY3kgPSBkZXZfcHJpdi0+ d20uc2tsX2xhdGVuY3lbbGV2ZWxdOwo+ICAJdWludDMyX3QgbWV0aG9kMSwgbWV0aG9kMjsKPiAg CXVpbnQzMl90IHBsYW5lX2J5dGVzX3Blcl9saW5lLCBwbGFuZV9ibG9ja3NfcGVyX2xpbmU7Cj4g IAl1aW50MzJfdCByZXNfYmxvY2tzLCByZXNfbGluZXM7Cj4gIAl1aW50MzJfdCBzZWxlY3RlZF9y ZXN1bHQ7Cj4gIAl1aW50OF90IGJ5dGVzX3Blcl9waXhlbDsKPiArCXVuc2lnbmVkIHcgPSBkcm1f cmVjdF93aWR0aCgmaW50ZWxfcHN0YXRlLT5kc3QpOwo+ICAKPiAgCWlmIChsYXRlbmN5ID09IDAg fHwgIWNzdGF0ZS0+YmFzZS5hY3RpdmUgfHwgIWZiKQo+ICAJCXJldHVybiBmYWxzZTsKPiBAQCAt MzEwOSwxMiArMzExMSwxMiBAQCBzdGF0aWMgYm9vbCBza2xfY29tcHV0ZV9wbGFuZV93bShjb25z dCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCQkgbGF0ZW5jeSk7Cj4g IAltZXRob2QyID0gc2tsX3dtX21ldGhvZDIoc2tsX3BpcGVfcGl4ZWxfcmF0ZShjc3RhdGUpLAo+ ICAJCQkJIGNzdGF0ZS0+YmFzZS5hZGp1c3RlZF9tb2RlLmNydGNfaHRvdGFsLAo+IC0JCQkJIGNz dGF0ZS0+cGlwZV9zcmNfdywKPiArCQkJCSB3LAo+ICAJCQkJIGJ5dGVzX3Blcl9waXhlbCwKPiAg CQkJCSBmYi0+bW9kaWZpZXJbMF0sCj4gIAkJCQkgbGF0ZW5jeSk7Cj4gIAo+IC0JcGxhbmVfYnl0 ZXNfcGVyX2xpbmUgPSBjc3RhdGUtPnBpcGVfc3JjX3cgKiBieXRlc19wZXJfcGl4ZWw7Cj4gKwlw bGFuZV9ieXRlc19wZXJfbGluZSA9IHcgKiBieXRlc19wZXJfcGl4ZWw7Cj4gIAlwbGFuZV9ibG9j a3NfcGVyX2xpbmUgPSBESVZfUk9VTkRfVVAocGxhbmVfYnl0ZXNfcGVyX2xpbmUsIDUxMik7Cj4g IAo+ICAJaWYgKGZiLT5tb2RpZmllclswXSA9PSBJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRCB8fAo+ IC0tIAo+IDIuMS40Cj4gCgotLSAKTWF0dCBSb3BlcgpHcmFwaGljcyBTb2Z0d2FyZSBFbmdpbmVl cgpJb1RHIFBsYXRmb3JtIEVuYWJsaW5nICYgRGV2ZWxvcG1lbnQKSW50ZWwgQ29ycG9yYXRpb24K KDkxNikgMzU2LTI3OTUKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK