From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/skl: Use proper plane dimensions for DDB and WM calculations Date: Mon, 11 Jan 2016 21:31:03 +0200 Message-ID: <20160111193103.GN23290@intel.com> References: <1450711877-18753-1-git-send-email-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id D97BE6E571 for ; Mon, 11 Jan 2016 11:31:07 -0800 (PST) Content-Disposition: inline In-Reply-To: <1450711877-18753-1-git-send-email-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: "Kondapally, Kalyan" , intel-gfx@lists.freedesktop.org, Ville =?iso-8859-1?Q?Syrj=E4l=E4?= List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBEZWMgMjEsIDIwMTUgYXQgMDc6MzE6MTdBTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBJbiBjb21taXQKPiAKPiAgICAgICAgIGNvbW1pdCAwMjRjOTA0NTIyMWZlNDU0ODI4NjNj NDdjNGI0YzQ3ZDM3Zjk3Y2JmCj4gICAgICAgICBBdXRob3I6IE1hdHQgUm9wZXIgPG1hdHRoZXcu ZC5yb3BlckBpbnRlbC5jb20+Cj4gICAgICAgICBEYXRlOiAgIFRodSBTZXAgMjQgMTU6NTM6MTEg MjAxNSAtMDcwMAo+IAo+ICAgICAgICAgICAgIGRybS9pOTE1L3NrbDogRWxpbWluYXRlIHVzYWdl IG9mIHBpcGVfd21fcGFyYW1ldGVycyBmcm9tIFNLTC1zdHlsZSBXTSAodjQpCj4gCj4gSSBmdW1i bGVkIHdoaWxlIGNvbnZlcnRpbmcgdGhlIGRpbWVuc2lvbnMgc3RvcmVkIGluIHRoZSBwbGFuZV9w YXJhbWV0ZXJzCj4gc3RydWN0dXJlIHRvIHRoZSB2YWx1ZXMgc3RvcmVkIGluIHBsYW5lIHN0YXRl IGFuZCBhY2NpZGVudGFsbHkgcmVwbGFjZWQKPiB0aGUgcGxhbmUgZGltZW5zaW9ucyB3aXRoIHRo ZSBwaXBlIGRpbWVuc2lvbnMgaW4gYm90aCB0aGUgRERCIGFsbG9jYXRpb24KPiBmdW5jdGlvbiBh bmQgdGhlIFdNIGNhbGN1bGF0aW9uIGZ1bmN0aW9uLiAgT24gdGhlIEREQiBzaWRlIHRoaXMgaXMK PiBoYXJtbGVzcyBzaW5jZSB3ZSBlZmZlY3RpdmVseSB0cmVhdCBhbGwgb2Ygb3VyIG5vbi1jdXJz b3IgcGxhbmVzIGFzCj4gZnVsbC1zY3JlZW4gd2hpY2ggbWF5IG5vdCBiZSBvcHRpbWFsLCBidXQg Z2VuZXJhbGx5IHdvbid0IGNhdXNlIGFueQo+IHByb2JsZW1zIGVpdGhlciAoYW5kIGluIDk5JSBv ZiB0aGUgY2FzZXMgd2hlcmUgdGhlcmUncyBubyBzcHJpdGUgcGxhbmUKPiB1c2FnZSBvciBwcmlt YXJ5IHBsYW5lIHdpbmRvd2luZywgdGhlcmUncyBubyBlZmZlY3QgYXQgYWxsKS4gIE9uIHRoZSBX TQo+IGNhbGN1bGF0aW9uIHNpZGUgdGhlcmUncyBtb3JlIHBvdGVudGlhbCBmb3IgdGhpcyBmdW1i bGUgdG8gY2F1c2UgYWN0dWFsCj4gcHJvYmxlbXMgc2luY2UgY3Vyc29ycyBhbHNvIGdldCBtaXNj YWxjdWxhdGVkLgo+IAo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAaW50ZWwu Y29tPgo+IENjOiAiS29uZGFwYWxseSwgS2FseWFuIiA8a2FseWFuLmtvbmRhcGFsbHlAaW50ZWwu Y29tPgo+IENjOiBSYWRoYWtyaXNobmEgU3JpcGFkYSA8cmFkaGFrcmlzaG5hLnNyaXBhZGFAaW50 ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE1hdHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRl bC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCAyNCArKysr KysrKysrKysrLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyks IDExIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9wbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+IGluZGV4IDhkMGQ2 ZjUuLmY0ZDRjYzcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0u Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBAQCAtMjg0NSwyNSAr Mjg0NSwyMiBAQCBza2xfcGxhbmVfcmVsYXRpdmVfZGF0YV9yYXRlKGNvbnN0IHN0cnVjdCBpbnRl bF9jcnRjX3N0YXRlICpjc3RhdGUsCj4gIAkJCSAgICAgY29uc3Qgc3RydWN0IGRybV9wbGFuZV9z dGF0ZSAqcHN0YXRlLAo+ICAJCQkgICAgIGludCB5KQo+ICB7Cj4gLQlzdHJ1Y3QgaW50ZWxfY3J0 YyAqaW50ZWxfY3J0YyA9IHRvX2ludGVsX2NydGMoY3N0YXRlLT5iYXNlLmNydGMpOwo+ICsJc3Ry dWN0IGludGVsX3BsYW5lX3N0YXRlICppbnRlbF9wc3RhdGUgPSB0b19pbnRlbF9wbGFuZV9zdGF0 ZShwc3RhdGUpOwo+ICAJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBwc3RhdGUtPmZiOwo+ ICsJdW5zaWduZWQgdyA9IGRybV9yZWN0X3dpZHRoKCZpbnRlbF9wc3RhdGUtPmRzdCk7Cj4gKwl1 bnNpZ25lZCBoID0gZHJtX3JlY3RfaGVpZ2h0KCZpbnRlbF9wc3RhdGUtPmRzdCk7CgpJIHRoaW5r IHlvdSdyZSBzdXBwb3NlZCB0byB1c2UgdGhlIHNyYyBkaW1lbnNpb25zIGluIG1vc3QgcGxhY2Vz LgoKPiAgCj4gIAkvKiBmb3IgcGxhbmFyIGZvcm1hdCAqLwo+ICAJaWYgKGZiLT5waXhlbF9mb3Jt YXQgPT0gRFJNX0ZPUk1BVF9OVjEyKSB7Cj4gIAkJaWYgKHkpICAvKiB5LXBsYW5lIGRhdGEgcmF0 ZSAqLwo+IC0JCQlyZXR1cm4gaW50ZWxfY3J0Yy0+Y29uZmlnLT5waXBlX3NyY193ICoKPiAtCQkJ CWludGVsX2NydGMtPmNvbmZpZy0+cGlwZV9zcmNfaCAqCj4gLQkJCQlkcm1fZm9ybWF0X3BsYW5l X2NwcChmYi0+cGl4ZWxfZm9ybWF0LCAwKTsKPiArCQkJcmV0dXJuIHcgKiBoICogZHJtX2Zvcm1h dF9wbGFuZV9jcHAoZmItPnBpeGVsX2Zvcm1hdCwgMCk7Cj4gIAkJZWxzZSAgICAvKiB1di1wbGFu ZSBkYXRhIHJhdGUgKi8KPiAtCQkJcmV0dXJuIChpbnRlbF9jcnRjLT5jb25maWctPnBpcGVfc3Jj X3cvMikgKgo+IC0JCQkJKGludGVsX2NydGMtPmNvbmZpZy0+cGlwZV9zcmNfaC8yKSAqCj4gKwkJ CXJldHVybiAody8yKSAqIChoLzIpICoKPiAgCQkJCWRybV9mb3JtYXRfcGxhbmVfY3BwKGZiLT5w aXhlbF9mb3JtYXQsIDEpOwo+ICAJfQo+ICAKPiAgCS8qIGZvciBwYWNrZWQgZm9ybWF0cyAqLwo+ IC0JcmV0dXJuIGludGVsX2NydGMtPmNvbmZpZy0+cGlwZV9zcmNfdyAqCj4gLQkJaW50ZWxfY3J0 Yy0+Y29uZmlnLT5waXBlX3NyY19oICoKPiAtCQlkcm1fZm9ybWF0X3BsYW5lX2NwcChmYi0+cGl4 ZWxfZm9ybWF0LCAwKTsKPiArCXJldHVybiB3ICogaCAqIGRybV9mb3JtYXRfcGxhbmVfY3BwKGZi LT5waXhlbF9mb3JtYXQsIDApOwo+ICB9Cj4gIAo+ICAvKgo+IEBAIC0yOTYwLDYgKzI5NTcsOCBA QCBza2xfYWxsb2NhdGVfcGlwZV9kZGIoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNzdGF0ZSwK PiAgCSAqIEZJWE1FOiB3ZSBtYXkgbm90IGFsbG9jYXRlIGV2ZXJ5IHNpbmdsZSBibG9jayBoZXJl Lgo+ICAJICovCj4gIAl0b3RhbF9kYXRhX3JhdGUgPSBza2xfZ2V0X3RvdGFsX3JlbGF0aXZlX2Rh dGFfcmF0ZShjc3RhdGUpOwo+ICsJaWYgKCF0b3RhbF9kYXRhX3JhdGUpCj4gKwkJcmV0dXJuOwo+ ICAKPiAgCXN0YXJ0ID0gYWxsb2MtPnN0YXJ0Owo+ICAJZm9yX2VhY2hfaW50ZWxfcGxhbmVfb25f Y3J0YyhkZXYsIGludGVsX2NydGMsIGludGVsX3BsYW5lKSB7Cj4gQEAgLTMwOTMsMTIgKzMwOTIs MTUgQEAgc3RhdGljIGJvb2wgc2tsX2NvbXB1dGVfcGxhbmVfd20oY29uc3Qgc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSA9 ICZpbnRlbF9wbGFuZS0+YmFzZTsKPiAgCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0gcGxh bmUtPnN0YXRlLT5mYjsKPiArCXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqaW50ZWxfcHN0YXRl ID0KPiArCQl0b19pbnRlbF9wbGFuZV9zdGF0ZShwbGFuZS0+c3RhdGUpOwo+ICAJdWludDMyX3Qg bGF0ZW5jeSA9IGRldl9wcml2LT53bS5za2xfbGF0ZW5jeVtsZXZlbF07Cj4gIAl1aW50MzJfdCBt ZXRob2QxLCBtZXRob2QyOwo+ICAJdWludDMyX3QgcGxhbmVfYnl0ZXNfcGVyX2xpbmUsIHBsYW5l X2Jsb2Nrc19wZXJfbGluZTsKPiAgCXVpbnQzMl90IHJlc19ibG9ja3MsIHJlc19saW5lczsKPiAg CXVpbnQzMl90IHNlbGVjdGVkX3Jlc3VsdDsKPiAgCXVpbnQ4X3QgYnl0ZXNfcGVyX3BpeGVsOwo+ ICsJdW5zaWduZWQgdyA9IGRybV9yZWN0X3dpZHRoKCZpbnRlbF9wc3RhdGUtPmRzdCk7Cj4gIAo+ ICAJaWYgKGxhdGVuY3kgPT0gMCB8fCAhY3N0YXRlLT5iYXNlLmFjdGl2ZSB8fCAhZmIpCj4gIAkJ cmV0dXJuIGZhbHNlOwo+IEBAIC0zMTA5LDEyICszMTExLDEyIEBAIHN0YXRpYyBib29sIHNrbF9j b21wdXRlX3BsYW5lX3dtKGNvbnN0IHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwK PiAgCQkJCSBsYXRlbmN5KTsKPiAgCW1ldGhvZDIgPSBza2xfd21fbWV0aG9kMihza2xfcGlwZV9w aXhlbF9yYXRlKGNzdGF0ZSksCj4gIAkJCQkgY3N0YXRlLT5iYXNlLmFkanVzdGVkX21vZGUuY3J0 Y19odG90YWwsCj4gLQkJCQkgY3N0YXRlLT5waXBlX3NyY193LAo+ICsJCQkJIHcsCj4gIAkJCQkg Ynl0ZXNfcGVyX3BpeGVsLAo+ICAJCQkJIGZiLT5tb2RpZmllclswXSwKPiAgCQkJCSBsYXRlbmN5 KTsKPiAgCj4gLQlwbGFuZV9ieXRlc19wZXJfbGluZSA9IGNzdGF0ZS0+cGlwZV9zcmNfdyAqIGJ5 dGVzX3Blcl9waXhlbDsKPiArCXBsYW5lX2J5dGVzX3Blcl9saW5lID0gdyAqIGJ5dGVzX3Blcl9w aXhlbDsKPiAgCXBsYW5lX2Jsb2Nrc19wZXJfbGluZSA9IERJVl9ST1VORF9VUChwbGFuZV9ieXRl c19wZXJfbGluZSwgNTEyKTsKPiAgCj4gIAlpZiAoZmItPm1vZGlmaWVyWzBdID09IEk5MTVfRk9S TUFUX01PRF9ZX1RJTEVEIHx8Cj4gLS0gCj4gMi4xLjQKPiAKPiBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRl bCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK