From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH] drm/i915/skl: Use proper plane dimensions for DDB and WM calculations Date: Mon, 11 Jan 2016 14:13:06 -0800 Message-ID: <20160111221306.GO21100@intel.com> References: <1450711877-18753-1-git-send-email-matthew.d.roper@intel.com> <20160111193103.GN23290@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D80F6E5BE for ; Mon, 11 Jan 2016 14:13:07 -0800 (PST) Content-Disposition: inline In-Reply-To: <20160111193103.GN23290@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: "Kondapally, Kalyan" , intel-gfx@lists.freedesktop.org, Ville =?iso-8859-1?Q?Syrj=E4l=E4?= List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKYW4gMTEsIDIwMTYgYXQgMDk6MzE6MDNQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIE1vbiwgRGVjIDIxLCAyMDE1IGF0IDA3OjMxOjE3QU0gLTA4MDAsIE1hdHQg Um9wZXIgd3JvdGU6Cj4gPiBJbiBjb21taXQKPiA+IAo+ID4gICAgICAgICBjb21taXQgMDI0Yzkw NDUyMjFmZTQ1NDgyODYzYzQ3YzRiNGM0N2QzN2Y5N2NiZgo+ID4gICAgICAgICBBdXRob3I6IE1h dHQgUm9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gPiAgICAgICAgIERhdGU6ICAg VGh1IFNlcCAyNCAxNTo1MzoxMSAyMDE1IC0wNzAwCj4gPiAKPiA+ICAgICAgICAgICAgIGRybS9p OTE1L3NrbDogRWxpbWluYXRlIHVzYWdlIG9mIHBpcGVfd21fcGFyYW1ldGVycyBmcm9tIFNLTC1z dHlsZSBXTSAodjQpCj4gPiAKPiA+IEkgZnVtYmxlZCB3aGlsZSBjb252ZXJ0aW5nIHRoZSBkaW1l bnNpb25zIHN0b3JlZCBpbiB0aGUgcGxhbmVfcGFyYW1ldGVycwo+ID4gc3RydWN0dXJlIHRvIHRo ZSB2YWx1ZXMgc3RvcmVkIGluIHBsYW5lIHN0YXRlIGFuZCBhY2NpZGVudGFsbHkgcmVwbGFjZWQK PiA+IHRoZSBwbGFuZSBkaW1lbnNpb25zIHdpdGggdGhlIHBpcGUgZGltZW5zaW9ucyBpbiBib3Ro IHRoZSBEREIgYWxsb2NhdGlvbgo+ID4gZnVuY3Rpb24gYW5kIHRoZSBXTSBjYWxjdWxhdGlvbiBm dW5jdGlvbi4gIE9uIHRoZSBEREIgc2lkZSB0aGlzIGlzCj4gPiBoYXJtbGVzcyBzaW5jZSB3ZSBl ZmZlY3RpdmVseSB0cmVhdCBhbGwgb2Ygb3VyIG5vbi1jdXJzb3IgcGxhbmVzIGFzCj4gPiBmdWxs LXNjcmVlbiB3aGljaCBtYXkgbm90IGJlIG9wdGltYWwsIGJ1dCBnZW5lcmFsbHkgd29uJ3QgY2F1 c2UgYW55Cj4gPiBwcm9ibGVtcyBlaXRoZXIgKGFuZCBpbiA5OSUgb2YgdGhlIGNhc2VzIHdoZXJl IHRoZXJlJ3Mgbm8gc3ByaXRlIHBsYW5lCj4gPiB1c2FnZSBvciBwcmltYXJ5IHBsYW5lIHdpbmRv d2luZywgdGhlcmUncyBubyBlZmZlY3QgYXQgYWxsKS4gIE9uIHRoZSBXTQo+ID4gY2FsY3VsYXRp b24gc2lkZSB0aGVyZSdzIG1vcmUgcG90ZW50aWFsIGZvciB0aGlzIGZ1bWJsZSB0byBjYXVzZSBh Y3R1YWwKPiA+IHByb2JsZW1zIHNpbmNlIGN1cnNvcnMgYWxzbyBnZXQgbWlzY2FsY3VsYXRlZC4K PiA+IAo+ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBpbnRlbC5jb20+Cj4g PiBDYzogIktvbmRhcGFsbHksIEthbHlhbiIgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4K PiA+IENjOiBSYWRoYWtyaXNobmEgU3JpcGFkYSA8cmFkaGFrcmlzaG5hLnNyaXBhZGFAaW50ZWwu Y29tPgo+ID4gU2lnbmVkLW9mZi1ieTogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVs LmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCAyNCAr KysrKysrKysrKysrLS0tLS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTMgaW5zZXJ0aW9u cygrKSwgMTEgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9wbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4g aW5kZXggOGQwZDZmNS4uZjRkNGNjNyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3BtLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMK PiA+IEBAIC0yODQ1LDI1ICsyODQ1LDIyIEBAIHNrbF9wbGFuZV9yZWxhdGl2ZV9kYXRhX3JhdGUo Y29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNzdGF0ZSwKPiA+ICAJCQkgICAgIGNvbnN0 IHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnBzdGF0ZSwKPiA+ICAJCQkgICAgIGludCB5KQo+ID4g IHsKPiA+IC0Jc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGNz dGF0ZS0+YmFzZS5jcnRjKTsKPiA+ICsJc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICppbnRlbF9w c3RhdGUgPSB0b19pbnRlbF9wbGFuZV9zdGF0ZShwc3RhdGUpOwo+ID4gIAlzdHJ1Y3QgZHJtX2Zy YW1lYnVmZmVyICpmYiA9IHBzdGF0ZS0+ZmI7Cj4gPiArCXVuc2lnbmVkIHcgPSBkcm1fcmVjdF93 aWR0aCgmaW50ZWxfcHN0YXRlLT5kc3QpOwo+ID4gKwl1bnNpZ25lZCBoID0gZHJtX3JlY3RfaGVp Z2h0KCZpbnRlbF9wc3RhdGUtPmRzdCk7Cj4gCj4gSSB0aGluayB5b3UncmUgc3VwcG9zZWQgdG8g dXNlIHRoZSBzcmMgZGltZW5zaW9ucyBpbiBtb3N0IHBsYWNlcy4KCkhtbSwganVzdCB3ZW50IGJh Y2sgdG8gZG91YmxlIGNoZWNrIHRoZSBicHNlYyBhbmQgaWYgSSdtIGludGVycHJldGluZyBpdApj b3JyZWN0bHksIGl0IGxvb2tzIGxpa2Ugd2UgYWN0dWFsbHkgbmVlZCB0byB1c2UgdGhlIGxhcmdl ciBvZiB0aGUgdHdvOgoiRG93biBzY2FsaW5nIGVmZmVjdGl2ZWx5IGluY3JlYXNlcyB0aGUgcGl4 ZWwgcmF0ZS4gVXAgc2NhbGluZyBkb2VzIG5vdApyZWR1Y2UgdGhlIHBpeGVsIHJhdGUuIgoKVGhh bmtzIGZvciBwb2ludGluZyB0aGF0IG91dDsgSSdsbCBzZW5kIGFuIHVwZGF0ZWQgcGF0Y2guCgoK Ck1hdHQKCj4gCj4gPiAgCj4gPiAgCS8qIGZvciBwbGFuYXIgZm9ybWF0ICovCj4gPiAgCWlmIChm Yi0+cGl4ZWxfZm9ybWF0ID09IERSTV9GT1JNQVRfTlYxMikgewo+ID4gIAkJaWYgKHkpICAvKiB5 LXBsYW5lIGRhdGEgcmF0ZSAqLwo+ID4gLQkJCXJldHVybiBpbnRlbF9jcnRjLT5jb25maWctPnBp cGVfc3JjX3cgKgo+ID4gLQkJCQlpbnRlbF9jcnRjLT5jb25maWctPnBpcGVfc3JjX2ggKgo+ID4g LQkJCQlkcm1fZm9ybWF0X3BsYW5lX2NwcChmYi0+cGl4ZWxfZm9ybWF0LCAwKTsKPiA+ICsJCQly ZXR1cm4gdyAqIGggKiBkcm1fZm9ybWF0X3BsYW5lX2NwcChmYi0+cGl4ZWxfZm9ybWF0LCAwKTsK PiA+ICAJCWVsc2UgICAgLyogdXYtcGxhbmUgZGF0YSByYXRlICovCj4gPiAtCQkJcmV0dXJuIChp bnRlbF9jcnRjLT5jb25maWctPnBpcGVfc3JjX3cvMikgKgo+ID4gLQkJCQkoaW50ZWxfY3J0Yy0+ Y29uZmlnLT5waXBlX3NyY19oLzIpICoKPiA+ICsJCQlyZXR1cm4gKHcvMikgKiAoaC8yKSAqCj4g PiAgCQkJCWRybV9mb3JtYXRfcGxhbmVfY3BwKGZiLT5waXhlbF9mb3JtYXQsIDEpOwo+ID4gIAl9 Cj4gPiAgCj4gPiAgCS8qIGZvciBwYWNrZWQgZm9ybWF0cyAqLwo+ID4gLQlyZXR1cm4gaW50ZWxf Y3J0Yy0+Y29uZmlnLT5waXBlX3NyY193ICoKPiA+IC0JCWludGVsX2NydGMtPmNvbmZpZy0+cGlw ZV9zcmNfaCAqCj4gPiAtCQlkcm1fZm9ybWF0X3BsYW5lX2NwcChmYi0+cGl4ZWxfZm9ybWF0LCAw KTsKPiA+ICsJcmV0dXJuIHcgKiBoICogZHJtX2Zvcm1hdF9wbGFuZV9jcHAoZmItPnBpeGVsX2Zv cm1hdCwgMCk7Cj4gPiAgfQo+ID4gIAo+ID4gIC8qCj4gPiBAQCAtMjk2MCw2ICsyOTU3LDggQEAg c2tsX2FsbG9jYXRlX3BpcGVfZGRiKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4g PiAgCSAqIEZJWE1FOiB3ZSBtYXkgbm90IGFsbG9jYXRlIGV2ZXJ5IHNpbmdsZSBibG9jayBoZXJl Lgo+ID4gIAkgKi8KPiA+ICAJdG90YWxfZGF0YV9yYXRlID0gc2tsX2dldF90b3RhbF9yZWxhdGl2 ZV9kYXRhX3JhdGUoY3N0YXRlKTsKPiA+ICsJaWYgKCF0b3RhbF9kYXRhX3JhdGUpCj4gPiArCQly ZXR1cm47Cj4gPiAgCj4gPiAgCXN0YXJ0ID0gYWxsb2MtPnN0YXJ0Owo+ID4gIAlmb3JfZWFjaF9p bnRlbF9wbGFuZV9vbl9jcnRjKGRldiwgaW50ZWxfY3J0YywgaW50ZWxfcGxhbmUpIHsKPiA+IEBA IC0zMDkzLDEyICszMDkyLDE1IEBAIHN0YXRpYyBib29sIHNrbF9jb21wdXRlX3BsYW5lX3dtKGNv bnN0IHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICB7Cj4gPiAgCXN0cnVj dCBkcm1fcGxhbmUgKnBsYW5lID0gJmludGVsX3BsYW5lLT5iYXNlOwo+ID4gIAlzdHJ1Y3QgZHJt X2ZyYW1lYnVmZmVyICpmYiA9IHBsYW5lLT5zdGF0ZS0+ZmI7Cj4gPiArCXN0cnVjdCBpbnRlbF9w bGFuZV9zdGF0ZSAqaW50ZWxfcHN0YXRlID0KPiA+ICsJCXRvX2ludGVsX3BsYW5lX3N0YXRlKHBs YW5lLT5zdGF0ZSk7Cj4gPiAgCXVpbnQzMl90IGxhdGVuY3kgPSBkZXZfcHJpdi0+d20uc2tsX2xh dGVuY3lbbGV2ZWxdOwo+ID4gIAl1aW50MzJfdCBtZXRob2QxLCBtZXRob2QyOwo+ID4gIAl1aW50 MzJfdCBwbGFuZV9ieXRlc19wZXJfbGluZSwgcGxhbmVfYmxvY2tzX3Blcl9saW5lOwo+ID4gIAl1 aW50MzJfdCByZXNfYmxvY2tzLCByZXNfbGluZXM7Cj4gPiAgCXVpbnQzMl90IHNlbGVjdGVkX3Jl c3VsdDsKPiA+ICAJdWludDhfdCBieXRlc19wZXJfcGl4ZWw7Cj4gPiArCXVuc2lnbmVkIHcgPSBk cm1fcmVjdF93aWR0aCgmaW50ZWxfcHN0YXRlLT5kc3QpOwo+ID4gIAo+ID4gIAlpZiAobGF0ZW5j eSA9PSAwIHx8ICFjc3RhdGUtPmJhc2UuYWN0aXZlIHx8ICFmYikKPiA+ICAJCXJldHVybiBmYWxz ZTsKPiA+IEBAIC0zMTA5LDEyICszMTExLDEyIEBAIHN0YXRpYyBib29sIHNrbF9jb21wdXRlX3Bs YW5lX3dtKGNvbnN0IHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICAJCQkJ IGxhdGVuY3kpOwo+ID4gIAltZXRob2QyID0gc2tsX3dtX21ldGhvZDIoc2tsX3BpcGVfcGl4ZWxf cmF0ZShjc3RhdGUpLAo+ID4gIAkJCQkgY3N0YXRlLT5iYXNlLmFkanVzdGVkX21vZGUuY3J0Y19o dG90YWwsCj4gPiAtCQkJCSBjc3RhdGUtPnBpcGVfc3JjX3csCj4gPiArCQkJCSB3LAo+ID4gIAkJ CQkgYnl0ZXNfcGVyX3BpeGVsLAo+ID4gIAkJCQkgZmItPm1vZGlmaWVyWzBdLAo+ID4gIAkJCQkg bGF0ZW5jeSk7Cj4gPiAgCj4gPiAtCXBsYW5lX2J5dGVzX3Blcl9saW5lID0gY3N0YXRlLT5waXBl X3NyY193ICogYnl0ZXNfcGVyX3BpeGVsOwo+ID4gKwlwbGFuZV9ieXRlc19wZXJfbGluZSA9IHcg KiBieXRlc19wZXJfcGl4ZWw7Cj4gPiAgCXBsYW5lX2Jsb2Nrc19wZXJfbGluZSA9IERJVl9ST1VO RF9VUChwbGFuZV9ieXRlc19wZXJfbGluZSwgNTEyKTsKPiA+ICAKPiA+ICAJaWYgKGZiLT5tb2Rp ZmllclswXSA9PSBJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRCB8fAo+ID4gLS0gCj4gPiAyLjEuNAo+ ID4gCj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwo+ID4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo+IAo+IC0tIAo+IFZpbGxlIFN5cmrDpGzDpAo+IEludGVsIE9UQwoKLS0gCk1hdHQg Um9wZXIKR3JhcGhpY3MgU29mdHdhcmUgRW5naW5lZXIKSW9URyBQbGF0Zm9ybSBFbmFibGluZyAm IERldmVsb3BtZW50CkludGVsIENvcnBvcmF0aW9uCig5MTYpIDM1Ni0yNzk1Cl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==