Re: [PATCH v4 21/38] drm/i915: Added a module parameter for allowing scheduler overrides

John Harrison
2016-01-12T11:34:48Z

On 11/01/2016 22:24, Chris Wilson wrote:
> On Mon, Jan 11, 2016 at 06:42:50PM +0000, John.C.Harrison@Intel.com wrote:
>> From: John Harrison <John.C.Harrison@Intel.com>
>>
>> It can be useful to be able to disable certain features (e.g. the
>> entire scheduler) via a module parameter for debugging purposes. A
>> parameter has the advantage of not being a compile time switch but
>> without implying that it can be changed dynamically at runtime.
>> +module_param_named(scheduler_override, i915.scheduler_override, int, 0600);
>> +MODULE_PARM_DESC(scheduler_override, "Scheduler override mask (0 = none, 1 = direct submission [default])");
> Is this consistent with the other *enable* booleans?
Initially there were a whole bunch of override flags for
disabling/tweaking specific bits of the scheduler's operation. Since
these extras now only exist in an internal debugging patch that is not
going to be upstreamed, I guess it probably should be simplified to a
bool rather than a flags word.

> -Chris
>