From: Matt Roper <matthew.d.roper@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: skl_update_scaler() wants a rotation bitmask instead of bit number
Date: Fri, 15 Jan 2016 15:15:00 -0800 [thread overview]
Message-ID: <20160115231500.GB11055@intel.com> (raw)
In-Reply-To: <20160115184826.GF23290@intel.com>
On Fri, Jan 15, 2016 at 08:48:26PM +0200, Ville Syrjälä wrote:
> On Thu, Oct 15, 2015 at 05:01:58PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Pass BIT(DRM_ROTATE_0) instead of DRM_ROTATE_0 to skl_update_scaler().
> > The former is a mask, the latter just the bit number.
> >
> > Fortunately the only thing skl_update_scaler() does with the rotation
> > is check if it's 90/270 degrees or not, and so in this case it would
> > still do the right thing.
> >
> > Cc: Chandra Konduru <chandra.konduru@intel.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Ping, anyone care to r-b this one?
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Looks like this bug has been present since scalers were first added in
6156a45602f9 ("drm/i915: skylake primary plane scaling using shared scalers")
Matt
>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 7498c9d..02316d0 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -4673,7 +4673,7 @@ int skl_update_scaler_crtc(struct intel_crtc_state *state)
> > intel_crtc->base.base.id, intel_crtc->pipe, SKL_CRTC_INDEX);
> >
> > return skl_update_scaler(state, !state->base.active, SKL_CRTC_INDEX,
> > - &state->scaler_state.scaler_id, DRM_ROTATE_0,
> > + &state->scaler_state.scaler_id, BIT(DRM_ROTATE_0),
> > state->pipe_src_w, state->pipe_src_h,
> > adjusted_mode->crtc_hdisplay, adjusted_mode->crtc_vdisplay);
> > }
> > --
> > 2.4.9
>
> --
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-15 23:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 14:01 [PATCH] drm/i915: skl_update_scaler() wants a rotation bitmask instead of bit number ville.syrjala
2016-01-15 18:48 ` Ville Syrjälä
2016-01-15 23:15 ` Matt Roper [this message]
2016-01-18 14:21 ` Ville Syrjälä
2016-01-19 8:03 ` Daniel Vetter
2016-01-19 13:18 ` Ville Syrjälä
2016-01-19 14:01 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115231500.GB11055@intel.com \
--to=matthew.d.roper@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).