From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915: add DOC: headline to RC6 kernel-doc
Date: Tue, 19 Jan 2016 21:09:15 +0100 [thread overview]
Message-ID: <20160119200915.GP19130@phenom.ffwll.local> (raw)
In-Reply-To: <1453101588-18008-3-git-send-email-jani.nikula@intel.com>
On Mon, Jan 18, 2016 at 09:19:48AM +0200, Jani Nikula wrote:
> Without the DOC:, kernel-doc confuses the documentation block for
> something else.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Hm, we don't pull intel_pm.c into the gpu.tmpl at all, which means
kernel-CI won't test this for us. Care to throw a generic "PM stuff"
section in there for this? Otherwise the DOC: section here is a bit
pointless. Anyway for the series:
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 7e6e70054d6a..180555553fa2 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -32,6 +32,8 @@
> #include <linux/module.h>
>
> /**
> + * DOC: RC6
> + *
> * RC6 is a special power stage which allows the GPU to enter an very
> * low-voltage mode when idle, using down to 0V while at this stage. This
> * stage is entered automatically when the GPU is idle when RC6 support is
> --
> 2.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-01-19 20:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 7:19 [PATCH 1/3] drm/i915/sdvo: revert bogus kernel-doc comments to normal comments Jani Nikula
2016-01-18 7:19 ` [PATCH 2/3] drm/i915: turn some " Jani Nikula
2016-01-18 7:19 ` [PATCH 3/3] drm/i915: add DOC: headline to RC6 kernel-doc Jani Nikula
2016-01-19 20:09 ` Daniel Vetter [this message]
2016-01-20 9:38 ` Jani Nikula
2016-01-18 7:49 ` ✗ Fi.CI.BAT: warning for series starting with [1/3] drm/i915/sdvo: revert bogus kernel-doc comments to normal comments Patchwork
2016-01-19 20:10 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119200915.GP19130@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox